Re: trying to track a change to drivers/isdn/usb-gigaset.c

Re: trying to track a change to drivers/isdn/usb-gigaset.c

[David Miller]

From: Tilman Schmidt <tilman@imap.cc>
Date: Mon, 07 May 2007 11:55:06 +0200

[ netdev@vger.kernel.org is the place to discuss kernel networking
  issues, thanks ]

> But I cannot remember seeing that patch via the maintainer
> addresses for ISDN or the Gigaset driver, and the LKML archive
> doesn't seem to have it either.
> 
> Where was that patch discussed? What is its rationale?

This was a wholesale change done across the entire tree, they were all
straightforward transformations that didn't change what the code did.

It was a change done so that we could hide the skb data buffering
details to the point where we could change the protocol header
pointers into 32-bit offsets which saves 4 bytes per such pointer per
protocol header stored in struct sk_buff.

We're not going to notify the maintainer of each of the hundreds of
source files we had to touch in order to pull this off, sorry.

These changes were posted to netdev@vger.kernel.org, they also
sat in Andrew Morton's -mm tree for quite some time.

Re: trying to track a change to drivers/isdn/usb-gigaset.c

[Tilman Schmidt]

[-- Attachment #1: Type: text/plain, Size: 678 bytes --]

David Miller schrieb:
> [ netdev@vger.kernel.org is the place to discuss kernel networking
>   issues, thanks ]

OIC. My bad. I didn't make the connection from "skb" to "networking". Sorry.

> It was a change done so that we could hide the skb data buffering
> details to the point where we could change the protocol header
> pointers into 32-bit offsets which saves 4 bytes per such pointer per
> protocol header stored in struct sk_buff.

Thanks for the explanation.

-- 
Tilman Schmidt                    E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]