netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: Kim Phillips <kim.phillips@freescale.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	"Ismail Dönmez" <ismail@pardus.org.tr>,
	"Kumar Gala" <galak@kernel.crashing.org>
Subject: Re: Kconfig warnings on latest GIT
Date: Tue, 08 May 2007 15:11:52 -0500	[thread overview]
Message-ID: <4640D988.1040504@freescale.com> (raw)
In-Reply-To: <20070508143127.38fafa3c.kim.phillips@freescale.com>

Kim Phillips wrote:
> On Tue, 8 May 2007 00:04:14 +0300
> Ismail Dönmez <ismail@pardus.org.tr> wrote:
> 
>> drivers/net/Kconfig:2279:warning: 'select' used by config symbol 'UCC_GETH' 
>> refers to undefined symbol 'UCC_FAST'
> 
> looks like this introduces the error:
> 
> commit 7d776cb596994219584257eb5956b87628e5deaf
> Author: Timur Tabi <timur@freescale.com>
> Date:   Mon Mar 12 15:40:27 2007 -0500
> 
>     [POWERPC] QE: automatically select QE options

I have a dilemma, so I need help fixing this bug.

This particular patch is necessary because without it, selecting support for the QE is too 
complicated.

Background: The QUICC Engine (QE) is a microcontroller on some Freescale CPUs that can 
mimic a wide variety of devices.  It has multiple controllers (called UCCs), and each one 
can be an ethernet device, or a UART, or an HDLC thingy, etc.  There's a QE library and a 
bunch of other support code in the arch/powerpc directory, so the QE is a powerpc-specific 
device.  However, all of the drivers that use it are located in drivers/xxx.

This isn't a new problem.  The common solution is to define some intermediate Kconfig 
option, like UCC_FAST_TEMP in the driver's Kconfig.  Selecting UCC_FAST will then also set 
UCC_FAST_TEMP.  The device driver then depends on UCC_FAST_TEMP.

There's also a UCC_SLOW option with the same problem.

The dillema is that there is no single device driver class that depends on UCC_FAST. 
Currently, there's only one that uses UCC_FAST: the ucc_geth driver.  But I'm also working 
on a UART driver.

So my question is: in which Kconfig do I define "UCC_FAST_TEMP" and "UCC_SLOW_TEMP"?  At 
first I thought, just put it in drivers/Kconfig, but that Kconfig does nothing but 
including other Kconfigs.  I believe that if I submit a patch that adds "UCC_FAST_TEMP" 
and "UCC_SLOW_TEMP" to drivers/Kconfig, it will be rejected.  Either that, or I'll spend 
six weeks trying to persuade everyone that it's a good idea.

Does anyone have any suggestions on how I can fix this?

-- 
Timur Tabi
Linux Kernel Developer @ Freescale

  reply	other threads:[~2007-05-08 20:12 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-07 21:04 Kconfig warnings on latest GIT Ismail Dönmez
2007-05-08 19:31 ` Kim Phillips
2007-05-08 20:11   ` Timur Tabi [this message]
2007-05-10  5:10     ` Simon Horman
2007-05-10 15:39       ` Johannes Berg
2007-05-11  1:22         ` Simon Horman
2007-05-11 11:45           ` Johannes Berg
2007-05-14  1:32             ` Simon Horman
2007-05-14 12:55               ` Johannes Berg
2007-05-14 14:24                 ` Kumar Gala
2007-05-14 16:25                   ` Johannes Berg
2007-05-10 16:56       ` Timur Tabi
2007-05-11  1:25         ` Simon Horman
2007-05-11  1:41           ` Kumar Gala
2007-05-11  1:47           ` Kumar Gala
2007-05-11  2:05             ` Simon Horman
2007-05-11  2:13               ` Kumar Gala
2007-05-11  2:27                 ` Simon Horman
2007-05-11  2:32                   ` Timur Tabi
2007-05-11  3:08                   ` Simon Horman
2007-05-11  7:43             ` Russell King
2007-05-11 12:38               ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4640D988.1040504@freescale.com \
    --to=timur@freescale.com \
    --cc=galak@kernel.crashing.org \
    --cc=ismail@pardus.org.tr \
    --cc=kim.phillips@freescale.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).