From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 960FFC77B72 for ; Thu, 20 Apr 2023 18:14:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231414AbjDTSOm (ORCPT ); Thu, 20 Apr 2023 14:14:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229877AbjDTSOk (ORCPT ); Thu, 20 Apr 2023 14:14:40 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97E8D4233 for ; Thu, 20 Apr 2023 11:14:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682014476; x=1713550476; h=message-id:date:subject:from:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=IoWoxJj/UKstxkTA/+El0/4QNo6C8CQREXgu8Kt4Fpc=; b=N0DZconBQJ38myhB+Xz5+HgaV+ocq6b4rrY9zThyCCVSQoVObnlj41W/ WIDh5HO66wM+2YCP86An0oR70hFL7e/pnatZKKiHGeUEuKnASqmxOVwIb hcfnsgL7FrvzBKM/UAETRU/G4OctKbrwJLPzwZo5dPTsfM3ZivI/hAuha Js3bsjFtRe37kG1cerHRTMdUDNXZfJFy0tRcIhprbAS7raFMfdiQ0CwhC VQZ2nPJFGydqlKgnPQuvxPNpkkn2SZsLUt3udKm74gDVxzeU7c5riyxYS 8CWgVGpIKSFVTyqZckgmseiRQhZxh1lNnIttKzLLmgDy/NAfcq4EMI+Nj Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10686"; a="373730668" X-IronPort-AV: E=Sophos;i="5.99,213,1677571200"; d="scan'208";a="373730668" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2023 11:13:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10686"; a="1021656248" X-IronPort-AV: E=Sophos;i="5.99,213,1677571200"; d="scan'208";a="1021656248" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga005.fm.intel.com with ESMTP; 20 Apr 2023 11:13:16 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 20 Apr 2023 11:13:16 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 20 Apr 2023 11:13:15 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 20 Apr 2023 11:13:15 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.105) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 20 Apr 2023 11:13:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fohKlBCdKoN3CkGVJBGPW76rdAPZLsLDY10x3gZ5psNDk6RSdj3wOxhMIZRwl+jig3/H3q82Uwj3SfACtSX671d0E9dJgc/dwKPAKmCPdr8A2q9mbWKVpH5OmoS2opXkvqirpZf74a5Xtz3i3pQ1uPWkHypRCrxUIti4T40mV/AhpX8he0QQBUhx8cO++PFQeJ2KgPy7ggROZCN5Syp8wtqmmcCeCrKfwVZYVk05t/BKLTmjBXQhez7afVtPNLJU85bHwdCNtVxRC57Xxvngl4PlmAlhLmowEaCLVVmT5J0vLlg+dJN4+jtdtw/RBSRcCjr+Yb7cIuJL8HwURoT6MQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iIpDa+xj2ILGL1f1Xv52TrxqmCw2Q/GyARM5BeVjsuQ=; b=DOulFX9GSI9rfsQk4NPa42oTLw/NO7AYCeJtr5WHxomVitrkGWnM6RJKSwmfern0KuHX7YGBcjxgoTIAOdvuHP0zQrfhX1twTGYD7H/d8qjl9reJvLJJdqXV9+i+G5sUEbAa8rEXplOyDvIkb6yOdCrf+pLVzLOpVbZuBpbgTR6rUZHlL7b8V4KdDwAR1xSIlAy66WvAfmfmcYr+WSoluuAL4vu/q7fO6+UnOL3mAcovlh7T0wDmGd8nHFmkESO8Fza7qaSE90/GUyvLlDX+UMy0nHJWGubiwtq+wF9dlHpWpYYsaAa6DI/U6ZRYjCBHjM0qVZzCx71/q/4JGRRehQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MW3PR11MB4538.namprd11.prod.outlook.com (2603:10b6:303:57::12) by BN9PR11MB5436.namprd11.prod.outlook.com (2603:10b6:408:101::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.22; Thu, 20 Apr 2023 18:13:13 +0000 Received: from MW3PR11MB4538.namprd11.prod.outlook.com ([fe80::aae6:d608:6b8d:977e]) by MW3PR11MB4538.namprd11.prod.outlook.com ([fe80::aae6:d608:6b8d:977e%4]) with mapi id 15.20.6319.022; Thu, 20 Apr 2023 18:13:12 +0000 Message-ID: <4640cb7c-faac-d548-b0dd-4519396e9f25@intel.com> Date: Thu, 20 Apr 2023 11:13:09 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.10.0 Subject: Re: [Intel-wired-lan] [PATCH net-next v2 02/15] idpf: add module register and probe functionality Content-Language: en-US From: "Tantilov, Emil S" To: Leon Romanovsky , Pavan Kumar Linga CC: , , Shailendra Bhatnagar , , , , , , , Phani Burra , , References: <20230411011354.2619359-1-pavan.kumar.linga@intel.com> <20230411011354.2619359-3-pavan.kumar.linga@intel.com> <20230411123653.GW182481@unreal> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SJ0PR13CA0031.namprd13.prod.outlook.com (2603:10b6:a03:2c2::6) To MW3PR11MB4538.namprd11.prod.outlook.com (2603:10b6:303:57::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW3PR11MB4538:EE_|BN9PR11MB5436:EE_ X-MS-Office365-Filtering-Correlation-Id: 4b02e265-aa96-43bb-d6be-08db41cae762 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b0sfhS+tatUpxk/XJ0J5cVDjpuO3GZUPE9fvJ+4wXu134Mcfxht2z6hFkkm03+hzX2mZ0IFAjJYD0AU7osvJM0TBASO5xJxXnglWBMQbQ4BDwTd531c6G7nqo9ex0h029sn9Pusbde1YQmihbkk3Pio4geizehq/2qtz2uO040ezgiERLklSi117g3jEIXPz4kSjfbf9+Nm05BssshLlycDVRCiSEyR4udoiU/yagVqVLhrsvkmi6D3EKJDFvdy8cHKzgmLNfe9IWXxYnKTIc0hRTO9t3g/sQi7ZcZmq/upZDdtjjPZot+fKEL4Y+DMIXVBFm3MJk2FqUf8nccw62BndqJEYIffYWJ9rttzXllFv7Y93H5t1gReaU+/txHvdGiBuqXtMtx/t8q7i22GrHot3F7QqL/pedQ5C7JF5Vj0fscJ5LRKyHJ1FIrRHL0eLm8tXivKJQmi4/RT+WbVCuugNstghGzWiTh3Z5gqEyW5pTUHDoCT9065YxhaeFFgYIkaCTRp99HV/t9IhMp6PBFaGyrNLQwUIM9FPGOHRK5N+C1ZuwD5WwitSEU4EjVOVEe7BcfiKiZ4+loiMUuBnEVbqnL8qK+BVxJwWKYEEW/zhAemH4GllLc9p3oWodbMd48PyyoUbCCFPByb0yAMyrQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR11MB4538.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(136003)(366004)(376002)(396003)(39860400002)(451199021)(31686004)(82960400001)(36756003)(4326008)(54906003)(6636002)(110136005)(316002)(66946007)(66556008)(66476007)(186003)(53546011)(6506007)(6512007)(26005)(2616005)(83380400001)(31696002)(38100700002)(8676002)(41300700001)(5660300002)(6666004)(478600001)(8936002)(6486002)(2906002)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RTBteHlMd3JCVEtGZzBGYnJhWFhDeTNlRi9sLzkrZG5hd2VQbDNyVGlNVzZr?= =?utf-8?B?c3NZbUlWbXJhUGo0dHZoN0VEVW8ydnNGQ2lOWDBvbHVuN0gwemZtbnFxU2Vv?= =?utf-8?B?eHk2N2FGRzhEOGpGeHdmOHdGM28vd2VzVyt0a1QwSkdybzZWdkx1Z1FXQ2NL?= =?utf-8?B?RnFPK2VDZDZtcEw4N1ZEWGN3Rk9nYUV3SEtwVzBHU0V4ejNHc3pZZVg1TUkw?= =?utf-8?B?WUpudnF0NGZBaEE2TTk2LzhCUjQrOHBoaWFkVGlpVVhsQzhxdFVYVzZiL2NG?= =?utf-8?B?RERLdXRHSXJVY1krMlF3dWdaV2dPOE9IUDdhOFVUek8rc0dFSlBjWFljd21K?= =?utf-8?B?N3ZxM2ZoVlZGS1M1VDBhaC9mNXlvaEdCWWswNVBqWUxad05UUGdYNExtZGJ0?= =?utf-8?B?R0c5RWpHdURuSFl2L3FJanlORktxd0dDS1lWZHhGcmx6a3pDTHY1ZFNEWGhI?= =?utf-8?B?ZHBoQ3Y3b0VRUGZ3YTZIV0IzODFtbGZvMjQzR0dOU2pBaG8wR1dSSkZJR0JM?= =?utf-8?B?bWFEc3lldWFzLzdFSHpzK1p2V3ptS3QzMkMrRDF0NmJWVGxtTXV2YmFCcnpx?= =?utf-8?B?SXlDRC9FUFFOYWY4UTNFakxMU0YrNjcrZGpBKzZrWGlZSFVVZXIwaU90OUI2?= =?utf-8?B?OE5KVkVzNkpWejI2Zldpa3R3SzZVM3Exdko5a3hpMGZ1aUI3OUZ6dEN4RnJl?= =?utf-8?B?aDhMVWJFRTRIUkVIdVZrQy9JRGg4aThMSTRMTnpMdHRHOGtaQkY4bTVUM0U5?= =?utf-8?B?Qlc4VmJwMUZ1dnFyS2RCeVpKQjU2QXBmN2NmWjBzVVova3UxbjBvdGlmVGdK?= =?utf-8?B?am4rYmJaY0Z2bVIyem82OTBDbkl3Q3Z6Qkd0b3lpNjhLd0c1bkNIQ0UybHkw?= =?utf-8?B?QnRjUlhRdmJuTm0yRFRhTnhsUTR4TExvODdUYUJidm9XUlY4Wi9zL3RIcWZS?= =?utf-8?B?Um43d1ZrZFhCeEVQditKcjlkUm5tVm5lTzJteURJUDIrTTFQYTdvODZwd2o1?= =?utf-8?B?Q1dtS1lmWTRTWEJIR2NoUjNvRjBSeUl3UWpqbi9BdlExaVRqZXk3T3ZkeTY1?= =?utf-8?B?UTg5NjRUTGFmajNjTWVZaGI2RjV3L05LL28wbjdvWmx1R2gxVnN0a2ZuVHZ1?= =?utf-8?B?bFZQRVQ1Sjg5NVFlN0hHUzRVSGd6UEd4TFJaZm5xb0hBMHJKVE8yMmRJV3hN?= =?utf-8?B?dWxLL0c3SXpHR3Y1KzJIY1pWd0pDU0hLYnZNQzAvL2daelNvc3k5UnRidEdO?= =?utf-8?B?SXZkL1JxellDN0sraVZxZWVLa2ROVk5xeldyTFNxcElYU2Y0M1RrVnJnek0v?= =?utf-8?B?T2F3eHprS2IwR3h4SEJtZEg0bmVFSFArbVBsdHhQSzFRd1R6NzdENGNnNlQ5?= =?utf-8?B?YnRDVm9mTitDYWRaTWI5TVBiUWxRd3d4ZEZqKzdwWlFsNTNTTlE4Zmp6cWFD?= =?utf-8?B?NEYzbnFaUUgxZko5VzFyK1Y4aUhJYjlabGYraXR4R1crcGtSeE9KTnVDWTlN?= =?utf-8?B?S0FzMGg0V1lJRHNWRXdzajYrWUF2aVc3dGlBSVNJTlpGeXEvNXZWdTd1bTc0?= =?utf-8?B?QmpmL25pcllsd3BoMG11Y1QrRFlQVGhjKzY3b2VlR0N5NTdSQXEyNlNRYWgr?= =?utf-8?B?U05GRXcwQW50ZHZPTHlFNlVhWVVJL3BnOUM2T0haRmhYL04xN1ZmRExQYk5x?= =?utf-8?B?c21pUSsxRFEvMGp2NTB1YmNMenBvM3c5NjYxeEZKQk5qZlBreVlBcGxnbnUx?= =?utf-8?B?VEpocWtxYTg3WUVaei9sbUtOZ3I4SmdiQ0hvTm1vNFhmTHRnQjA3T0FpQ2FH?= =?utf-8?B?RVpEbGh6S0VUdUt0ZUgySHZ6WVRCOFQ5ZWtiam5zd1B5WjZ4dDhyVXo1d2dQ?= =?utf-8?B?Vi9hdUhnczYvaEdaSUtIOC8zZUhtN2xJOW1qUnpzL2xKazcwclZlWWNpOU8r?= =?utf-8?B?ZVhCQi94V3Nwa3VrKzU1aU1hT1ZQMHhEZWkwZkZHOWx2Nk5YS3EwRWJheE1t?= =?utf-8?B?aVkyMVRjK2J6YlAvTzZjWFlwaTMyeEhOZDBxN01YbG1FbGJ4c2x3MDlyaFRD?= =?utf-8?B?OFhmV2RIRjFyK2NnN01RYkc2a3VKTFZpV2svYnExeWNBTHFTNmpJaWVGTWdG?= =?utf-8?B?NzY1Qjg0TUl3YTNFdlpyUkh1WGczWTVWMXl5bXhyVGF2bE9yWUZXQ1kraG8z?= =?utf-8?B?aEE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4b02e265-aa96-43bb-d6be-08db41cae762 X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4538.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2023 18:13:12.6799 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: I5tSeHBIb0CB/ABbFHPLBmEN1Werbsp4iIYYFqn8K8e4DBg15mZQfNGxUFWoaLd1vRbnHhSN8rnWS/tz+4LqCsMe3hKRpKfClCAyD37eZxY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5436 X-OriginatorOrg: intel.com Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/12/2023 4:10 PM, Tantilov, Emil S wrote: > > > On 4/11/2023 5:36 AM, Leon Romanovsky wrote: >> On Mon, Apr 10, 2023 at 06:13:41PM -0700, Pavan Kumar Linga wrote: >>> From: Phani Burra >>> >>> Add the required support to register IDPF PCI driver, as well as >>> probe and remove call backs. Enable the PCI device and request >>> the kernel to reserve the memory resources that will be used by the >>> driver. Finally map the BAR0 address space. >>> >>> PCI IDs table is intentionally left blank to prevent the kernel from >>> probing the device with the incomplete driver. It will be added >>> in the last patch of the series. >>> >>> Signed-off-by: Phani Burra >>> Co-developed-by: Alan Brady >>> Signed-off-by: Alan Brady >>> Co-developed-by: Madhu Chittim >>> Signed-off-by: Madhu Chittim >>> Co-developed-by: Shailendra Bhatnagar >>> Signed-off-by: Shailendra Bhatnagar >>> Co-developed-by: Pavan Kumar Linga >>> Signed-off-by: Pavan Kumar Linga >>> Reviewed-by: Sridhar Samudrala >>> Reviewed-by: Willem de Bruijn >>> --- >>>   drivers/net/ethernet/intel/Kconfig            | 11 +++ >>>   drivers/net/ethernet/intel/Makefile           |  1 + >>>   drivers/net/ethernet/intel/idpf/Makefile      | 10 ++ >>>   drivers/net/ethernet/intel/idpf/idpf.h        | 27 ++++++ >>>   .../net/ethernet/intel/idpf/idpf_controlq.h   | 14 +++ >>>   drivers/net/ethernet/intel/idpf/idpf_lib.c    | 96 +++++++++++++++++++ >>>   drivers/net/ethernet/intel/idpf/idpf_main.c   | 70 ++++++++++++++ >>>   7 files changed, 229 insertions(+) >>>   create mode 100644 drivers/net/ethernet/intel/idpf/Makefile >>>   create mode 100644 drivers/net/ethernet/intel/idpf/idpf.h >>>   create mode 100644 drivers/net/ethernet/intel/idpf/idpf_controlq.h >>>   create mode 100644 drivers/net/ethernet/intel/idpf/idpf_lib.c >>>   create mode 100644 drivers/net/ethernet/intel/idpf/idpf_main.c >> >> <...> >>> +} >>> + >>> +/* idpf_pci_tbl - PCI Dev idpf ID Table >>> + */ >>> +static const struct pci_device_id idpf_pci_tbl[] = { >>> +    { /* Sentinel */ } >> >> What does it mean empty pci_device_id table? > > Device ID's are added later, but it does make sense to be in this patch > instead. Will fix in v3. On second look, the reason PCI ids are added in the last patch is because none of the modules from the previous patches would result in a functional driver. Thanks, Emil