From: Jeff Garzik <jeff@garzik.org>
To: Paul Walmsley <paul@booyaka.com>
Cc: mikep@linuxtr.net, netdev@vger.kernel.org, linux-tr@linuxtr.net
Subject: Re: [PATCH] Fix hang on IBM Token Ring PCMCIA card ejection
Date: Wed, 09 May 2007 19:25:33 -0400 [thread overview]
Message-ID: <4642586D.4070300@garzik.org> (raw)
In-Reply-To: <20070509164803.557732761@booyaka.com>
Paul Walmsley wrote:
> Ejecting a PCMCIA IBM Token Ring card that has not had its dev->open()
> called will reliably trigger an uninitialized spinlock oops when
> spinlock debugging is enabled. The system then hangs, occasionally
> softlockup oopsing. Apparently ibmtr.c:tok_interrupt() doesn't expect
> to be called before tok_open(), but tok_interrupt() gets called anyway
> when the card is ejected. So, set an already-existing flag which
> causes tok_interrupt() to bail out early upon card ejection. Tested by
> inserting and removing the PCMCIA card several times.
>
> Patch against 2.6.21-rc6.
>
>
> Signed-off-by: Paul Walmsley <paul@booyaka.com>
>
> ---
> ibmtr_cs.c | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
applied
prev parent reply other threads:[~2007-05-09 23:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070509164715.430844867@booyaka.com>
2007-05-09 16:47 ` [PATCH] From: Paul Walmsley <paul@booyaka.com> Paul Walmsley
2007-05-09 23:25 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4642586D.4070300@garzik.org \
--to=jeff@garzik.org \
--cc=linux-tr@linuxtr.net \
--cc=mikep@linuxtr.net \
--cc=netdev@vger.kernel.org \
--cc=paul@booyaka.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).