From: Jeff Garzik <jeff@garzik.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: matvejchikov@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] phylib: phy_ethtool_{sset,gset} -- check phydev for NULL
Date: Thu, 10 May 2007 14:19:01 -0400 [thread overview]
Message-ID: <46436215.7030503@garzik.org> (raw)
In-Reply-To: <20070510105613.f564e083.randy.dunlap@oracle.com>
Randy Dunlap wrote:
> and I hope that Jeff prefers (as some others do):
>
> if (unlikely(phydev == NULL))
>
> or even
>
> if (unlikely(!phydev))
That is indeed my preference :)
Jeff
next prev parent reply other threads:[~2007-05-10 18:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-10 17:29 [PATCH] phylib: phy_ethtool_{sset,gset} -- check phydev for NULL Matvejchikov Ilya
2007-05-10 17:56 ` Randy Dunlap
2007-05-10 18:19 ` Jeff Garzik [this message]
2007-05-11 10:58 ` Matvejchikov Ilya
2007-05-11 13:18 ` Kumar Gala
2007-05-11 13:49 ` Matvejchikov Ilya
2007-05-11 14:44 ` Kumar Gala
2007-05-14 19:32 ` Matvejchikov Ilya
2007-05-21 19:24 ` Andy Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46436215.7030503@garzik.org \
--to=jeff@garzik.org \
--cc=matvejchikov@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).