From: Patrick McHardy <kaber@trash.net>
To: David Miller <davem@davemloft.net>
Cc: taka@valinux.co.jp, linux-net@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] tbf scheduler: TSO support
Date: Fri, 11 May 2007 03:04:21 +0200 [thread overview]
Message-ID: <4643C115.3020802@trash.net> (raw)
In-Reply-To: <20070510.141344.127196214.davem@davemloft.net>
David Miller wrote:
> From: Patrick McHardy <kaber@trash.net>
> Date: Thu, 10 May 2007 14:56:39 +0200
>
>>I don't see why this is needed, the correct way to use TBF with TSO
>>is to specify a larger MTU value, in which case it won't drop TSO
>>packets.
>
>
> Why should a user have to know anything in the world about TSO in
> order to configure TBF properly? I don't think they should have
> to at all.
The user shouldn't necessarily, but userspace should.
The way I see it the MTU is a fundamental parameter for TBF
(the peakrate bucket size) and just because userspace picks
a bad default (2000) this is no reason to change the
implementation to something that is not really TBF anymore
and even affects non-TSO packets _and_ TSO packets even
when the MTU is chosen large enough (granted, the first
point is an implementation detail). The much better solution
would be to let userspace pick an appropriate default value
and still let the user override it.
next prev parent reply other threads:[~2007-05-11 1:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070510.210556.05145104.taka@valinux.co.jp>
2007-05-10 12:56 ` [PATCH] tbf scheduler: TSO support Patrick McHardy
2007-05-10 21:13 ` David Miller
2007-05-11 1:04 ` Patrick McHardy [this message]
2007-05-11 4:01 ` Hirokazu Takahashi
2007-05-11 18:13 ` Patrick McHardy
2007-05-12 8:49 ` Hirokazu Takahashi
2007-05-12 9:09 ` Hirokazu Takahashi
2007-05-13 12:42 ` [PATCH] tbf scheduler: TSO support (updated) Hirokazu Takahashi
2007-05-13 15:52 ` Stephen Hemminger
2007-05-13 16:21 ` Hirokazu Takahashi
2007-05-14 6:04 ` Herbert Xu
2007-05-15 11:39 ` [PATCH 1/2] tbf scheduler: TSO support (update 2) Hirokazu Takahashi
2007-05-15 11:41 ` [PATCH 2/2] " Hirokazu Takahashi
2007-05-17 13:55 ` Herbert Xu
2007-05-18 2:35 ` Hirokazu Takahashi
2007-05-23 11:47 ` [PATCH 1/2] tbf scheduler: TSO support (update 3) Hirokazu Takahashi
2007-05-23 11:49 ` [PATCH 2/2] " Hirokazu Takahashi
2007-05-10 16:00 [PATCH] tbf scheduler: TSO support Hirokazu Takahashi
2007-05-10 16:01 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4643C115.3020802@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=linux-net@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=taka@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).