* [PATCH] spidernet: remove unnecessary accesses to phy
@ 2007-05-10 17:18 Linas Vepstas
2007-05-11 20:56 ` Jeff Garzik
0 siblings, 1 reply; 6+ messages in thread
From: Linas Vepstas @ 2007-05-10 17:18 UTC (permalink / raw)
To: Jeff Garzik; +Cc: netdev, cbe-oss-dev, Ishizaki Kou
Jeff, please apply for 2.6.22; This is a purely janitorial patch.
(I will have additonal patches for the spidernet in a few days;
I'm still debugging a rather nasty hang.)
--linas
From: Ishizaki Kou <kou.ishizaki@toshiba.co.jp>
This patch removes unnecessary accesses to phy registers.
Signed-off-by: Kou Ishizaki <kou.ishizaki@toshiba.co.jp>
Signed-off-by: Linas Vepstas <linas@austin.ibm.com>
----
drivers/net/spider_net.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
Index: linux-2.6.21-rc7-mm2/drivers/net/spider_net.c
===================================================================
--- linux-2.6.21-rc7-mm2.orig/drivers/net/spider_net.c 2007-05-09 14:19:29.000000000 -0500
+++ linux-2.6.21-rc7-mm2/drivers/net/spider_net.c 2007-05-09 14:20:28.000000000 -0500
@@ -175,12 +175,10 @@ spider_net_setup_aneg(struct spider_net_
{
struct mii_phy *phy = &card->phy;
u32 advertise = 0;
- u16 bmcr, bmsr, stat1000, estat;
+ u16 bmsr, estat;
- bmcr = spider_net_read_phy(card->netdev, phy->mii_id, MII_BMCR);
- bmsr = spider_net_read_phy(card->netdev, phy->mii_id, MII_BMSR);
- stat1000 = spider_net_read_phy(card->netdev, phy->mii_id, MII_STAT1000);
- estat = spider_net_read_phy(card->netdev, phy->mii_id, MII_ESTATUS);
+ bmsr = spider_net_read_phy(card->netdev, phy->mii_id, MII_BMSR);
+ estat = spider_net_read_phy(card->netdev, phy->mii_id, MII_ESTATUS);
if (bmsr & BMSR_10HALF)
advertise |= ADVERTISED_10baseT_Half;
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] spidernet: remove unnecessary accesses to phy
2007-05-10 17:18 [PATCH] spidernet: remove unnecessary accesses to phy Linas Vepstas
@ 2007-05-11 20:56 ` Jeff Garzik
2007-05-12 0:23 ` Linas Vepstas
0 siblings, 1 reply; 6+ messages in thread
From: Jeff Garzik @ 2007-05-11 20:56 UTC (permalink / raw)
To: Linas Vepstas; +Cc: netdev, cbe-oss-dev, Ishizaki Kou
Linas Vepstas wrote:
>
> Jeff, please apply for 2.6.22; This is a purely janitorial patch.
>
> (I will have additonal patches for the spidernet in a few days;
> I'm still debugging a rather nasty hang.)
>
> --linas
>
>
> From: Ishizaki Kou <kou.ishizaki@toshiba.co.jp>
>
> This patch removes unnecessary accesses to phy registers.
>
> Signed-off-by: Kou Ishizaki <kou.ishizaki@toshiba.co.jp>
> Signed-off-by: Linas Vepstas <linas@austin.ibm.com>
>
> ----
> drivers/net/spider_net.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
applied. Please move comments that do not belong in the permanent
record BELOW the "---". See Documentation/SubmittingPatches for more info.
Jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] spidernet: remove unnecessary accesses to phy
2007-05-11 20:56 ` Jeff Garzik
@ 2007-05-12 0:23 ` Linas Vepstas
2007-05-12 0:36 ` Jeff Garzik
0 siblings, 1 reply; 6+ messages in thread
From: Linas Vepstas @ 2007-05-12 0:23 UTC (permalink / raw)
To: Jeff Garzik; +Cc: netdev, cbe-oss-dev, Ishizaki Kou
On Fri, May 11, 2007 at 04:56:28PM -0400, Jeff Garzik wrote:
>
> applied.
Thanks.
> Please move comments that do not belong in the permanent
> record BELOW the "---". See Documentation/SubmittingPatches for more info.
oops, sorry.
--linas
I've also got a multi-month old s2io patch that's in limbo. It was
ack'ed by an s2io maintainer, but otherwise fell through the cracks.
If you can find it and apply it, great, otherwise I'll resubmit
"real soon now".
--linas
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] spidernet: remove unnecessary accesses to phy
2007-05-12 0:23 ` Linas Vepstas
@ 2007-05-12 0:36 ` Jeff Garzik
2007-05-12 1:13 ` Linas Vepstas
0 siblings, 1 reply; 6+ messages in thread
From: Jeff Garzik @ 2007-05-12 0:36 UTC (permalink / raw)
To: Linas Vepstas; +Cc: netdev, cbe-oss-dev, Ishizaki Kou
Linas Vepstas wrote:
> On Fri, May 11, 2007 at 04:56:28PM -0400, Jeff Garzik wrote:
>> applied.
>
> Thanks.
>
>> Please move comments that do not belong in the permanent
>> record BELOW the "---". See Documentation/SubmittingPatches for more info.
>
> oops, sorry.
>
> --linas
>
> I've also got a multi-month old s2io patch that's in limbo. It was
> ack'ed by an s2io maintainer, but otherwise fell through the cracks.
> If you can find it and apply it, great, otherwise I'll resubmit
> "real soon now".
If you don't hear about a patch in over 14 days, you may assume I've
deleted it from my mbox queue.
Jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] spidernet: remove unnecessary accesses to phy
2007-05-12 0:36 ` Jeff Garzik
@ 2007-05-12 1:13 ` Linas Vepstas
0 siblings, 0 replies; 6+ messages in thread
From: Linas Vepstas @ 2007-05-12 1:13 UTC (permalink / raw)
To: Jeff Garzik; +Cc: netdev, cbe-oss-dev, Ishizaki Kou
On Fri, May 11, 2007 at 08:36:52PM -0400, Jeff Garzik wrote:
> Linas Vepstas wrote:
> >
> >I've also got a multi-month old s2io patch that's in limbo. It was
> >ack'ed by an s2io maintainer, but otherwise fell through the cracks.
> >If you can find it and apply it, great, otherwise I'll resubmit
> >"real soon now".
>
> If you don't hear about a patch in over 14 days, you may assume I've
> deleted it from my mbox queue.
Next week then. yow! I don't have enough disk space for all this stuff...
--linas
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] spidernet: remove unnecessary accesses to phy
@ 2007-05-09 7:30 Ishizaki Kou
0 siblings, 0 replies; 6+ messages in thread
From: Ishizaki Kou @ 2007-05-09 7:30 UTC (permalink / raw)
To: linas; +Cc: netdev, cbe-oss-dev
This patch removes unnecessary accesses to phy registers.
Signed-off-by: Kou Ishizaki <kou.ishizaki@toshiba.co.jp>
---
Index: linux-powerpc-git/drivers/net/spider_net.c
diff -u linux-powerpc-git/drivers/net/spider_net.c:1.1.1.9 linux-powerpc-git/drivers/net/spider_net.c:1.14
--- linux-powerpc-git/drivers/net/spider_net.c:1.1.1.9 Tue May 8 09:41:28 2007
+++ linux-powerpc-git/drivers/net/spider_net.c Tue May 8 10:16:59 2007
@@ -175,12 +175,10 @@
{
struct mii_phy *phy = &card->phy;
u32 advertise = 0;
- u16 bmcr, bmsr, stat1000, estat;
+ u16 bmsr, estat;
- bmcr = spider_net_read_phy(card->netdev, phy->mii_id, MII_BMCR);
- bmsr = spider_net_read_phy(card->netdev, phy->mii_id, MII_BMSR);
- stat1000 = spider_net_read_phy(card->netdev, phy->mii_id, MII_STAT1000);
- estat = spider_net_read_phy(card->netdev, phy->mii_id, MII_ESTATUS);
+ bmsr = spider_net_read_phy(card->netdev, phy->mii_id, MII_BMSR);
+ estat = spider_net_read_phy(card->netdev, phy->mii_id, MII_ESTATUS);
if (bmsr & BMSR_10HALF)
advertise |= ADVERTISED_10baseT_Half;
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-05-12 1:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-10 17:18 [PATCH] spidernet: remove unnecessary accesses to phy Linas Vepstas
2007-05-11 20:56 ` Jeff Garzik
2007-05-12 0:23 ` Linas Vepstas
2007-05-12 0:36 ` Jeff Garzik
2007-05-12 1:13 ` Linas Vepstas
-- strict thread matches above, loose matches on Subject: below --
2007-05-09 7:30 Ishizaki Kou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).