netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch/resend] smc911x: fix compilation breakage
@ 2007-05-13 14:42 Vitaly Wool
  2007-05-15 21:45 ` Jeff Garzik
  0 siblings, 1 reply; 2+ messages in thread
From: Vitaly Wool @ 2007-05-13 14:42 UTC (permalink / raw)
  To: jgarzik; +Cc: netdev, rmk

Looks like the new version of this patch has been overlooked,
so I'm resending it.

It just adapts the driver to the new IRQ API
according to what Russell has pointed out.

 drivers/net/smc911x.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

Signed-off-by: Vitaly Wool <vitalywool@gmail.com>

diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c
index c956141..4b9bdad 100644
--- a/drivers/net/smc911x.c
+++ b/drivers/net/smc911x.c
@@ -77,7 +77,6 @@ static const char version[] =
 #include <linux/skbuff.h>
 
 #include <asm/io.h>
-#include <asm/irq.h>
 
 #include "smc911x.h"
 
@@ -2086,12 +2085,11 @@ static int __init smc911x_probe(struct n
 	lp->ctl_rspeed = 100;
 
 	/* Grab the IRQ */
-	retval = request_irq(dev->irq, &smc911x_interrupt, IRQF_SHARED, dev->name, dev);
+	retval = request_irq(dev->irq, &smc911x_interrupt,
+			IRQF_SHARED | IRQF_TRIGGER_FALLING, dev->name, dev);
 	if (retval)
 		goto err_out;
 
-	set_irq_type(dev->irq, IRQT_FALLING);
-
 #ifdef SMC_USE_DMA
 	lp->rxdma = SMC_DMA_REQUEST(dev, smc911x_rx_dma_irq);
 	lp->txdma = SMC_DMA_REQUEST(dev, smc911x_tx_dma_irq);



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [patch/resend] smc911x: fix compilation breakage
  2007-05-13 14:42 [patch/resend] smc911x: fix compilation breakage Vitaly Wool
@ 2007-05-15 21:45 ` Jeff Garzik
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-05-15 21:45 UTC (permalink / raw)
  To: Vitaly Wool; +Cc: netdev, rmk

Vitaly Wool wrote:
> Looks like the new version of this patch has been overlooked,
> so I'm resending it.
> 
> It just adapts the driver to the new IRQ API
> according to what Russell has pointed out.
> 
> drivers/net/smc911x.c |    6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
> 
> Signed-off-by: Vitaly Wool <vitalywool@gmail.com>

applied to #upstream-fixes



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-05-15 21:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-13 14:42 [patch/resend] smc911x: fix compilation breakage Vitaly Wool
2007-05-15 21:45 ` Jeff Garzik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).