From mboxrd@z Thu Jan  1 00:00:00 1970
From: Patrick McHardy <kaber@trash.net>
Subject: Re: [LAST CALL] [PATCH] [NET_SCHED]make qdisc_restart more readable
Date: Mon, 14 May 2007 14:43:13 +0200
Message-ID: <46485961.7090509@trash.net>
References: <D5C1322C3E673F459512FB59E0DDC32902D42586@orsmsx414.amr.corp.intel.com>	 <1178911773.4126.26.camel@localhost> <1178972280.4061.7.camel@localhost>	 <4645F325.3060607@trash.net>  <1178999773.15622.44.camel@localhost>	 <1179066518.15622.60.camel@localhost>  <46483C8C.5040403@trash.net> <1179146498.15622.66.camel@localhost>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Cc: David Miller <davem@davemloft.net>,
	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>,
	Thomas Graf <tgraf@suug.ch>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	netdev@vger.kernel.org
To: hadi@cyberus.ca
Return-path: <netdev-owner@vger.kernel.org>
Received: from stinky.trash.net ([213.144.137.162]:37591 "EHLO
	stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752203AbXENMnS (ORCPT
	<rfc822;netdev@vger.kernel.org>); Mon, 14 May 2007 08:43:18 -0400
In-Reply-To: <1179146498.15622.66.camel@localhost>
Sender: netdev-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

jamal wrote:
> On Mon, 2007-14-05 at 12:40 +0200, Patrick McHardy wrote:

>>>+	if (unlikely (ret != NETDEV_TX_BUSY && net_ratelimit()))
>>>+		printk(KERN_DEBUG " BUG %s code %d qlen %d\n",dev->name, ret, q->q.qlen);

>
> What whitespace issue?

Space between unlikely and '(', missing space after ',' and dev->name.

>>and line length for the second printk if you're
>>going to change this :)
> 
> 
> I will fix the length of the second one.

Thanks.