From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [IPV4] LVS: Allow to send ICMP unreachable responses when real-servers are removed Date: Mon, 14 May 2007 16:32:02 +0200 Message-ID: <464872E2.2030502@trash.net> References: <200704271705.l3RH5Brw026873@hera.kernel.org> <4648382E.8030009@trash.net> <20070514.033504.48528120.davem@davemloft.net> <4648714E.9050200@tis.icnet.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: David Miller , horms@verge.net.au, netdev@vger.kernel.org To: Janusz Krzysztofik Return-path: Received: from stinky.trash.net ([213.144.137.162]:40177 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756306AbXENOcH (ORCPT ); Mon, 14 May 2007 10:32:07 -0400 In-Reply-To: <4648714E.9050200@tis.icnet.pl> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Janusz Krzysztofik wrote: > David Miller wrote: > >>> BTW, there doesn't even seem to be a spot where IPVS calls >>> ip_route_output with the source address set. What exactly is this >>> needed for? >> >> >> I suppose he has a patch to make use of it, but was waiting >> for this route.c change to go in first. > > > If you mean me, the answer is no, I do not have any patch making use of > the change in question. What I have is rather a complicated method of > notifying udp clients on communication problems before they are > redirected to a new real server. My method needs some IPVS related > patches, but ICMP port unreachable messages are not generated inside > IPVS code, they are just sent, with help of the patch in question, from > udp_input() or netfilter REJECT. Both use icmp_send(), which should always pick a local source, so I don't understand why this change was needed. Could you describe the specific case when the packet generated by icmp_send() does not have a local source?