From: Jeff Garzik <jeff@garzik.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: auke-jan.h.kok@intel.com, e1000-devel@lists.sourceforge.net,
netdev@vger.kernel.org, jesse.brandeburg@intel.com,
john.ronciak@intel.com, jeffrey.t.kirsher@intel.com
Subject: Re: [PATCH] [e1000] Lower the MSI unavailable message to INFO priority
Date: Tue, 15 May 2007 20:32:44 -0400 [thread overview]
Message-ID: <464A512C.9080104@garzik.org> (raw)
In-Reply-To: <200705152359.l4FNxPcS018779@tazenda.hos.anvin.org>
H. Peter Anvin wrote:
> diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
> index 637ae8f..089ae3f 100644
> --- a/drivers/net/e1000/e1000_main.c
> +++ b/drivers/net/e1000/e1000_main.c
> @@ -307,7 +307,7 @@ static int e1000_request_irq(struct e1000_adapter *adapter)
> if (adapter->hw.mac_type >= e1000_82571) {
> adapter->have_msi = TRUE;
> if ((err = pci_enable_msi(adapter->pdev))) {
> - DPRINTK(PROBE, ERR,
> + DPRINTK(PROBE, INFO,
> "Unable to allocate MSI interrupt Error: %d\n", err);
> adapter->have_msi = FALSE;
Actually, it should not print any message at all.
pci_enable_msi() failure is a normal event (as you point out). Even at
KERN_INFO level, the message is still misleading.
Jeff
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
next prev parent reply other threads:[~2007-05-16 0:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-15 23:56 [PATCH] [e1000] Lower the MSI unavailable message to INFO priority H. Peter Anvin
2007-05-16 0:32 ` Jeff Garzik [this message]
2007-05-16 15:26 ` Kok, Auke
2007-05-17 21:15 ` Chuck Ebbert
2007-05-17 21:29 ` Kok, Auke
2007-05-17 21:45 ` Jeff Garzik
2007-05-17 22:13 ` Kok, Auke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=464A512C.9080104@garzik.org \
--to=jeff@garzik.org \
--cc=auke-jan.h.kok@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=hpa@zytor.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).