From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] [e1000] Lower the MSI unavailable message to INFO priority Date: Tue, 15 May 2007 20:32:44 -0400 Message-ID: <464A512C.9080104@garzik.org> References: <200705152359.l4FNxPcS018779@tazenda.hos.anvin.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: auke-jan.h.kok@intel.com, e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org, jesse.brandeburg@intel.com, john.ronciak@intel.com, jeffrey.t.kirsher@intel.com To: "H. Peter Anvin" Return-path: In-Reply-To: <200705152359.l4FNxPcS018779@tazenda.hos.anvin.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: e1000-devel-bounces@lists.sourceforge.net Errors-To: e1000-devel-bounces@lists.sourceforge.net List-Id: netdev.vger.kernel.org H. Peter Anvin wrote: > diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c > index 637ae8f..089ae3f 100644 > --- a/drivers/net/e1000/e1000_main.c > +++ b/drivers/net/e1000/e1000_main.c > @@ -307,7 +307,7 @@ static int e1000_request_irq(struct e1000_adapter *adapter) > if (adapter->hw.mac_type >= e1000_82571) { > adapter->have_msi = TRUE; > if ((err = pci_enable_msi(adapter->pdev))) { > - DPRINTK(PROBE, ERR, > + DPRINTK(PROBE, INFO, > "Unable to allocate MSI interrupt Error: %d\n", err); > adapter->have_msi = FALSE; Actually, it should not print any message at all. pci_enable_msi() failure is a normal event (as you point out). Even at KERN_INFO level, the message is still misleading. Jeff ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/