From: Jeff Garzik <jeff@garzik.org>
To: Auke Kok <auke-jan.h.kok@intel.com>
Cc: netdev@vger.kernel.org, e1000-devel@lists.sourceforge.net, hpa@zytor.com
Subject: Re: [PATCH] e1000: Fix msi enable leak on error, don't print error message, cleanup
Date: Wed, 16 May 2007 11:32:54 -0400 [thread overview]
Message-ID: <464B2426.9060502@garzik.org> (raw)
In-Reply-To: <20070516083120.23311.3272.stgit@localhost.localdomain>
Auke Kok wrote:
> pci_enable_msi failure is a normal event so we should not print any error.
> Going over the code I spotted a missing pci_disable_msi() leak when irq
> allocation fails. The whole code also needed a cleanup, so I combined the
> two different calls to pci_request_irq into a single call making this
> look a lot better.
>
> Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
> Cc: H. Peter Anvin <hpa@zytor.com>
Looks OK, but compounds (and highlights) another problem: you shouldn't
be adding CONFIG_PCI_MSI ifdefs to the code. MSI support is properly
set up in the headers to enable working code even if CONFIG_PCI_MSI is
disabled.
Revise your patch to remove CONFIG_PCI_MSI tests, and I'll include it
straightaway.
Jeff
next prev parent reply other threads:[~2007-05-16 15:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-16 8:31 [PATCH] e1000: Fix msi enable leak on error, don't print error message, cleanup Auke Kok
2007-05-16 15:32 ` Jeff Garzik [this message]
2007-05-16 15:35 ` Kok, Auke
2007-05-16 18:41 ` Rick Jones
2007-05-16 19:05 ` H. Peter Anvin
2007-05-16 19:10 ` Rick Jones
2007-05-16 19:16 ` Jeff Garzik
2007-05-16 19:57 ` Rick Jones
2007-05-16 22:00 ` Jeff Garzik
2007-05-16 19:09 ` Jeff Garzik
2007-05-16 19:27 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2007-05-16 8:49 Auke Kok
2007-05-18 0:46 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=464B2426.9060502@garzik.org \
--to=jeff@garzik.org \
--cc=auke-jan.h.kok@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=hpa@zytor.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).