From: "H. Peter Anvin" <hpa@zytor.com>
To: Rick Jones <rick.jones2@hp.com>
Cc: Jeff Garzik <jeff@garzik.org>,
Auke Kok <auke-jan.h.kok@intel.com>,
netdev@vger.kernel.org, e1000-devel@lists.sourceforge.net
Subject: Re: [PATCH] e1000: Fix msi enable leak on error, don't print error message, cleanup
Date: Wed, 16 May 2007 12:05:05 -0700 [thread overview]
Message-ID: <464B55E1.8040501@zytor.com> (raw)
In-Reply-To: <464B504B.5090007@hp.com>
Rick Jones wrote:
> Some more of my paranoid questions :)
>
> So, if a driver tries to enable MSI and that is unsuccessful (I'll try
> to avoid using the possibly loaded term "fails") shouldn't that show-up
> _somewhere_?
It already does -- in /proc/interrupts.
> Just how "normal" is an attempt to enable MSI not succeding
> going to remain over time and aren't there times when it does indeed
> mean that someone should be looking into it?
If we ever want a message, that should go in the general code and not in
each driver.
-hpa
next prev parent reply other threads:[~2007-05-16 19:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-16 8:31 [PATCH] e1000: Fix msi enable leak on error, don't print error message, cleanup Auke Kok
2007-05-16 15:32 ` Jeff Garzik
2007-05-16 15:35 ` Kok, Auke
2007-05-16 18:41 ` Rick Jones
2007-05-16 19:05 ` H. Peter Anvin [this message]
2007-05-16 19:10 ` Rick Jones
2007-05-16 19:16 ` Jeff Garzik
2007-05-16 19:57 ` Rick Jones
2007-05-16 22:00 ` Jeff Garzik
2007-05-16 19:09 ` Jeff Garzik
2007-05-16 19:27 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2007-05-16 8:49 Auke Kok
2007-05-18 0:46 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=464B55E1.8040501@zytor.com \
--to=hpa@zytor.com \
--cc=auke-jan.h.kok@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=rick.jones2@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).