* [PATCH] sky2: re-enable 88E8056 for most motherboards
@ 2007-04-30 21:23 Stephen Hemminger
2007-05-01 13:58 ` Daniel Drake
2007-05-08 5:23 ` Jeff Garzik
0 siblings, 2 replies; 12+ messages in thread
From: Stephen Hemminger @ 2007-04-30 21:23 UTC (permalink / raw)
To: Jeff Garzik; +Cc: netdev, stable, Francois SIMOND
This fixes the regression in 2.6.21 for users with 88e8056 on motherboard.
Allow all but the Gigabyte motherboard has some unresolved bus problems.
Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
---
drivers/net/sky2.c | 17 +++++++++++++----
1 file changed, 13 insertions(+), 4 deletions(-)
--- sky2-2.6.21.orig/drivers/net/sky2.c 2007-04-27 13:37:32.000000000 -0700
+++ sky2-2.6.21/drivers/net/sky2.c 2007-04-30 14:01:15.000000000 -0700
@@ -123,10 +123,7 @@ static const struct pci_device_id sky2_i
{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4361) }, /* 88E8050 */
{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4362) }, /* 88E8053 */
{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4363) }, /* 88E8055 */
-#ifdef broken
- /* This device causes data corruption problems that are not resolved */
{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4364) }, /* 88E8056 */
-#endif
{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4366) }, /* 88EC036 */
{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4367) }, /* 88EC032 */
{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4368) }, /* 88EC034 */
@@ -3580,10 +3577,21 @@ static int __devinit sky2_probe(struct p
goto err_out;
}
+ /* Some Gigabyte motherboards have 88e8056 but cause problems
+ * There is some unresolved hardware related problem that causes
+ * descriptor errors and receive data corruption.
+ */
+ if (pdev->vendor == PCI_VENDOR_ID_MARVELL &&
+ pdev->device == 0x4364 && pdev->subsystem_vendor == 0x1458) {
+ dev_err(&pdev->dev,
+ "88E8056 on Gigabyte motherboards not supported\n");
+ goto err_out_disable;
+ }
+
err = pci_request_regions(pdev, DRV_NAME);
if (err) {
dev_err(&pdev->dev, "cannot obtain PCI resources\n");
- goto err_out;
+ goto err_out_disable;
}
pci_set_master(pdev);
@@ -3720,6 +3728,7 @@ err_out_free_hw:
kfree(hw);
err_out_free_regions:
pci_release_regions(pdev);
+err_out_disable:
pci_disable_device(pdev);
err_out:
return err;
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] sky2: re-enable 88E8056 for most motherboards
2007-04-30 21:23 [PATCH] sky2: re-enable 88E8056 for most motherboards Stephen Hemminger
@ 2007-05-01 13:58 ` Daniel Drake
2007-05-02 22:42 ` Stephen Hemminger
2007-05-10 16:00 ` Stephen Hemminger
2007-05-08 5:23 ` Jeff Garzik
1 sibling, 2 replies; 12+ messages in thread
From: Daniel Drake @ 2007-05-01 13:58 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Jeff Garzik, netdev, stable, Francois SIMOND
Hi Stephen,
Stephen Hemminger wrote:
> This fixes the regression in 2.6.21 for users with 88e8056 on motherboard.
> Allow all but the Gigabyte motherboard has some unresolved bus problems.
> + /* Some Gigabyte motherboards have 88e8056 but cause problems
> + * There is some unresolved hardware related problem that causes
> + * descriptor errors and receive data corruption.
> + */
> + if (pdev->vendor == PCI_VENDOR_ID_MARVELL &&
> + pdev->device == 0x4364 && pdev->subsystem_vendor == 0x1458) {
> + dev_err(&pdev->dev,
> + "88E8056 on Gigabyte motherboards not supported\n");
Gentoo have reports of sky2 working fine on Gigabyte boards which have
88E8056 devices:
https://bugs.gentoo.org/show_bug.cgi?id=176219
Can the patch be refined further?
Specifically:
Gigabyte DQ6
03:00.0 0200: 11ab:4364 (rev 12)
Subsystem: 1458:e000
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B-
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort-
<MAbort- >SERR- <PERR-
Latency: 0, Cache Line Size: 32 bytes
Interrupt: pin A routed to IRQ 219
Region 0: Memory at f7000000 (64-bit, non-prefetchable) [size=16K]
Region 2: I/O ports at 7000 [size=256]
[virtual] Expansion ROM at 40000000 [disabled] [size=128K]
Capabilities: [48] Power Management version 3
Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA
PME(D0+,D1+,D2+,D3hot+,D3cold+)
Status: D0 PME-Enable- DSel=0 DScale=1 PME-
Capabilities: [50] Vital Product Data
Capabilities: [5c] Message Signalled Interrupts: 64bit+ Queue=0/0
Enable+
Address: 00000000fee0300c Data: 413a
Capabilities: [e0] Express Legacy Endpoint IRQ 0
Device: Supported: MaxPayload 128 bytes, PhantFunc 0,
ExtTag-
Device: Latency L0s unlimited, L1 unlimited
Device: AtnBtn- AtnInd- PwrInd-
Device: Errors: Correctable- Non-Fatal- Fatal- Unsupported-
Device: RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop-
Device: MaxPayload 128 bytes, MaxReadReq 512 bytes
Link: Supported Speed 2.5Gb/s, Width x1, ASPM L0s L1,
Port 0
Link: Latency L0s <256ns, L1 unlimited
Link: ASPM Disabled RCB 128 bytes CommClk- ExtSynch-
Link: Speed 2.5Gb/s, Width x1
Capabilities: [100] Advanced Error Reporting
00: ab 11 64 43 07 04 10 00 12 00 00 02 08 00 00 00
10: 04 00 00 f7 00 00 00 00 01 70 00 00 00 00 00 00
20: 00 00 00 00 00 00 00 00 00 00 00 00 58 14 00 e0
30: 00 00 00 00 48 00 00 00 00 00 00 00 0a 01 00 00
Gigabyte S3: sorry, no lspci dump available yet
Gigabyte DS3:
04:00.0 Ethernet controller [0200]: Marvell Technology Group Ltd. Unknown
device [11ab:4364] (rev 12)
Subsystem: Giga-byte Technology Unknown device [1458:e000]
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B-
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort-
<MAbort- >SERR- <PERR-
Latency: 0, Cache Line Size: 32 bytes
Interrupt: pin A routed to IRQ 16
Region 0: Memory at f8000000 (64-bit, non-prefetchable) [size=16K]
Region 2: I/O ports at 8000 [size=256]
[virtual] Expansion ROM at 40000000 [disabled] [size=128K]
Capabilities: [48] Power Management version 3
Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA
PME(D0+,D1+,D2+,D3hot+,D3cold+)
Status: D0 PME-Enable- DSel=0 DScale=1 PME-
Capabilities: [50] Vital Product Data
Capabilities: [5c] Message Signalled Interrupts: Mask- 64bit+
Queue=0/0
Enable-
Address: 0000000000000000 Data: 0000
Capabilities: [e0] Express Legacy Endpoint IRQ 0
Device: Supported: MaxPayload 128 bytes, PhantFunc 0,
ExtTag-
Device: Latency L0s unlimited, L1 unlimited
Device: AtnBtn- AtnInd- PwrInd-
Device: Errors: Correctable- Non-Fatal- Fatal- Unsupported-
Device: RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop-
Device: MaxPayload 128 bytes, MaxReadReq 512 bytes
Link: Supported Speed 2.5Gb/s, Width x1, ASPM L0s L1,
Port 0
Link: Latency L0s <256ns, L1 unlimited
Link: ASPM Disabled RCB 128 bytes CommClk- ExtSynch-
Link: Speed 2.5Gb/s, Width x1
Capabilities: [100] Advanced Error Reporting
00: ab 11 64 43 07 00 10 00 12 00 00 02 08 00 00 00
10: 04 00 00 f8 00 00 00 00 01 80 00 00 00 00 00 00
20: 00 00 00 00 00 00 00 00 00 00 00 00 58 14 00 e0
30: 00 00 00 00 48 00 00 00 00 00 00 00 0b 01 00 00
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] sky2: re-enable 88E8056 for most motherboards
2007-05-01 13:58 ` Daniel Drake
@ 2007-05-02 22:42 ` Stephen Hemminger
2007-05-03 19:23 ` Daniel Drake
2007-05-10 16:00 ` Stephen Hemminger
1 sibling, 1 reply; 12+ messages in thread
From: Stephen Hemminger @ 2007-05-02 22:42 UTC (permalink / raw)
To: Daniel Drake; +Cc: Jeff Garzik, netdev, stable, Francois SIMOND
On Tue, 01 May 2007 09:58:28 -0400
Daniel Drake <dsd@gentoo.org> wrote:
> Hi Stephen,
>
> Stephen Hemminger wrote:
> > This fixes the regression in 2.6.21 for users with 88e8056 on motherboard.
> > Allow all but the Gigabyte motherboard has some unresolved bus problems.
>
> > + /* Some Gigabyte motherboards have 88e8056 but cause problems
> > + * There is some unresolved hardware related problem that causes
> > + * descriptor errors and receive data corruption.
> > + */
> > + if (pdev->vendor == PCI_VENDOR_ID_MARVELL &&
> > + pdev->device == 0x4364 && pdev->subsystem_vendor == 0x1458) {
> > + dev_err(&pdev->dev,
> > + "88E8056 on Gigabyte motherboards not supported\n");
>
> Gentoo have reports of sky2 working fine on Gigabyte boards which have
> 88E8056 devices:
> https://bugs.gentoo.org/show_bug.cgi?id=176219
>
> Can the patch be refined further?
>
> Specifically:
>
> Gigabyte DQ6
> 03:00.0 0200: 11ab:4364 (rev 12)
> Subsystem: 1458:e000
> Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
> Stepping- SERR- FastB2B-
> Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
> <TAbort-
> <MAbort- >SERR- <PERR-
> Latency: 0, Cache Line Size: 32 bytes
> Interrupt: pin A routed to IRQ 219
> Region 0: Memory at f7000000 (64-bit, non-prefetchable) [size=16K]
> Region 2: I/O ports at 7000 [size=256]
> [virtual] Expansion ROM at 40000000 [disabled] [size=128K]
> Capabilities: [48] Power Management version 3
> Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA
> PME(D0+,D1+,D2+,D3hot+,D3cold+)
> Status: D0 PME-Enable- DSel=0 DScale=1 PME-
> Capabilities: [50] Vital Product Data
> Capabilities: [5c] Message Signalled Interrupts: 64bit+ Queue=0/0
> Enable+
> Address: 00000000fee0300c Data: 413a
> Capabilities: [e0] Express Legacy Endpoint IRQ 0
> Device: Supported: MaxPayload 128 bytes, PhantFunc 0,
> ExtTag-
> Device: Latency L0s unlimited, L1 unlimited
> Device: AtnBtn- AtnInd- PwrInd-
> Device: Errors: Correctable- Non-Fatal- Fatal- Unsupported-
> Device: RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop-
> Device: MaxPayload 128 bytes, MaxReadReq 512 bytes
> Link: Supported Speed 2.5Gb/s, Width x1, ASPM L0s L1,
> Port 0
> Link: Latency L0s <256ns, L1 unlimited
> Link: ASPM Disabled RCB 128 bytes CommClk- ExtSynch-
> Link: Speed 2.5Gb/s, Width x1
> Capabilities: [100] Advanced Error Reporting
> 00: ab 11 64 43 07 04 10 00 12 00 00 02 08 00 00 00
> 10: 04 00 00 f7 00 00 00 00 01 70 00 00 00 00 00 00
> 20: 00 00 00 00 00 00 00 00 00 00 00 00 58 14 00 e0
> 30: 00 00 00 00 48 00 00 00 00 00 00 00 0a 01 00 00
>
>
> Gigabyte S3: sorry, no lspci dump available yet
>
> Gigabyte DS3:
> 04:00.0 Ethernet controller [0200]: Marvell Technology Group Ltd. Unknown
> device [11ab:4364] (rev 12)
> Subsystem: Giga-byte Technology Unknown device [1458:e000]
> Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
> Stepping- SERR- FastB2B-
> Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
> <TAbort-
> <MAbort- >SERR- <PERR-
> Latency: 0, Cache Line Size: 32 bytes
> Interrupt: pin A routed to IRQ 16
> Region 0: Memory at f8000000 (64-bit, non-prefetchable) [size=16K]
> Region 2: I/O ports at 8000 [size=256]
> [virtual] Expansion ROM at 40000000 [disabled] [size=128K]
> Capabilities: [48] Power Management version 3
> Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA
> PME(D0+,D1+,D2+,D3hot+,D3cold+)
> Status: D0 PME-Enable- DSel=0 DScale=1 PME-
> Capabilities: [50] Vital Product Data
> Capabilities: [5c] Message Signalled Interrupts: Mask- 64bit+
> Queue=0/0
> Enable-
> Address: 0000000000000000 Data: 0000
> Capabilities: [e0] Express Legacy Endpoint IRQ 0
> Device: Supported: MaxPayload 128 bytes, PhantFunc 0,
> ExtTag-
> Device: Latency L0s unlimited, L1 unlimited
> Device: AtnBtn- AtnInd- PwrInd-
> Device: Errors: Correctable- Non-Fatal- Fatal- Unsupported-
> Device: RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop-
> Device: MaxPayload 128 bytes, MaxReadReq 512 bytes
> Link: Supported Speed 2.5Gb/s, Width x1, ASPM L0s L1,
> Port 0
> Link: Latency L0s <256ns, L1 unlimited
> Link: ASPM Disabled RCB 128 bytes CommClk- ExtSynch-
> Link: Speed 2.5Gb/s, Width x1
> Capabilities: [100] Advanced Error Reporting
> 00: ab 11 64 43 07 00 10 00 12 00 00 02 08 00 00 00
> 10: 04 00 00 f8 00 00 00 00 01 80 00 00 00 00 00 00
> 20: 00 00 00 00 00 00 00 00 00 00 00 00 58 14 00 e0
> 30: 00 00 00 00 48 00 00 00 00 00 00 00 0b 01 00 00
The PCI info is basically the same between working/non working
Gigabyte boards. Is there any other difference? Kernel config?
chip revision?
--
Stephen Hemminger <shemminger@linux-foundation.org>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] sky2: re-enable 88E8056 for most motherboards
2007-05-02 22:42 ` Stephen Hemminger
@ 2007-05-03 19:23 ` Daniel Drake
0 siblings, 0 replies; 12+ messages in thread
From: Daniel Drake @ 2007-05-03 19:23 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Jeff Garzik, netdev, stable, Francois SIMOND
Stephen Hemminger wrote:
> The PCI info is basically the same between working/non working
> Gigabyte boards. Is there any other difference? Kernel config?
> chip revision?
I've never seen any reports of the corruption which you describe, so I
can't make the comparison myself. Here's the chip info from a working
Gigabyte DS3:
sky2 0000:04:00.0: v1.14 addr 0xf8000000 irq 16 Yukon-EC Ultra (0xb4) rev 2
Daniel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] sky2: re-enable 88E8056 for most motherboards
2007-05-01 13:58 ` Daniel Drake
2007-05-02 22:42 ` Stephen Hemminger
@ 2007-05-10 16:00 ` Stephen Hemminger
2007-05-13 15:55 ` Daniel Drake
1 sibling, 1 reply; 12+ messages in thread
From: Stephen Hemminger @ 2007-05-10 16:00 UTC (permalink / raw)
To: Daniel Drake; +Cc: Jeff Garzik, netdev, stable, Francois SIMOND
On Tue, 01 May 2007 09:58:28 -0400
Daniel Drake <dsd@gentoo.org> wrote:
> Hi Stephen,
>
> Stephen Hemminger wrote:
> > This fixes the regression in 2.6.21 for users with 88e8056 on motherboard.
> > Allow all but the Gigabyte motherboard has some unresolved bus problems.
>
> > + /* Some Gigabyte motherboards have 88e8056 but cause problems
> > + * There is some unresolved hardware related problem that causes
> > + * descriptor errors and receive data corruption.
> > + */
> > + if (pdev->vendor == PCI_VENDOR_ID_MARVELL &&
> > + pdev->device == 0x4364 && pdev->subsystem_vendor == 0x1458) {
> > + dev_err(&pdev->dev,
> > + "88E8056 on Gigabyte motherboards not supported\n");
>
> Gentoo have reports of sky2 working fine on Gigabyte boards which have
> 88E8056 devices:
> https://bugs.gentoo.org/show_bug.cgi?id=176219
>
> Can the patch be refined further?
I can use DMI to narrow down to one motherboard.
Or just let everything through and let user's discover what's unstable, it fails
relatively quickly.
Could you please get full PCI info lspci -vvxxx for working/non-working 88e8056 (Yukon EC-U)
systems? It might be some PCI Express setup by the BIOS, but so far haven't
found any difference that mattered.
Have tried newer BIOS and qualified memory as obvious first steps.
--
Stephen Hemminger <shemminger@linux-foundation.org>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] sky2: re-enable 88E8056 for most motherboards
2007-05-10 16:00 ` Stephen Hemminger
@ 2007-05-13 15:55 ` Daniel Drake
2007-05-14 19:02 ` Stephen Hemminger
0 siblings, 1 reply; 12+ messages in thread
From: Daniel Drake @ 2007-05-13 15:55 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Jeff Garzik, netdev, stable, Francois SIMOND
Stephen Hemminger wrote:
> I can use DMI to narrow down to one motherboard.
> Or just let everything through and let user's discover what's unstable, it fails
> relatively quickly.
>
> Could you please get full PCI info lspci -vvxxx for working/non-working 88e8056 (Yukon EC-U)
> systems? It might be some PCI Express setup by the BIOS, but so far haven't
> found any difference that mattered.
I haven't seen any reports of systems affected by the corruption issue
so I can't provide any data there.
Here is the full lspci output for a few systems with 88E8056 devices
that work fine:
Gigabyte P965-S3
http://bugs.gentoo.org/attachment.cgi?id=118827&action=view
Gigabyte P965-S3 (from another user)
http://bugs.gentoo.org/attachment.cgi?id=118848&action=view
Asus P5B deluxe
http://bugs.gentoo.org/attachment.cgi?id=119038&action=view
Daniel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] sky2: re-enable 88E8056 for most motherboards
2007-05-13 15:55 ` Daniel Drake
@ 2007-05-14 19:02 ` Stephen Hemminger
2007-05-17 2:09 ` Daniel Drake
0 siblings, 1 reply; 12+ messages in thread
From: Stephen Hemminger @ 2007-05-14 19:02 UTC (permalink / raw)
To: Daniel Drake; +Cc: Jeff Garzik, netdev, stable, Francois SIMOND
On Sun, 13 May 2007 11:55:29 -0400
Daniel Drake <dsd@gentoo.org> wrote:
> Stephen Hemminger wrote:
> > I can use DMI to narrow down to one motherboard.
> > Or just let everything through and let user's discover what's unstable, it fails
> > relatively quickly.
> >
> > Could you please get full PCI info lspci -vvxxx for working/non-working 88e8056 (Yukon EC-U)
> > systems? It might be some PCI Express setup by the BIOS, but so far haven't
> > found any difference that mattered.
>
> I haven't seen any reports of systems affected by the corruption issue
> so I can't provide any data there.
>
> Here is the full lspci output for a few systems with 88E8056 devices
> that work fine:
>
> Gigabyte P965-S3
> http://bugs.gentoo.org/attachment.cgi?id=118827&action=view
>
> Gigabyte P965-S3 (from another user)
> http://bugs.gentoo.org/attachment.cgi?id=118848&action=view
>
> Asus P5B deluxe
> http://bugs.gentoo.org/attachment.cgi?id=119038&action=view
>
>
> Daniel
It looks like these users aren't using MSI?
Also, there maybe some correlation of the problem with IDE AHCI mode.
I am using WD Raptor 10K driver with AHCI, that does Native Command Queuing,
could be some weird IDE interaction. If I turn off AHCI, it works better
(still fails but differently).
--
Stephen Hemminger <shemminger@linux-foundation.org>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] sky2: re-enable 88E8056 for most motherboards
2007-05-14 19:02 ` Stephen Hemminger
@ 2007-05-17 2:09 ` Daniel Drake
2007-05-17 2:58 ` Jeff Garzik
0 siblings, 1 reply; 12+ messages in thread
From: Daniel Drake @ 2007-05-17 2:09 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Jeff Garzik, netdev, stable, Francois SIMOND
Stephen Hemminger wrote:
> It looks like these users aren't using MSI?
Possible. Want me to find out?
I just ask as I note yesterday's -stable patch where you remove the
#ifdef completely. Is that going to go upstream into 2.6.22 or do you
want to continue pursuing the DMI matching path?
Thanks,
Daniel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] sky2: re-enable 88E8056 for most motherboards
2007-05-17 2:09 ` Daniel Drake
@ 2007-05-17 2:58 ` Jeff Garzik
2007-05-17 3:21 ` Daniel Drake
0 siblings, 1 reply; 12+ messages in thread
From: Jeff Garzik @ 2007-05-17 2:58 UTC (permalink / raw)
To: Daniel Drake; +Cc: Stephen Hemminger, netdev, stable, Francois SIMOND
Daniel Drake wrote:
> Stephen Hemminger wrote:
>> It looks like these users aren't using MSI?
>
> Possible. Want me to find out?
>
> I just ask as I note yesterday's -stable patch where you remove the
> #ifdef completely. Is that going to go upstream into 2.6.22 or do you
> want to continue pursuing the DMI matching path?
Stephen has some sky2 patches I need to push. I accidentally filed them
until 'Pending: SATA', and they got missed in my most recent net driver
push.
Jeff
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] sky2: re-enable 88E8056 for most motherboards
2007-05-17 2:58 ` Jeff Garzik
@ 2007-05-17 3:21 ` Daniel Drake
0 siblings, 0 replies; 12+ messages in thread
From: Daniel Drake @ 2007-05-17 3:21 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Stephen Hemminger, netdev, stable, Francois SIMOND
Jeff Garzik wrote:
> Stephen has some sky2 patches I need to push. I accidentally filed them
> until 'Pending: SATA', and they got missed in my most recent net driver
> push.
Thanks, that clears it up, forgot to check netdev before asking. Looks
like the 2.6.22 plans are to drop the machine detection, and enable
88E8056 everywhere.
Daniel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] sky2: re-enable 88E8056 for most motherboards
2007-04-30 21:23 [PATCH] sky2: re-enable 88E8056 for most motherboards Stephen Hemminger
2007-05-01 13:58 ` Daniel Drake
@ 2007-05-08 5:23 ` Jeff Garzik
1 sibling, 0 replies; 12+ messages in thread
From: Jeff Garzik @ 2007-05-08 5:23 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev, stable, Francois SIMOND
Stephen Hemminger wrote:
> This fixes the regression in 2.6.21 for users with 88e8056 on motherboard.
> Allow all but the Gigabyte motherboard has some unresolved bus problems.
>
> Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
>
> ---
> drivers/net/sky2.c | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
applied
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] sky2: re-enable 88E8056 for most motherboards
@ 2007-05-14 1:27 kernel
0 siblings, 0 replies; 12+ messages in thread
From: kernel @ 2007-05-14 1:27 UTC (permalink / raw)
To: netdev
RE: sky2 88e8056 Gigabyte GA-965GM-S2 uATX motherboard
Stephen Hemminger wrote:
>I can use DMI to narrow down to one motherboard.
>Or just let everything through and let user's discover what's unstable, it
>fails
>relatively quickly.
>
>Could you please get full PCI info lspci -vvxxx for working/non-working
>88e8056 (Yukon EC-U)
>systems? It might be some PCI Express setup by the BIOS, but so far haven't
>found any difference that mattered.
----------------------------------------
I have now too many of these Gigabyte mobos, GA-965GM-S2 with the Marvell 88e8056
www.gigabyte.com.tw / Products / Motherboard / Products_Overview.aspx?ProductID=2388
Observations.
-------------
The problem may not be sky2 specific. I have diskless nodes where too many can NOT
1) reliably DHCP an IP number from the server
2) and if the pxelinux.cfg/default loads, it is not certain if the kernel or the initrd would tftp transfer.
There are two of 12 diskless nodes that work, ... always work.
All mobos are the same, all CMOS is set identically
Please do not hesitate to ask for further observations on the functionality of the sky2 module.
--------------------------------
lspci is at the bottom of this post.
--------------------------------
Thank you, "Rob Ogden" <kernel (at) zeppo . hm . uc . edu>
Details
-------
0) All systems w/ Intel Core2duo/6600, 2GB-RAM
1) DHCP/PXE-boot/NFS server
Suse10.0 2.6.21 was 2.6.18
2) Diskless clients
Suse10.0 2.6.18 or 2.6.19 or 2.6.21
I believe that the 2.6.21 kernel is using a patched sky2 but I am not remembering how recent.
3) I have played with sky2 and with sk98lin from Marvell
There is no change in what works and does not work.
4) Netgear 24-port Gigabit unmanaged switch
The first 4 examples of this mobo worked w/o trouble on gigabit network.
These were the ones I used for setting the configuration.
As I took this configuration to waiting diskless clients, I began to experience the troubles, stopping after 9 failures out of 10.
On the bench there are 3 systems.
1) DHCP/BOOT/NFS server (no problems here)
2) Diskless node #1 (always works)
3) Diskless node #2 (will always fail at some point)
I can get much better but not reliable service from system #2 if I boot it with a Knoppix 5.1.1 CD 2.6.19 kernel.
Several times a 1GB file can "/usr/bin/scp" back and forth at 40MB/sec - going from RAM-DISK to RAM-DISK
But if I make it too busy, it will fail.
Failure comes sooner if I exercise an NFS-mount
Failure variously features -
"kernel panic"
"link down"
"Corrupted MAC on input"
"transmit descriptor error (hardware problem)"
AND an error from marvell's driver
> eth0: -- ERROR --
> Class: Hardware failure
> Nr: 0X26b
> Msg: Mac Transmit FIFO underrun
I have flashed the BIOS from F4 to F5 to F6(latest)
Perhaps not unexpectedly, BIOS F1 exacerbates the failure.
--------------------------------
How to get system #2 NOT to fail
--------------------------------
The system #2 will NOT fail if it boots and the ethernet is then using an installed PCI-card/RTL8169 chip.
The system #2 will NOT fail when connected to a 100mbit Linksys switch
The system #2 will NOT fail when connected to 1000mbit netgear AND running Win-XP (although throughput seems to drop below 7MB/sec)
Thank you for your help on this.
"Rob Ogden" <kernel (AT) zeppo . hm . uc . edu>
----------------------------------------
lspci information
----------------------------------------
1) DHCP/BOOT/NFS server
----------------------------------------
02:00.0 Class 0200: 11ab:4364 (rev 12)
Subsystem: 1458:e000
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Latency: 0, Cache Line Size 08
Interrupt: pin A routed to IRQ 220
Region 0: Memory at f1000000 (64-bit, non-prefetchable) [size=16K]
Region 2: I/O ports at 7000 [size=256]
[virtual] Expansion ROM at 80000000 [disabled] [size=128K]
Capabilities: [48] Power Management version 3
Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA PME(D0+,D1+,D2+,D3hot+,D3cold+)
Status: D0 PME-Enable- DSel=0 DScale=1 PME-
Capabilities: [50] Vital Product Data
Capabilities: [5c] Message Signalled Interrupts: 64bit+ Queue=0/0 Enable+
Address: 00000000fee0300c Data: 41e9
Capabilities: [e0] Express Legacy Endpoint IRQ 0
Device: Supported: MaxPayload 128 bytes, PhantFunc 0, ExtTag-
Device: Latency L0s unlimited, L1 unlimited
Device: AtnBtn- AtnInd- PwrInd-
Device: Errors: Correctable- Non-Fatal- Fatal- Unsupported-
Device: RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop-
Device: MaxPayload 128 bytes, MaxReadReq 512 bytes
Link: Supported Speed 2.5Gb/s, Width x1, ASPM L0s L1, Port 0
Link: Latency L0s <256ns, L1 unlimited
Link: ASPM Disabled RCB 128 bytes CommClk- ExtSynch-
Link: Speed 2.5Gb/s, Width x1
Capabilities: [100] Advanced Error Reporting
00: ab 11 64 43 07 04 10 00 12 00 00 02 08 00 00 00
10: 04 00 00 f1 00 00 00 00 01 70 00 00 00 00 00 00
20: 00 00 00 00 00 00 00 00 00 00 00 00 58 14 00 e0
30: 00 00 00 00 48 00 00 00 00 00 00 00 09 01 00 00
----------------------------------------
2) Diskless node #1 (always works)
----------------------------------------
02:00.0 Class 0200: 11ab:4364 (rev 12)
Subsystem: 1458:e000
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Latency: 0, Cache Line Size 08
Interrupt: pin A routed to IRQ 17
Region 0: Memory at f1000000 (64-bit, non-prefetchable) [size=16K]
Region 2: I/O ports at 8000 [size=256]
[virtual] Expansion ROM at 80000000 [disabled] [size=128K]
Capabilities: [48] Power Management version 3
Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA PME(D0+,D1+,D2+,D3hot+,D3cold+)
Status: D0 PME-Enable- DSel=0 DScale=1 PME-
Capabilities: [50] Vital Product Data
Capabilities: [5c] Message Signalled Interrupts: 64bit+ Queue=0/0 Enable-
Address: 0000000000000000 Data: 0000
Capabilities: [e0] Express Legacy Endpoint IRQ 0
Device: Supported: MaxPayload 128 bytes, PhantFunc 0, ExtTag-
Device: Latency L0s unlimited, L1 unlimited
Device: AtnBtn- AtnInd- PwrInd-
Device: Errors: Correctable- Non-Fatal- Fatal- Unsupported-
Device: RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop-
Device: MaxPayload 128 bytes, MaxReadReq 2048 bytes
Link: Supported Speed 2.5Gb/s, Width x1, ASPM L0s L1, Port 0
Link: Latency L0s <256ns, L1 unlimited
Link: ASPM Disabled RCB 128 bytes CommClk- ExtSynch-
Link: Speed 2.5Gb/s, Width x1
Capabilities: [100] Advanced Error Reporting
00: ab 11 64 43 07 00 10 00 12 00 00 02 08 00 00 00
10: 04 00 00 f1 00 00 00 00 01 80 00 00 00 00 00 00
20: 00 00 00 00 00 00 00 00 00 00 00 00 58 14 00 e0
30: 00 00 00 00 48 00 00 00 00 00 00 00 0c 01 00 00
----------------------------------------
3) Diskless node #2 (will always fail at some point)
----------------------------------------
02:00.0 Class 0200: 11ab:4364 (rev 12)
Subsystem: 1458:e000
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Latency: 0, Cache Line Size 08
Interrupt: pin A routed to IRQ 17
Region 0: Memory at f1000000 (64-bit, non-prefetchable) [size=16K]
Region 2: I/O ports at 8000 [size=256]
[virtual] Expansion ROM at 80000000 [disabled] [size=128K]
Capabilities: [48] Power Management version 3
Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA PME(D0+,D1+,D2+,D3hot+,D3cold+)
Status: D0 PME-Enable- DSel=0 DScale=1 PME-
Capabilities: [50] Vital Product Data
Capabilities: [5c] Message Signalled Interrupts: 64bit+ Queue=0/0 Enable-
Address: 0000000000000000 Data: 0000
Capabilities: [e0] Express Legacy Endpoint IRQ 0
Device: Supported: MaxPayload 128 bytes, PhantFunc 0, ExtTag-
Device: Latency L0s unlimited, L1 unlimited
Device: AtnBtn- AtnInd- PwrInd-
Device: Errors: Correctable- Non-Fatal- Fatal- Unsupported-
Device: RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop-
Device: MaxPayload 128 bytes, MaxReadReq 2048 bytes
Link: Supported Speed 2.5Gb/s, Width x1, ASPM L0s L1, Port 0
Link: Latency L0s <256ns, L1 unlimited
Link: ASPM Disabled RCB 128 bytes CommClk- ExtSynch-
Link: Speed 2.5Gb/s, Width x1
Capabilities: [100] Advanced Error Reporting
00: ab 11 64 43 07 00 10 00 12 00 00 02 08 00 00 00
10: 04 00 00 f1 00 00 00 00 01 80 00 00 00 00 00 00
20: 00 00 00 00 00 00 00 00 00 00 00 00 58 14 00 e0
30: 00 00 00 00 48 00 00 00 00 00 00 00 0c 01 00 00
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2007-05-17 3:22 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-30 21:23 [PATCH] sky2: re-enable 88E8056 for most motherboards Stephen Hemminger
2007-05-01 13:58 ` Daniel Drake
2007-05-02 22:42 ` Stephen Hemminger
2007-05-03 19:23 ` Daniel Drake
2007-05-10 16:00 ` Stephen Hemminger
2007-05-13 15:55 ` Daniel Drake
2007-05-14 19:02 ` Stephen Hemminger
2007-05-17 2:09 ` Daniel Drake
2007-05-17 2:58 ` Jeff Garzik
2007-05-17 3:21 ` Daniel Drake
2007-05-08 5:23 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2007-05-14 1:27 kernel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).