From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [IPV4] LVS: Allow to send ICMP unreachable responses when real-servers are removed Date: Thu, 17 May 2007 18:41:42 +0200 Message-ID: <464C85C6.1090903@trash.net> References: <200704271705.l3RH5Brw026873@hera.kernel.org> <4648382E.8030009@trash.net> <20070514.033504.48528120.davem@davemloft.net> <4648714E.9050200@tis.icnet.pl> <464872E2.2030502@trash.net> <464884EE.3030606@tis.icnet.pl> <46489F5C.4000801@trash.net> <20070515052608.GG13708@verge.net.au> <4649DBB7.3070608@trash.net> <464C3BC1.8090908@tis.icnet.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: Julian Anastasov , Simon Horman , David Miller , netdev@vger.kernel.org To: Janusz Krzysztofik Return-path: Received: from stinky.trash.net ([213.144.137.162]:33478 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755822AbXEQQmV (ORCPT ); Thu, 17 May 2007 12:42:21 -0400 In-Reply-To: <464C3BC1.8090908@tis.icnet.pl> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Janusz Krzysztofik wrote: > Julian Anastasov wrote: > >> If icmp_send is changed to use inet_addr_type() then ICMP will leave >> with saddr != VIP and that is not nice. >> ... >> >>> I'm not familiar with the IPVS terms, but as far as I understand, >>> it is _not_ going to return RTN_LOCAL, so we get the desired >>> behaviour of selecting a local address as source. >> >> >> But what is preferred is to use VIP in ICMP. >> >> ip route add local VIP dev lo table user_defined >> >> returns RTCF_LOCAL but inet_addr_type() does not return RTN_LOCAL, >> we fix one thing but break another :) > > > Well, I have promissed you to give some feedback after I test the patch > proposed by Patrick, but after Julian's post I can only confirm that it > works exactly as Julian said, what is not what I would expect. It will pick a local source address and use that. I don't see why it matters whether its the VIP address or some other.