From: Jeff Garzik <jeff@garzik.org>
To: Auke Kok <auke-jan.h.kok@intel.com>
Cc: netdev@vger.kernel.org, e1000-devel@lists.sourceforge.net,
jesse.brandeburg@intel.com, john.ronciak@intel.com,
jeffrey.t.kirsher@intel.com, cebbert@redhat.com, hpa@zytor.com
Subject: Re: [PATCH] ixgb: don't print error if pci_enable_msi() fails, cleanup minor leak
Date: Thu, 17 May 2007 20:46:18 -0400 [thread overview]
Message-ID: <464CF75A.8000600@garzik.org> (raw)
In-Reply-To: <20070517222906.25352.31886.stgit@localhost.localdomain>
Auke Kok wrote:
> From: Auke Kok <auke-jan.h.kok@intel.com>
>
> pci_enable_msi calls can fail for normal operational reasons. Driver
> should not print an error message in that case. Fix a leak that leaves
> msi enabled if pci_request_irq fails. We can remove CONFIG_PCI_MSI
> ifdefs alltogether
>
> Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
> ---
>
> drivers/net/ixgb/ixgb.h | 2 --
> drivers/net/ixgb/ixgb_main.c | 36 +++++++++++++++---------------------
> 2 files changed, 15 insertions(+), 23 deletions(-)
applied
prev parent reply other threads:[~2007-05-18 0:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-17 22:29 [PATCH] ixgb: don't print error if pci_enable_msi() fails, cleanup minor leak Auke Kok
2007-05-18 0:46 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=464CF75A.8000600@garzik.org \
--to=jeff@garzik.org \
--cc=auke-jan.h.kok@intel.com \
--cc=cebbert@redhat.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=hpa@zytor.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).