From: Jeff Garzik <jeff@garzik.org>
To: Auke Kok <auke-jan.h.kok@intel.com>
Cc: wenxiong@us.ibm.com, e1000-devel@lists.sourceforge.net,
netdev@vger.kernel.org
Subject: Re: [PATCH] e1000: Work around 82571 completion timout on Pseries HW
Date: Thu, 17 May 2007 20:47:00 -0400 [thread overview]
Message-ID: <464CF784.70608@garzik.org> (raw)
In-Reply-To: <20070516085329.29131.120.stgit@localhost.localdomain>
Auke Kok wrote:
> Our 82571 (first PCI-E hardware) causes P-Series hardware to throw
> issues. Disabling PCI-E completion timeouts in our NIC resolves
> the issue.
>
> Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
> Cc: Wen Xiong <wenxiong@us.ibm.com>
> ---
>
> drivers/net/e1000/e1000_main.c | 10 ++++++++++
> 1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
> index 49be393..830d851 100644
> --- a/drivers/net/e1000/e1000_main.c
> +++ b/drivers/net/e1000/e1000_main.c
> @@ -819,6 +819,16 @@ e1000_reset(struct e1000_adapter *adapter)
> E1000_WRITE_REG(&adapter->hw, CTRL, ctrl);
> }
>
> +#if defined(CONFIG_PPC64) || defined(CONFIG_PPC)
> +#define E1000_GCR_DISABLE_TIMEOUT_MECHANISM 0x80000000
> + if (adapter->hw.mac.type == e1000_82571) {
> + /* work around pSeries hardware by disabling timeouts */
> + u32 gcr = E1000_READ_REG(&adapter->hw, E1000_GCR);
> + gcr |= E1000_GCR_DISABLE_TIMEOUT_MECHANISM;
> + E1000_WRITE_REG(&adapter->hw, E1000_GCR, gcr);
> + }
> +#endif
not applied. based on the conversation, it sounds like this is not
specific to PPC
Jeff
prev parent reply other threads:[~2007-05-18 0:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-16 8:53 [PATCH] e1000: Work around 82571 completion timout on Pseries HW Auke Kok
2007-05-16 16:00 ` Jeff Garzik
2007-05-16 22:11 ` Wen Xiong
2007-05-16 22:31 ` Benjamin Herrenschmidt
2007-05-17 0:43 ` Kumar Gala
2007-05-17 9:01 ` Christoph Hellwig
2007-05-17 13:10 ` Kumar Gala
2007-05-17 14:58 ` Wen Xiong
2007-05-17 21:04 ` Jeff Garzik
2007-05-17 21:44 ` wendy xiong
2007-06-23 8:20 ` Christoph Hellwig
2007-06-23 17:05 ` Kok, Auke
2007-05-18 0:47 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=464CF784.70608@garzik.org \
--to=jeff@garzik.org \
--cc=auke-jan.h.kok@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=wenxiong@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).