From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 3/5] ucc_geth: eliminate max-speed, change interface-type to phy-connection-type Date: Thu, 17 May 2007 21:53:37 -0400 Message-ID: <464D0721.4030600@garzik.org> References: <20070511182507.7642926e.kim.phillips@freescale.com> <464A29EF.7080405@garzik.org> <20070515172629.61c1b4c2.kim.phillips@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Kim Phillips Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:44079 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755799AbXERBxj (ORCPT ); Thu, 17 May 2007 21:53:39 -0400 In-Reply-To: <20070515172629.61c1b4c2.kim.phillips@freescale.com> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Kim Phillips wrote: > On Tue, 15 May 2007 17:45:19 -0400 > Jeff Garzik wrote: > >> Kim Phillips wrote: >>> It was agreed that phy-connection-type was a better name for >>> the interface-type property, so this patch renames it. >>> >>> Also, the max-speed property name was determined too generic, >>> and is therefore eliminated in favour of phy-connection-type >>> derivation logic. >>> >>> includes corrections to copyright text. >>> >>> Signed-off-by: Kim Phillips >>> --- >>> drivers/net/ucc_geth.c | 40 ++++++++++++++++------------------------ >>> drivers/net/ucc_geth_mii.c | 9 +++++---- >>> drivers/net/ucc_geth_mii.h | 10 +++++----- >>> 3 files changed, 26 insertions(+), 33 deletions(-) >> applied to #upstream >> > just to be clear; only the mpc8323e-mds board works on your current #upstream-{fixes,linus}. > > The mpc8323e-rdb and mpc8360e-mds require > > phylib: add the ICPlus IP175C PHY driver > > and > > phylib: enable RGMII-ID on the Marvell m88e1111 PHY > > respectively in order to work. > > I'm ok with the SGMII patches: > > phylib: m88e1111: enable SGMII mode > gianfar: add support for SGMII > > staying on #upstream, but 2 out of 3 boards are currently broken for #upstream-{fixes,linus}. New hardware support is always "broken" until merged. Nonetheless it is still new and outside the merge window. Jeff