From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kok, Auke" Subject: Re: [PATCH] fix e100 rx path on ARM (was [PATCH] e100 rx: or s and el bits) Date: Fri, 18 May 2007 08:59:26 -0700 Message-ID: <464DCD5E.50003@intel.com> References: <200705011124.l41BOEG4007662@sullivan.realtime.net> <46375664.8030701@roinet.com> <4638F2B2.2000103@roinet.com> <463BA906.30205@roinet.com> <85f07fc58d5ed2147d5214d0f0b4fe32@bga.com> <4648A9DF.6030001@roinet.com> <464D074F.20400@pobox.com> <464D21B6.2000208@intel.com> <464DB336.2030003@roinet.com> <464DB619.3070900@roinet.com> <464DC676.90504@intel.com> <464DCA97.3070405@roinet.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Jeff Garzik , Milton Miller , e1000-devel@lists.sourceforge.net, Jeff Kirsher , John Ronciak , Jesse Brandeburg , Scott Feldman , netdev@vger.kernel.org To: David Acker Return-path: Received: from mga01.intel.com ([192.55.52.88]:12955 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752992AbXERP73 (ORCPT ); Fri, 18 May 2007 11:59:29 -0400 In-Reply-To: <464DCA97.3070405@roinet.com> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org David Acker wrote: > Kok, Auke wrote: >> David Acker wrote: >>> David Acker wrote: >>>> Done. Below is a patch against 2.6.22-rc1. It combines removing the >>>> s-bit patch and applying the patch I previously sent. >>> Oops. I missed one state in that patch. Since the el-bit buffer will >>> normally not complete due to a zero size, we need to check if the >>> buffer with no data has the el-bit set. Without this, you have to >>> wait for the interrupt. Sorry about that...this was in the code I >>> tested on my embedded system but got lost in the regular kernel patch. >> OK. Thanks. >> >> If you don't mind I'm going to have some testing on this patch done for >> a bit now (mostly x86 hardware of course) to see if there's no pitfalls >> in it. It'll be a few days because of the weekend before I get back on it. >> > > Cool. I will see if I can get some more tests running over the weekend on our PXA255 > platform. First impression just came in: It seems RX performance is dropped to 10mbit. TX is unaffected and runs at 94mbit/tcp, but RX the new code seems to misbehave and fluctuate, dropping below 10mbit after a few netperf runs and staying there... ideas? Auke