Netdev List
 help / color / mirror / Atom feed
From: Jia-Ju Bai <baijiaju1990@gmail.com>
To: steffen.klassert@secunet.com, herbert@gondor.apana.org.au,
	davem@davemloft.net
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [BUG] net: xfrm: possible null-pointer dereferences in xfrm_policy()
Date: Mon, 29 Jul 2019 11:43:49 +0800	[thread overview]
Message-ID: <464bb93d-75b2-c21b-ee32-25a10ff61622@gmail.com> (raw)

In xfrm_policy(), the while loop on lines 3802-3830 ends when dst->xfrm 
is NULL.
Then, dst->xfrm is used on line 3840:
     xfrm_state_mtu(dst->xfrm, mtu);
         if (x->km.state != XFRM_STATE_VALID...)
         aead = x->data;

Thus, possible null-pointer dereferences may occur.

These bugs are found by a static analysis tool STCheck written by us.

I do not know how to correctly fix these bugs, so I only report them.


Best wishes,
Jia-Ju Bai


             reply	other threads:[~2019-07-29  3:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-29  3:43 Jia-Ju Bai [this message]
2019-07-29  8:03 ` [BUG] net: xfrm: possible null-pointer dereferences in xfrm_policy() Steffen Klassert
2019-07-29  8:06   ` Jia-Ju Bai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=464bb93d-75b2-c21b-ee32-25a10ff61622@gmail.com \
    --to=baijiaju1990@gmail.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox