From: Patrick McHardy <kaber@trash.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: netdev@vger.kernel.org, jmorris@namei.org, Curtis@greenkey.net,
davem@davemloft.net
Subject: Re: oops in net/ipv4/icmp.c:icmp_send() with icmp_errors_use_inbound_ifaddr (fwd)
Date: Mon, 21 May 2007 23:32:44 +0200 [thread overview]
Message-ID: <46520FFC.5020804@trash.net> (raw)
In-Reply-To: <20070521212804.GB6234@gondor.apana.org.au>
Herbert Xu wrote:
> On Mon, May 21, 2007 at 06:36:57PM +0200, Patrick McHardy wrote:
>
>>The IP stack shouldn't be too hard, we currently set skb->dev in
>>ip_output, after that we only have the POST_ROUTING hook and ip_fragment
>>which care. It wouldn't help with ipip/ip_gre though, at that point
>>skb->dev must point to the tunnel device.
>
>
> I think that should be OK though. Once you pass through ipip/ip_gre's
> transmit function, you're conceptually a locally generated packet.
Yes, but it may generate ICMP errors for the original packet before
it has passed through it. The patch I sent earlier should also handle
this case correctly.
next prev parent reply other threads:[~2007-05-21 21:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-14 18:30 oops in net/ipv4/icmp.c:icmp_send() with icmp_errors_use_inbound_ifaddr (fwd) James Morris
2007-05-14 18:46 ` Patrick McHardy
2007-05-14 19:19 ` Patrick McHardy
2007-05-17 16:52 ` Patrick McHardy
2007-05-18 0:57 ` Julian Anastasov
2007-05-19 21:50 ` David Miller
2007-05-21 17:03 ` Patrick McHardy
2007-05-20 5:26 ` Herbert Xu
2007-05-21 16:36 ` Patrick McHardy
2007-05-21 21:28 ` Herbert Xu
2007-05-21 21:32 ` Patrick McHardy [this message]
2007-05-14 20:24 ` Curtis Doty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46520FFC.5020804@trash.net \
--to=kaber@trash.net \
--cc=Curtis@greenkey.net \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jmorris@namei.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).