* [PATCH] declance: Remove a dangling spin_unlock_irq() thingy
@ 2007-05-21 13:33 Maciej W. Rozycki
2007-05-21 23:42 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Maciej W. Rozycki @ 2007-05-21 13:33 UTC (permalink / raw)
To: Andrew Morton, Jeff Garzik; +Cc: netdev
The spin_unlock_irq() invocation in lance_start_xmit() has no matching
locking request. The call is already protected by netif_tx_lock, so
remove the statement.
Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
---
Please apply.
Maciej
patch-mips-2.6.18-20060920-declance-lock-0
diff -up --recursive --new-file linux-mips-2.6.18-20060920.macro/drivers/net/declance.c linux-mips-2.6.18-20060920/drivers/net/declance.c
--- linux-mips-2.6.18-20060920.macro/drivers/net/declance.c 2006-09-20 20:50:22.000000000 +0000
+++ linux-mips-2.6.18-20060920/drivers/net/declance.c 2007-05-19 21:14:36.000000000 +0000
@@ -915,8 +915,6 @@ static int lance_start_xmit(struct sk_bu
/* Kick the lance: transmit now */
writereg(&ll->rdp, LE_C0_INEA | LE_C0_TDMD);
- spin_unlock_irq(&lp->lock);
-
dev->trans_start = jiffies;
dev_kfree_skb(skb);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-05-21 23:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-21 13:33 [PATCH] declance: Remove a dangling spin_unlock_irq() thingy Maciej W. Rozycki
2007-05-21 23:42 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).