* [PATCH 3/4] forcedeth: fix cpu irq mask
@ 2007-05-22 0:23 Ayaz Abdulla
2007-05-24 22:03 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Ayaz Abdulla @ 2007-05-22 0:23 UTC (permalink / raw)
To: Jeff Garzik, Manfred Spraul, Andrew Morton, nedev
[-- Attachment #1: Type: text/plain, Size: 213 bytes --]
This patch fixes the cpu irq mask define to include the timer irq.
Another flag check was setting up the timer bit in all cases so we
didn't notice the issue.
Signed-off-by: Ayaz Abdulla <aabdulla@nvidia.com>
[-- Attachment #2: patch-forcedeth-cpumask --]
[-- Type: text/plain, Size: 611 bytes --]
--- old/drivers/net/forcedeth.c 2007-05-21 20:07:44.000000000 -0400
+++ new/drivers/net/forcedeth.c 2007-05-21 20:08:34.000000000 -0400
@@ -195,7 +195,7 @@
#define NVREG_IRQ_TX_FORCED 0x0100
#define NVREG_IRQ_RECOVER_ERROR 0x8000
#define NVREG_IRQMASK_THROUGHPUT 0x00df
-#define NVREG_IRQMASK_CPU 0x0040
+#define NVREG_IRQMASK_CPU 0x0060
#define NVREG_IRQ_TX_ALL (NVREG_IRQ_TX_ERR|NVREG_IRQ_TX_OK|NVREG_IRQ_TX_FORCED)
#define NVREG_IRQ_RX_ALL (NVREG_IRQ_RX_ERROR|NVREG_IRQ_RX|NVREG_IRQ_RX_NOBUF|NVREG_IRQ_RX_FORCED)
#define NVREG_IRQ_OTHER (NVREG_IRQ_TIMER|NVREG_IRQ_LINK|NVREG_IRQ_RECOVER_ERROR)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 3/4] forcedeth: fix cpu irq mask
2007-05-22 0:23 [PATCH 3/4] forcedeth: fix cpu irq mask Ayaz Abdulla
@ 2007-05-24 22:03 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-05-24 22:03 UTC (permalink / raw)
To: Ayaz Abdulla; +Cc: Manfred Spraul, Andrew Morton, nedev
Ayaz Abdulla wrote:
> This patch fixes the cpu irq mask define to include the timer irq.
> Another flag check was setting up the timer bit in all cases so we
> didn't notice the issue.
>
> Signed-off-by: Ayaz Abdulla <aabdulla@nvidia.com>
applied to #upstream-fixes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-05-24 22:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-22 0:23 [PATCH 3/4] forcedeth: fix cpu irq mask Ayaz Abdulla
2007-05-24 22:03 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).