From: Jeff Garzik <jgarzik@pobox.com>
To: Linas Vepstas <linas@austin.ibm.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-pci@atrey.karlin.mff.cuni.cz, netdev@vger.kernel.org,
Ramkrishna Vepa <Ramkrishna.Vepa@neterion.com>,
Sivakumar Subramani <sivakumar.subramani@neterion.com>,
Sreenivasa Honnur <sreenivasa.honnur@neterion.com>,
Rastapur Santosh <santosh.rastapur@neterion.com>,
Wen Xiong <wenxiong@us.ibm.com>
Subject: Re: [PATCH] s2io: don't run MSI handlers if device is offline.
Date: Thu, 24 May 2007 17:20:24 -0400 [thread overview]
Message-ID: <46560198.9080204@pobox.com> (raw)
In-Reply-To: <20070522225029.GS5921@austin.ibm.com>
Linas Vepstas wrote:
> Don't run any of the MSI handlers if the channel is off;
> also don't gather device statatistics. Also, netif_wake
> not needed, per suggestions from
> Sivakumar Subramani <sivakumar.subramani@neterion.com>.
>
> Signed-off-by: Linas Vepstas <linas@austin.ibm.com>
> Cc: Ramkrishna Vepa <Ramkrishna.Vepa@neterion.com>
> Cc: Sivakumar Subramani <sivakumar.subramani@neterion.com>
> Cc: Sreenivasa Honnur <sreenivasa.honnur@neterion.com>
> Cc: Rastapur Santosh <santosh.rastapur@neterion.com>
> Cc: Wen Xiong <wenxiong@us.ibm.com>
Why are the interrupt handlers being called at all, then?
This seems to be papering over another bug.
next prev parent reply other threads:[~2007-05-24 21:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-22 22:50 [PATCH] s2io: don't run MSI handlers if device is offline Linas Vepstas
2007-05-23 5:03 ` Sivakumar Subramani
2007-05-24 21:20 ` Jeff Garzik [this message]
2007-05-25 18:29 ` Linas Vepstas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46560198.9080204@pobox.com \
--to=jgarzik@pobox.com \
--cc=Ramkrishna.Vepa@neterion.com \
--cc=akpm@osdl.org \
--cc=linas@austin.ibm.com \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=netdev@vger.kernel.org \
--cc=santosh.rastapur@neterion.com \
--cc=sivakumar.subramani@neterion.com \
--cc=sreenivasa.honnur@neterion.com \
--cc=wenxiong@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).