From: Jeff Garzik <jeff@garzik.org>
To: Linas Vepstas <linas@austin.ibm.com>
Cc: Andrew Morton <akpm@osdl.org>,
cbe-oss-dev@ozlabs.org, netdev@vger.kernel.org,
linuxppc-dev@ozlabs.org, Florin Malita <fmalita@gmail.com>
Subject: Re: [PATCH 1/10] spidernet: skb used after netif_receive_skb
Date: Thu, 24 May 2007 17:25:56 -0400 [thread overview]
Message-ID: <465602E4.1050807@garzik.org> (raw)
In-Reply-To: <20070522230942.GT5921@austin.ibm.com>
Linas Vepstas wrote:
> From: Florin Malita <fmalita@gmail.com>
>
> The stats update code in spider_net_pass_skb_up() is touching the skb
> after it's been passed up to the stack. To avoid that, just update the
> stats first.
>
> Signed-off-by: Florin Malita <fmalita@gmail.com>
> Signed-off-by: Linas Vepstas <linas@austin.ibm.com>
> ----
>
> drivers/net/spider_net.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
applied to #upstream-fixes
prev parent reply other threads:[~2007-05-24 21:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-22 23:09 [PATCH 1/10] spidernet: skb used after netif_receive_skb Linas Vepstas
2007-05-22 23:13 ` [PATCH 2/10] spidernet: beautify error messages Linas Vepstas
2007-05-24 21:27 ` Jeff Garzik
2007-05-22 23:21 ` [PATCH 3/10] spidernet: move a block of code around Linas Vepstas
2007-05-22 23:36 ` [PATCH 4/10] spidernet: zero out a pointer Linas Vepstas
2007-05-22 23:39 ` [PATCH 5/10] spidernet: null out skb pointer after its been used Linas Vepstas
2007-05-22 23:40 ` [PATCH 6/10] spidernet: Don't terminate the RX ring Linas Vepstas
2007-05-22 23:42 ` [PATCH 7/10] spidernet: enhance the dump routine Linas Vepstas
2007-05-22 23:45 ` [PATCH 8/10] spidernet: reset the card when an rxramfull is seen Linas Vepstas
2007-05-22 23:47 ` [PATCH 9/10] spidernet: service TX later Linas Vepstas
2007-05-22 23:52 ` [PATCH 10/10] spidernet: increase the NAPI weight Linas Vepstas
2007-05-24 21:25 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465602E4.1050807@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@osdl.org \
--cc=cbe-oss-dev@ozlabs.org \
--cc=fmalita@gmail.com \
--cc=linas@austin.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).