From: Jeff Garzik <jeff@garzik.org>
To: Marc St-Jean <stjeanma@pmc-sierra.com>
Cc: akpm@linux-foundation.org, linux-mips@linux-mips.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 10/12] drivers: PMC MSP71xx ethernet driver
Date: Thu, 24 May 2007 17:46:05 -0400 [thread overview]
Message-ID: <4656079D.6010109@garzik.org> (raw)
In-Reply-To: <200705101839.l4AIdHB9030885@pasqua.pmc-sierra.bc.ca>
Marc St-Jean wrote:
> +inline static void
> +mspeth_skb_headerinit(struct sk_buff *skb)
> +{
> + /* these are essential before init */
> + dst_release(skb->dst);
> +#ifdef CONFIG_XFRM
> + secpath_put(skb->sp);
> +#endif
> +#ifdef CONFIG_NETFILTER
> + nf_conntrack_put(skb->nfct);
> +#if defined(CONFIG_NF_CONNTRACK) || defined(CONFIG_NF_CONNTRACK_MODULE)
> + nf_conntrack_put_reasm(skb->nfct_reasm);
> +#endif
> +#ifdef CONFIG_BRIDGE_NETFILTER
> + nf_bridge_put(skb->nf_bridge);
> +#endif
> +#endif /* CONFIG_NETFILTER */
> +
> + /*
> + * Now initialise the skb...
> + * Clear the members till skb->truesize.
> + */
> + memset(skb, 0, offsetof(struct sk_buff, truesize));
> +}
> +#endif /* CONFIG_MSPETH_SKB_RECYCLE */
Did you ever resend this driver addition, with the above unmaintainable
skb init hacks removed?
Jeff
next prev parent reply other threads:[~2007-05-24 21:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-10 18:39 [PATCH 10/12] drivers: PMC MSP71xx ethernet driver Marc St-Jean
2007-05-24 21:46 ` Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-05-28 21:46 Marc St-Jean
2007-05-29 3:13 ` Jeff Garzik
2007-05-25 0:12 Marc St-Jean
2007-05-25 1:26 ` Jeff Garzik
2007-05-24 22:49 Marc St-Jean
2007-05-24 22:13 Marc St-Jean
2007-05-24 22:25 ` Jeff Garzik
2007-05-09 19:08 Marc St-Jean
2007-04-27 0:48 Marc St-Jean
2007-05-08 5:38 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4656079D.6010109@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=stjeanma@pmc-sierra.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).