* [PATCH] Add select PHYLIB to the UCC_GETH Kconfig option
@ 2007-05-23 13:23 Jan Altenberg
2007-05-24 0:00 ` Kim Phillips
2007-05-24 21:47 ` Jeff Garzik
0 siblings, 2 replies; 4+ messages in thread
From: Jan Altenberg @ 2007-05-23 13:23 UTC (permalink / raw)
To: jeff; +Cc: kim.phillips, linux-kernel, netdev
ucc_geth has been migrated to use the common phylib code. So lets add a
'select PHYLIB' to the UCC_GETH Kconfig entry.
Signed-off-by: Jan Altenberg <jan.altenberg@linutronix.de>
---
drivers/net/Kconfig | 1 +
1 file changed, 1 insertion(+)
Index: linux-2.6/drivers/net/Kconfig
===================================================================
--- linux-2.6.orig/drivers/net/Kconfig
+++ linux-2.6/drivers/net/Kconfig
@@ -2280,6 +2280,7 @@ config GFAR_NAPI
config UCC_GETH
tristate "Freescale QE Gigabit Ethernet"
depends on QUICC_ENGINE
+ select PHYLIB
select UCC_FAST
help
This driver supports the Gigabit Ethernet mode of the QUICC Engine,
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Add select PHYLIB to the UCC_GETH Kconfig option
2007-05-23 13:23 [PATCH] Add select PHYLIB to the UCC_GETH Kconfig option Jan Altenberg
@ 2007-05-24 0:00 ` Kim Phillips
2007-05-24 21:47 ` Jeff Garzik
1 sibling, 0 replies; 4+ messages in thread
From: Kim Phillips @ 2007-05-24 0:00 UTC (permalink / raw)
To: Jan Altenberg; +Cc: jeff, netdev
On Wed, 23 May 2007 15:23:22 +0200
Jan Altenberg <jan.altenberg@linutronix.de> wrote:
> ucc_geth has been migrated to use the common phylib code. So lets add a
> 'select PHYLIB' to the UCC_GETH Kconfig entry.
>
> Signed-off-by: Jan Altenberg <jan.altenberg@linutronix.de>
Acked-by: Kim Phillips <kim.phillips@freescale.com>
Kim
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Add select PHYLIB to the UCC_GETH Kconfig option
2007-05-23 13:23 [PATCH] Add select PHYLIB to the UCC_GETH Kconfig option Jan Altenberg
2007-05-24 0:00 ` Kim Phillips
@ 2007-05-24 21:47 ` Jeff Garzik
2007-05-25 3:47 ` Li Yang-r58472
1 sibling, 1 reply; 4+ messages in thread
From: Jeff Garzik @ 2007-05-24 21:47 UTC (permalink / raw)
To: Jan Altenberg; +Cc: kim.phillips, linux-kernel, netdev
Jan Altenberg wrote:
> ucc_geth has been migrated to use the common phylib code. So lets add a
> 'select PHYLIB' to the UCC_GETH Kconfig entry.
>
> Signed-off-by: Jan Altenberg <jan.altenberg@linutronix.de>
>
> ---
> drivers/net/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: linux-2.6/drivers/net/Kconfig
> ===================================================================
> --- linux-2.6.orig/drivers/net/Kconfig
> +++ linux-2.6/drivers/net/Kconfig
> @@ -2280,6 +2280,7 @@ config GFAR_NAPI
> config UCC_GETH
> tristate "Freescale QE Gigabit Ethernet"
> depends on QUICC_ENGINE
> + select PHYLIB
> select UCC_FAST
Please fix the Kconfig warnings first.
Also, I ask again: WHO IS THE MAINTAINER OF THIS DRIVER?
I am tired of five independent people patching the same driver.
Jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] Add select PHYLIB to the UCC_GETH Kconfig option
2007-05-24 21:47 ` Jeff Garzik
@ 2007-05-25 3:47 ` Li Yang-r58472
0 siblings, 0 replies; 4+ messages in thread
From: Li Yang-r58472 @ 2007-05-25 3:47 UTC (permalink / raw)
To: Jeff Garzik, Jan Altenberg; +Cc: Phillips Kim-R1AAHA, linux-kernel, netdev
> -----Original Message-----
> From: netdev-owner@vger.kernel.org
[mailto:netdev-owner@vger.kernel.org] On
> Behalf Of Jeff Garzik
> Sent: Friday, May 25, 2007 5:48 AM
> To: Jan Altenberg
> Cc: Phillips Kim-R1AAHA; linux-kernel@vger.kernel.org;
netdev@vger.kernel.org
> Subject: Re: [PATCH] Add select PHYLIB to the UCC_GETH Kconfig option
>
> Jan Altenberg wrote:
> > ucc_geth has been migrated to use the common phylib code. So lets
add a
> > 'select PHYLIB' to the UCC_GETH Kconfig entry.
> >
> > Signed-off-by: Jan Altenberg <jan.altenberg@linutronix.de>
> >
> > ---
> > drivers/net/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > Index: linux-2.6/drivers/net/Kconfig
> > ===================================================================
> > --- linux-2.6.orig/drivers/net/Kconfig
> > +++ linux-2.6/drivers/net/Kconfig
> > @@ -2280,6 +2280,7 @@ config GFAR_NAPI
> > config UCC_GETH
> > tristate "Freescale QE Gigabit Ethernet"
> > depends on QUICC_ENGINE
> > + select PHYLIB
> > select UCC_FAST
>
> Please fix the Kconfig warnings first.
>
I will follow up this.
> Also, I ask again: WHO IS THE MAINTAINER OF THIS DRIVER?
>
> I am tired of five independent people patching the same driver.
Sorry for the trouble, I will post a patch to the MAINTAINER file and
help to maintain ucc_geth related patches.
- Leo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-05-25 3:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-23 13:23 [PATCH] Add select PHYLIB to the UCC_GETH Kconfig option Jan Altenberg
2007-05-24 0:00 ` Kim Phillips
2007-05-24 21:47 ` Jeff Garzik
2007-05-25 3:47 ` Li Yang-r58472
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).