netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ethtool: new ID to decode the registers of the 8168 (realtek)
@ 2007-05-24 20:02 Francois Romieu
  2007-05-24 21:50 ` Jeff Garzik
  0 siblings, 1 reply; 3+ messages in thread
From: Francois Romieu @ 2007-05-24 20:02 UTC (permalink / raw)
  To: jgarzik; +Cc: netdev

Tested with an Asrock 945G-DVI (LOM).

Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
---
 realtek.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/realtek.c b/realtek.c
index 64ab7f8..8daba69 100644
--- a/realtek.c
+++ b/realtek.c
@@ -45,6 +45,7 @@ static struct chip_info {
 	{ "RTL-8100B/8139D",	HW_REVID(1, 1, 1, 0, 1, 0, 1) },
 	{ "RTL-8139C+",		HW_REVID(1, 1, 1, 0, 1, 1, 0) },
 	{ "RTL-8101",		HW_REVID(1, 1, 1, 0, 1, 1, 1) },
+	{ "RTL-8168B/8111B",	HW_REVID(0, 1, 1, 1, 0, 0, 0) },
 	{ "RTL-8169",		HW_REVID(0, 0, 0, 0, 0, 0, 0) },
 	{ "RTL-8169s",		HW_REVID(0, 0, 0, 0, 1, 0, 0) },
 	{ "RTL-8110",		HW_REVID(0, 0, 1, 0, 0, 0, 0) },
-- 
1.5.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ethtool: new ID to decode the registers of the 8168 (realtek)
  2007-05-24 20:02 [PATCH] ethtool: new ID to decode the registers of the 8168 (realtek) Francois Romieu
@ 2007-05-24 21:50 ` Jeff Garzik
  2007-05-24 22:57   ` Francois Romieu
  0 siblings, 1 reply; 3+ messages in thread
From: Jeff Garzik @ 2007-05-24 21:50 UTC (permalink / raw)
  To: Francois Romieu; +Cc: netdev

Francois Romieu wrote:
> Tested with an Asrock 945G-DVI (LOM).
> 
> Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
> ---
>  realtek.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

applied

Also, I have really fallen off the ball when it comes to the r8169 
kernel driver.  My apologies.

Would you be kind enough to resend?  If there are important bug fixes 
that need to go into 2.6.22, that are safe enough to put in at this late 
date, please split those off from other improvements.

	Jeff




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ethtool: new ID to decode the registers of the 8168 (realtek)
  2007-05-24 21:50 ` Jeff Garzik
@ 2007-05-24 22:57   ` Francois Romieu
  0 siblings, 0 replies; 3+ messages in thread
From: Francois Romieu @ 2007-05-24 22:57 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: netdev

Jeff Garzik <jgarzik@pobox.com> :
[...]
> Would you be kind enough to resend ?

Of course.

> If there are important bug fixes that need to go into 2.6.22, that are
> safe enough to put in at this late date, please split those off from
> other improvements.

It's safer and simpler to wait for the next cycle.

Most complaints come from unhappy 8168/Asus (P5B) users who still need
a fix (somewhere along the VPD probably).

-- 
Ueimor

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-05-24 23:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-24 20:02 [PATCH] ethtool: new ID to decode the registers of the 8168 (realtek) Francois Romieu
2007-05-24 21:50 ` Jeff Garzik
2007-05-24 22:57   ` Francois Romieu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).