From: Jeff Garzik <jeff@garzik.org>
To: Ayaz Abdulla <aabdulla@nvidia.com>
Cc: Manfred Spraul <manfred@colorfullife.com>,
Andrew Morton <akpm@osdl.org>, nedev <netdev@vger.kernel.org>
Subject: Re: [PATCH 4/4] forcedeth: version bump
Date: Thu, 24 May 2007 18:03:05 -0400 [thread overview]
Message-ID: <46560B99.9020406@garzik.org> (raw)
In-Reply-To: <465237F5.2010208@nvidia.com>
Ayaz Abdulla wrote:
> This patch bumps up the version.
>
> Signed-off-by: Ayaz Abdulla <aabdulla@nvidia.com>
>
>
> ------------------------------------------------------------------------
>
> --- old/drivers/net/forcedeth.c 2007-05-21 20:09:03.000000000 -0400
> +++ new/drivers/net/forcedeth.c 2007-05-21 20:10:32.000000000 -0400
> @@ -112,6 +112,7 @@
> * 0.58: 30 Oct 2006: Added support for sideband management unit.
> * 0.59: 30 Oct 2006: Added support for recoverable error.
> * 0.60: 20 Jan 2007: Code optimizations for rings, rx & tx data paths, and stats.
> + * 0.61: 21 May 2007: Fix power management code, cpu mask, and added vitesse phy.
> *
> * Known bugs:
> * We suspect that on some hardware no TX done interrupts are generated.
The standard for kernel drivers these days is to rely on the
permanent-for-eternity kernel changelog stored in git.
So please just remove the entire history from the C source code. It's
just patch noise...
> @@ -128,7 +129,7 @@
> #else
> #define DRIVERNAPI
> #endif
> -#define FORCEDETH_VERSION "0.60"
> +#define FORCEDETH_VERSION "0.61"
> #define DRV_NAME "forcedeth"
obviously the rest of this patch is OK. But due to earlier patch
rejections, I will not apply it, and will assume it will reappear when
you resend other patches.
Finally, I would suggest keeping up with the kernel's "bug fix"
2.6.X-rcY release candidate cycles. These changes ARE bug fixes, I
agree, but they still should not be appearing at the last minute. That
gives us little time to ensure the fixes do not cause regressions.
Jeff
prev parent reply other threads:[~2007-05-24 22:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-22 0:23 [PATCH 4/4] forcedeth: version bump Ayaz Abdulla
2007-05-24 22:03 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46560B99.9020406@garzik.org \
--to=jeff@garzik.org \
--cc=aabdulla@nvidia.com \
--cc=akpm@osdl.org \
--cc=manfred@colorfullife.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).