From: Jeff Garzik <jeff@garzik.org>
To: Marc St-Jean <Marc_St-Jean@pmc-sierra.com>
Cc: Marc St-Jean <stjeanma@pmc-sierra.com>,
akpm@linux-foundation.org, linux-mips@linux-mips.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 10/12] drivers: PMC MSP71xx ethernet driver
Date: Thu, 24 May 2007 18:25:36 -0400 [thread overview]
Message-ID: <465610E0.6020309@garzik.org> (raw)
In-Reply-To: <46560E06.9090506@pmc-sierra.com>
Marc St-Jean wrote:
> I asked if the remaining section (above) was acceptable so we could retain our
> buffer recycling which enhances throughput. I never received a rely so it was
> left in my last patch.
>
> The above comment now answers my part of my initial question. Are you aware of
> a better way to implement this or must we lose all our recycling enhancements?
You can poke around on netdev and ask about skb recycling in a new
thread, and propose something.
I just know that having your own custom skb initialization is a
non-starter. Any updates the main skb init code receives will
inevitably -not- be propagate to your code, rapidly leading to an
unmaintainable disconnect.
skb recycling in general is an interesting area to explore, and others
have poked around that area before. I bet googling for skb recycling
would turn up some useful thoughts and past efforts.
Jeff
next prev parent reply other threads:[~2007-05-24 22:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-24 22:13 [PATCH 10/12] drivers: PMC MSP71xx ethernet driver Marc St-Jean
2007-05-24 22:25 ` Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-05-28 21:46 Marc St-Jean
2007-05-29 3:13 ` Jeff Garzik
2007-05-25 0:12 Marc St-Jean
2007-05-25 1:26 ` Jeff Garzik
2007-05-24 22:49 Marc St-Jean
2007-05-10 18:39 Marc St-Jean
2007-05-24 21:46 ` Jeff Garzik
2007-05-09 19:08 Marc St-Jean
2007-04-27 0:48 Marc St-Jean
2007-05-08 5:38 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465610E0.6020309@garzik.org \
--to=jeff@garzik.org \
--cc=Marc_St-Jean@pmc-sierra.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=stjeanma@pmc-sierra.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).