From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: divy@chelsio.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, swise@opengridcomputing.com
Subject: Re: [PATCH 2/7] cxgb3 - fix netpoll hanlder
Date: Tue, 29 May 2007 16:59:07 -0700 [thread overview]
Message-ID: <465CBE4B.9070009@goop.org> (raw)
In-Reply-To: <465B591B.1010507@garzik.org>
Jeff Garzik wrote:
>>
>> + t3_intr_handler(adapter, qs->rspq.polling) (0,
>> + (adapter->flags & USING_MSIX) ?
>> + (void *)qs : (void *)adapter);
>
> Remove needless casts to void*
The two branches of ?: need to have the same type; without the casts
they'd be "struct sge_qset" and "struct adapter". Seems a bit cruddy to
have two types passed to one function depending on the MSI state, but
maybe that's OK.
J
next prev parent reply other threads:[~2007-05-29 23:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-26 22:59 [PATCH 2/7] cxgb3 - fix netpoll hanlder divy
2007-05-28 22:35 ` Jeff Garzik
2007-05-29 23:59 ` Jeremy Fitzhardinge [this message]
2007-05-30 0:42 ` Jeff Garzik
2007-05-30 16:06 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465CBE4B.9070009@goop.org \
--to=jeremy@goop.org \
--cc=divy@chelsio.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).