From: Patrick McHardy <kaber@trash.net>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: Herbert Xu <herbert.xu@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Michael Chan <mchan@broadcom.com>
Subject: Re: [RFC] IPV6 checksum offloading in network devices
Date: Wed, 30 May 2007 18:13:24 +0200 [thread overview]
Message-ID: <465DA2A4.2060608@trash.net> (raw)
In-Reply-To: <20070530085320.0c35bd71@freepuppy>
Stephen Hemminger wrote:
> Here is a proposed change to address hardware that can do IPV6 checksum
> offload, but doesn't truly do generic hw checksumming. The bnx2 and tg3
> are like this for some revisions, and upcoming Marvell 88e8071 is similar.
>
>
> --- a/include/linux/netdevice.h 2007-05-30 08:26:18.000000000 -0700
> +++ b/include/linux/netdevice.h 2007-05-30 08:30:20.000000000 -0700
> @@ -314,9 +314,10 @@ struct net_device
> /* Net device features */
> unsigned long features;
> #define NETIF_F_SG 1 /* Scatter/gather IO. */
> -#define NETIF_F_IP_CSUM 2 /* Can checksum only TCP/UDP over IPv4. */
> +#define NETIF_F_IP_CSUM 2 /* Can checksum TCP/UDP over IPv4. */
> #define NETIF_F_NO_CSUM 4 /* Does not require checksum. F.e. loopack. */
> #define NETIF_F_HW_CSUM 8 /* Can checksum all the packets. */
> +#define NETIF_F_IPV6_CSUM 16 /* Can checksum TCP/UDP over IPV6 */
> #define NETIF_F_HIGHDMA 32 /* Can DMA to high memory. */
> #define NETIF_F_FRAGLIST 64 /* Scatter/gather IO. */
> #define NETIF_F_HW_VLAN_TX 128 /* Transmit VLAN hw acceleration */
> @@ -339,7 +340,8 @@ struct net_device
> #define NETIF_F_GSO_SOFTWARE (NETIF_F_TSO | NETIF_F_TSO_ECN | NETIF_F_TSO6)
>
> #define NETIF_F_GEN_CSUM (NETIF_F_NO_CSUM | NETIF_F_HW_CSUM)
> -#define NETIF_F_ALL_CSUM (NETIF_F_IP_CSUM | NETIF_F_GEN_CSUM)
> +#define NETIF_F_ALL_CSUM (NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM \
> + | NETIF_F_GEN_CSUM)
This might confuse some of the existing IPv4 code that
checks for NETIF_F_ALL_CSUM if we ever get a device that
has NETIF_F_IPV6_CSUM but not NETIF_F_IP_CSUM.
next prev parent reply other threads:[~2007-05-30 16:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-29 20:58 Definition and usage of NETIF_F_HW_SUM? Stephen Hemminger
2007-05-29 21:36 ` Herbert Xu
2007-05-29 21:58 ` Stephen Hemminger
2007-05-30 0:10 ` Michael Chan
2007-05-29 23:45 ` Stephen Hemminger
2007-06-04 15:35 ` Ron Mercer
2007-05-30 15:53 ` [RFC] IPV6 checksum offloading in network devices Stephen Hemminger
2007-05-30 16:13 ` Patrick McHardy [this message]
2007-05-30 21:00 ` Stephen Hemminger
2007-06-27 7:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465DA2A4.2060608@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=herbert.xu@redhat.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).