From mboxrd@z Thu Jan  1 00:00:00 1970
From: Patrick McHardy <kaber@trash.net>
Subject: Re: [patch 5/7] CAN: Add virtual CAN netdevice driver
Date: Wed, 30 May 2007 21:16:32 +0200
Message-ID: <465DCD90.9070103@trash.net>
References: <20070530131123.10843.0@janus.isnogud.escape.de> <20070530131204.10843.5@janus.isnogud.escape.de> <465DB0B6.109@trash.net> <465DC4CD.9080801@hartkopp.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Cc: Urs Thuermann <urs@isnogud.escape.de>,
	David Miller <davem@davemloft.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	Oliver Hartkopp <oliver.hartkopp@volkswagen.de>,
	Urs Thuermann <urs.thuermann@volkswagen.de>,
	netdev@vger.kernel.org
To: Oliver Hartkopp <oliver@hartkopp.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from stinky.trash.net ([213.144.137.162]:46347 "EHLO
	stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753751AbXE3TRV (ORCPT
	<rfc822;netdev@vger.kernel.org>); Wed, 30 May 2007 15:17:21 -0400
In-Reply-To: <465DC4CD.9080801@hartkopp.net>
Sender: netdev-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

Oliver Hartkopp wrote:
> Patrick McHardy wrote:
> 
>>I have a set of patches coming up that introduce a rtnetlink API
>>for adding/modifying/deleting software network devices. I would
>>prefer if you could switch this driver over instead of doing the
>>"create N devices during loading" that many current drivers do,
>>leaving you with 20 unused devices after boot.
>>  
> 
> 
> Hi Patrick,
> 
> next Friday? Too late ;-)


This friday :)

> Ok, your approach is indeed an interesting idea and we would look on it,
> as we also not interested in creating unused devices and do any double
> work.


Thanks.

>>(..)
>>Qdiscs might change skb->cb. Maybe use skb->sk?
>>
> 
> The loopback functionality in CAN is a bit tricky (maybe you can take a
> look into the Documentation patch [7/7] at chapter 3.2 and 4.1.4).
> 
> The problem is, that we need a per socket(!) option that enables the
> loopback for the sent CAN-Frames or not, so the information about
> loopback a skb content or not is contained inside the skb sent down to
> the CAN netdevice. If the CAN networkdevice is not capable to perform a
> loopback itself (see dev->flags, chapter 6) the CAN core has to do the
> loopback as a fallback.


skb->sk should work fine for a per socket option. In fact the
CAN core patch simply sets skb->cb to skb->sk.

> The use of skb->cb is also needed in the receive path to recognize and
> trash loopback'ed CAN-frames inside the *originating* socket (see
> chapter 4.1.4).


skb->sk should work here as well since you detect these frames
before queueing to the receiving socket.