netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: Doug Chapman <doug.chapman@hp.com>,
	Herbert Xu <herbert@gondor.apana.org.au>
Cc: e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [E1000-devel] REGRESSION: panic on e1000 driver
Date: Thu, 31 May 2007 08:23:24 -0700	[thread overview]
Message-ID: <465EE86C.6080301@intel.com> (raw)
In-Reply-To: <1180624569.23536.7.camel@athlon>

Doug Chapman wrote:
> On Thu, 2007-05-31 at 11:08 +1000, Herbert Xu wrote:
>> On Wed, May 30, 2007 at 05:22:30PM -0400, Doug Chapman wrote:
>>> but once again broken just yesterday by the following commit.  I have
>>> backed just this commit out and verified I no longer panic.
>> Hmm, the only way I can see this happening is if the hardware signals
>> an interrupt even though we've explicitly shut it off.  Does this patch
>> help? If it does help, does it produce the warning in dmesg?
>>
>> Thanks,
> 
> 
> The patch does fix the panic.  Here are all the e1000 messages from
> dmesg after a bootup.  Note that only eth0 is actually configured and
> connected:
> 
> 
> # dmesg | grep e1000
> e1000: 0000:01:02.0: e1000_probe: (PCI-X:66MHz:64-bit) 00:15:60:04:d7:f8
> e1000: eth0: e1000_probe: Intel(R) PRO/1000 Network Connection
> e1000: 0000:01:02.1: e1000_probe: (PCI-X:66MHz:64-bit) 00:15:60:04:d7:f9
> e1000: eth1: e1000_probe: Intel(R) PRO/1000 Network Connection
> e1000: 0000:15:02.0: e1000_probe: (PCI-X:66MHz:64-bit) 00:12:79:9e:b7:c4
> e1000: eth2: e1000_probe: Intel(R) PRO/1000 Network Connection
> e1000: 0000:15:02.1: e1000_probe: (PCI-X:66MHz:64-bit) 00:12:79:9e:b7:c5
> e1000: eth3: e1000_probe: Intel(R) PRO/1000 Network Connection
> e1000: Unexpected interrupt icr=0x4

that's indeed the link status change we fire manually to trigger the watchdog run:

#define E1000_ICR_LSC           0x00000004 /* Link Status Change */

Auke

  reply	other threads:[~2007-05-31 15:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-30 21:22 REGRESSION: panic on e1000 driver Doug Chapman
2007-05-30 22:57 ` Kok, Auke
2007-05-30 23:31   ` Doug Chapman
2007-05-31  0:51   ` Herbert Xu
2007-05-31  4:51     ` Kok, Auke
2007-05-31  5:06       ` Herbert Xu
2007-05-31 14:54         ` Kok, Auke
2007-05-31 21:49           ` Herbert Xu
2007-05-31 22:11             ` Kok, Auke
2007-05-31  1:08 ` Herbert Xu
2007-05-31 15:16   ` Doug Chapman
2007-05-31 15:23     ` Kok, Auke [this message]
2007-05-31 21:48       ` [E1000-devel] " Herbert Xu
2007-05-31 22:10         ` Kok, Auke
2007-05-31 22:10     ` Herbert Xu
2007-05-31 22:38       ` Doug Chapman
2007-06-01  0:34         ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=465EE86C.6080301@intel.com \
    --to=auke-jan.h.kok@intel.com \
    --cc=doug.chapman@hp.com \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).