From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Doug Chapman <doug.chapman@hp.com>,
netdev@vger.kernel.org, e1000-devel@lists.sourceforge.net
Subject: Re: REGRESSION: panic on e1000 driver
Date: Thu, 31 May 2007 15:11:12 -0700 [thread overview]
Message-ID: <465F4800.8080103@intel.com> (raw)
In-Reply-To: <20070531214947.GA9428@gondor.apana.org.au>
Herbert Xu wrote:
> On Thu, May 31, 2007 at 07:54:31AM -0700, Kok, Auke wrote:
>> so how about calling netif_poll_disable() before we register the net_device?
>
> Yes that should work. Let's move the other two netif_ calls while we're
> at it.
>
>> well no, if we make the watchdog (this is something I've already
>> implemented locally and -mm has it for instance) run as delayed work we can
>> just schedule a watchdog run instead of firing an interrupt.
>
> OK. The only thing I'm worried about is if we're uncovering some
> underlying problem with the platform with respect to memory barriers
> then we should get to the bottom of it first before making this problem
> disappear.
agreed. I will try to send a patch to do this later today.
Auke
next prev parent reply other threads:[~2007-05-31 22:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-30 21:22 REGRESSION: panic on e1000 driver Doug Chapman
2007-05-30 22:57 ` Kok, Auke
2007-05-30 23:31 ` Doug Chapman
2007-05-31 0:51 ` Herbert Xu
2007-05-31 4:51 ` Kok, Auke
2007-05-31 5:06 ` Herbert Xu
2007-05-31 14:54 ` Kok, Auke
2007-05-31 21:49 ` Herbert Xu
2007-05-31 22:11 ` Kok, Auke [this message]
2007-05-31 1:08 ` Herbert Xu
2007-05-31 15:16 ` Doug Chapman
2007-05-31 15:23 ` [E1000-devel] " Kok, Auke
2007-05-31 21:48 ` Herbert Xu
2007-05-31 22:10 ` Kok, Auke
2007-05-31 22:10 ` Herbert Xu
2007-05-31 22:38 ` Doug Chapman
2007-06-01 0:34 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465F4800.8080103@intel.com \
--to=auke-jan.h.kok@intel.com \
--cc=doug.chapman@hp.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).