From: Florian Fainelli <f.fainelli@gmail.com>
To: Jiping Ma <Jiping.Ma2@windriver.com>, David Miller <davem@davemloft.net>
Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com,
joabreu@synopsys.com, mcoquelin.stm32@gmail.com,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] stmmac: debugfs entry name is not be changed when udev rename device name.
Date: Mon, 6 Jan 2020 20:44:49 -0800 [thread overview]
Message-ID: <46650899-07e1-a385-93ae-5720fa185cc8@gmail.com> (raw)
In-Reply-To: <99d183bc-7668-7749-54d6-3649c549dec8@windriver.com>
On 1/6/2020 6:59 PM, Jiping Ma wrote:
>
>
> On 01/07/2020 10:22 AM, David Miller wrote:
>> From: Jiping Ma <Jiping.Ma2@windriver.com>
>> Date: Tue, 7 Jan 2020 09:00:53 +0800
>>
>>>
>>> On 01/07/2020 05:45 AM, David Miller wrote:
>>>> From: Jiping Ma <jiping.ma2@windriver.com>
>>>> Date: Mon, 6 Jan 2020 10:33:41 +0800
>>>>
>>>>> Add one notifier for udev changes net device name.
>>>>>
>>>>> Signed-off-by: Jiping Ma <jiping.ma2@windriver.com>
>>>> This doesn't apply to 'net' and since this is a bug fix that is where
>>>> you should target this change.
>>> What's the next step that I can do?
>> Respin your patch against the net GIT tree so that it applies clean.y
> OK, I will generate the new patch based on the latest linux kernel code.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
That is not quite the tree you should be using, you should be using the
"net" tree, which is here:
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/
and here are some useful pieces of information in the netdev FAQ:
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/tree/Documentation/networking/netdev-FAQ.rst#n28
Also, since this is not the version version of your patch, please make
sure your subject indicates this is not the first version, I have lost
count of the exact number of times you submitted this already (4?) so
this could be [PATCH net v5] in the subject or something like that.
Given you fix a bug please also provide an appropriate Fixes tag, which
should be:
Fixes: 466c5ac8bdf2 ("net: stmmac: create one debugfs dir per net-device")
--
Florian
next prev parent reply other threads:[~2020-01-07 4:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 2:33 [PATCH] stmmac: debugfs entry name is not be changed when udev rename device name Jiping Ma
2020-01-06 21:45 ` David Miller
2020-01-07 1:00 ` Jiping Ma
2020-01-07 2:22 ` David Miller
2020-01-07 2:59 ` Jiping Ma
2020-01-07 4:44 ` Florian Fainelli [this message]
2020-01-07 21:01 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2020-01-02 1:35 Jiping Ma
2020-01-05 4:18 ` David Miller
2020-01-06 1:30 ` Jiping Ma
2019-12-31 3:02 Jiping Ma
2019-12-31 2:03 Jiping Ma
2019-12-31 2:11 ` Randy Dunlap
2019-12-31 2:16 ` Jiping Ma
2019-12-31 2:22 ` Randy Dunlap
2019-12-31 2:28 ` Jiping Ma
2019-12-31 10:12 ` Sergei Shtylyov
2020-01-02 0:38 ` Jiping Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46650899-07e1-a385-93ae-5720fa185cc8@gmail.com \
--to=f.fainelli@gmail.com \
--cc=Jiping.Ma2@windriver.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=joabreu@synopsys.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).