Re: [RFC VLAN 10/10]: Use rtnl_link API

[Ben Greear <greearb@candelatech.com>]

Patrick McHardy wrote:
> Ben Greear wrote:
>> Patrick McHardy wrote:
>>
>>> [VLAN]: Use rtnl_link API
>>>
>>> Signed-off-by: Patrick McHardy <kaber@trash.net>
>>
>>> +static int vlan_newlink(struct net_device *dev,
>>> +            struct nlattr *tb[], struct nlattr *data[])
>>> +{
>>> +    struct vlan_dev_info *vlan = VLAN_DEV_INFO(dev);
>>> +    int err;
>>> +
>>> +    if (!tb[IFLA_LINK])
>>> +        return -EINVAL;
>>> +    if (!data[IFLA_VLAN_ID])
>>> +        return -EINVAL;
>>> +
>>> +    vlan->vlan_id  = nla_get_u16(data[IFLA_VLAN_ID]);
>>> +    vlan->real_dev = __dev_get_by_index(nla_get_u32(tb[IFLA_LINK]));
>>
>> It seems you are scribbling on dev->priv before you validate that
>> it is OK to do so?
>>
>> Or, maybe I'm just confused.
>>
>> What is 'dev' here?
> 
> 
> Its a newly created device, not registered at this point. The
> vlan_dev_info structure is used to communicate the settings
> to vlan_dev_init() (also by the ioctl wrapper).

Ok, that makes sense.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com