netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Pavel Emelianov <xemul@openvz.org>
Cc: David Miller <davem@davemloft.net>,
	Linux Netdev List <netdev@vger.kernel.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Patrick McHardy <kaber@trash.net>,
	Daniel Lezcano <dlezcano@fr.ibm.com>,
	Stephen Hemminger <shemminger@linux-foundation.org>,
	Kirill Korotaev <dev@openvz.org>,
	Linux Containers <containers@lists.osdl.org>
Subject: Re: [PATCH] Virtual ethernet tunnel (v.2)
Date: Thu, 07 Jun 2007 09:35:52 -0700	[thread overview]
Message-ID: <466833E8.4020904@candelatech.com> (raw)
In-Reply-To: <46682C87.1080702@openvz.org>

Pavel Emelianov wrote:

> Hmm... The loopback must be doing bad things then. It first calls
> eth_type_trans and then accounts for the new skb->len.

Perhaps it should be changed.  e100 calculates the entire
frame as far as I can tell, and e1000 and tg3 do it in hardware
(not sure what all they are counting, but I *think* it includes
the header...)

VLANs calculate before pulling it's header, though the ethernet
header has already been pulled by the time VLAN sees the skb.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


  reply	other threads:[~2007-06-07 16:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-07 11:13 [PATCH] Virtual ethernet tunnel (v.2) Pavel Emelianov
2007-06-07 11:16 ` [PATCH] Module for ip utility to support veth device (v.2) Pavel Emelianov
2007-06-07 15:59   ` Stephen Hemminger
2007-06-07 15:23 ` [PATCH] Virtual ethernet tunnel (v.2) Ben Greear
2007-06-07 15:39   ` Pavel Emelianov
2007-06-07 15:51     ` Ben Greear
2007-06-07 16:04       ` Pavel Emelianov
2007-06-07 16:35         ` Ben Greear [this message]
2007-06-08 16:00       ` Pavel Emelianov
2007-06-08 17:00         ` Ben Greear
2007-06-08 19:49           ` Carl-Daniel Hailfinger
2007-06-08 23:46             ` Ben Greear
2007-06-11 11:42       ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=466833E8.4020904@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=containers@lists.osdl.org \
    --cc=davem@davemloft.net \
    --cc=dev@openvz.org \
    --cc=dlezcano@fr.ibm.com \
    --cc=ebiederm@xmission.com \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    --cc=xemul@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).