From: Chuck Lever <chuck.lever@oracle.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>, netdev@vger.kernel.org
Subject: Re: [2.6 patch] net/sunrpc/rpcb_clnt.c: make struct rpcb_program static
Date: Tue, 12 Jun 2007 19:14:48 -0400 [thread overview]
Message-ID: <466F28E8.3010101@oracle.com> (raw)
In-Reply-To: <20070612230313.GZ3588@stusta.de>
[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]
Adrian Bunk wrote:
> This patch makes the needlessly global struct rpcb_program static.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Acked-by: Chuck Lever <chuck.lever@oracle.com>
> ---
>
> net/sunrpc/rpcb_clnt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-2.6.22-rc4-mm2/net/sunrpc/rpcb_clnt.c.old 2007-06-12 23:25:01.000000000 +0200
> +++ linux-2.6.22-rc4-mm2/net/sunrpc/rpcb_clnt.c 2007-06-12 23:25:19.000000000 +0200
> @@ -118,7 +118,7 @@
> #define RPCB_MAXOWNERLEN sizeof(RPCB_OWNER_STRING)
>
> static void rpcb_getport_done(struct rpc_task *, void *);
> -extern struct rpc_program rpcb_program;
> +static struct rpc_program rpcb_program;
>
> struct rpcbind_args {
> struct rpc_xprt * r_xprt;
> @@ -616,7 +616,7 @@
>
> static struct rpc_stat rpcb_stats;
>
> -struct rpc_program rpcb_program = {
> +static struct rpc_program rpcb_program = {
> .name = "rpcbind",
> .number = RPCBIND_PROGRAM,
> .nrvers = ARRAY_SIZE(rpcb_version),
>
[-- Attachment #2: chuck.lever.vcf --]
[-- Type: text/x-vcard, Size: 303 bytes --]
begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture: Linux Projects Group
adr:;;1015 Granger Avenue;Ann Arbor;MI;48104;USA
title:Principal Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
url:http://oss.oracle.com/~cel/
version:2.1
end:vcard
prev parent reply other threads:[~2007-06-12 23:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-12 23:03 [2.6 patch] net/sunrpc/rpcb_clnt.c: make struct rpcb_program static Adrian Bunk
2007-06-12 23:14 ` Chuck Lever [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=466F28E8.3010101@oracle.com \
--to=chuck.lever@oracle.com \
--cc=Trond.Myklebust@netapp.com \
--cc=bunk@stusta.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).