* [2.6 patch] net/sunrpc/rpcb_clnt.c: make struct rpcb_program static
@ 2007-06-12 23:03 Adrian Bunk
2007-06-12 23:14 ` Chuck Lever
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2007-06-12 23:03 UTC (permalink / raw)
To: Chuck Lever; +Cc: Trond Myklebust, netdev
This patch makes the needlessly global struct rpcb_program static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
net/sunrpc/rpcb_clnt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.22-rc4-mm2/net/sunrpc/rpcb_clnt.c.old 2007-06-12 23:25:01.000000000 +0200
+++ linux-2.6.22-rc4-mm2/net/sunrpc/rpcb_clnt.c 2007-06-12 23:25:19.000000000 +0200
@@ -118,7 +118,7 @@
#define RPCB_MAXOWNERLEN sizeof(RPCB_OWNER_STRING)
static void rpcb_getport_done(struct rpc_task *, void *);
-extern struct rpc_program rpcb_program;
+static struct rpc_program rpcb_program;
struct rpcbind_args {
struct rpc_xprt * r_xprt;
@@ -616,7 +616,7 @@
static struct rpc_stat rpcb_stats;
-struct rpc_program rpcb_program = {
+static struct rpc_program rpcb_program = {
.name = "rpcbind",
.number = RPCBIND_PROGRAM,
.nrvers = ARRAY_SIZE(rpcb_version),
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [2.6 patch] net/sunrpc/rpcb_clnt.c: make struct rpcb_program static
2007-06-12 23:03 [2.6 patch] net/sunrpc/rpcb_clnt.c: make struct rpcb_program static Adrian Bunk
@ 2007-06-12 23:14 ` Chuck Lever
0 siblings, 0 replies; 2+ messages in thread
From: Chuck Lever @ 2007-06-12 23:14 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Trond Myklebust, netdev
[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]
Adrian Bunk wrote:
> This patch makes the needlessly global struct rpcb_program static.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Acked-by: Chuck Lever <chuck.lever@oracle.com>
> ---
>
> net/sunrpc/rpcb_clnt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-2.6.22-rc4-mm2/net/sunrpc/rpcb_clnt.c.old 2007-06-12 23:25:01.000000000 +0200
> +++ linux-2.6.22-rc4-mm2/net/sunrpc/rpcb_clnt.c 2007-06-12 23:25:19.000000000 +0200
> @@ -118,7 +118,7 @@
> #define RPCB_MAXOWNERLEN sizeof(RPCB_OWNER_STRING)
>
> static void rpcb_getport_done(struct rpc_task *, void *);
> -extern struct rpc_program rpcb_program;
> +static struct rpc_program rpcb_program;
>
> struct rpcbind_args {
> struct rpc_xprt * r_xprt;
> @@ -616,7 +616,7 @@
>
> static struct rpc_stat rpcb_stats;
>
> -struct rpc_program rpcb_program = {
> +static struct rpc_program rpcb_program = {
> .name = "rpcbind",
> .number = RPCBIND_PROGRAM,
> .nrvers = ARRAY_SIZE(rpcb_version),
>
[-- Attachment #2: chuck.lever.vcf --]
[-- Type: text/x-vcard, Size: 303 bytes --]
begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture: Linux Projects Group
adr:;;1015 Granger Avenue;Ann Arbor;MI;48104;USA
title:Principal Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
url:http://oss.oracle.com/~cel/
version:2.1
end:vcard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-06-12 23:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-12 23:03 [2.6 patch] net/sunrpc/rpcb_clnt.c: make struct rpcb_program static Adrian Bunk
2007-06-12 23:14 ` Chuck Lever
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).