From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Emelianov Subject: Re: [PATCH] Virtual ethernet tunnel Date: Wed, 13 Jun 2007 20:02:22 +0400 Message-ID: <4670150E.5010309@openvz.org> References: <4666CEAA.8010903@openvz.org> <4666D296.2000002@trash.net> <4667BD1D.9080905@openvz.org> <466D3466.10306@trash.net> <466FB7E7.4060201@openvz.org> <466FD113.3070909@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: "Eric W. Biederman" , Linux Netdev List , Linux Containers , Kirill Korotaev To: Patrick McHardy Return-path: Received: from mailhub.sw.ru ([195.214.233.200]:19893 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758007AbXFMPc4 (ORCPT ); Wed, 13 Jun 2007 11:32:56 -0400 In-Reply-To: <466FD113.3070909@trash.net> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Patrick McHardy wrote: > Pavel Emelianov wrote: >> Patrick McHardy wrote: >> >>> The question is how to proceed. I haven't read all mails yet, but it >>> seems there is some disagreement about whether to create all devices >>> in the same namespace and move them later or create them directly in >> >> The agreement was that we can make any of the above. We can create >> booth devices in the init namespace and then move one of them into the >> desired namespace, or we can explicitly specify which namespace to create >> the pair in. > > > I'm going to push my latest patches to Dave today, the easiest way is > probably is you just add whatever you need to the API afterwards. > > OK. Dave didn't object against the driver. Hope he will accept it as well. I have also found a BUG in your API. Look, when you declare the alias with the MODULE_ALIAS_RTNL_LINK in drivers you use strings as an argument. But this macro stringifyes the argument itself which results in bad aliases. Signed-off-by: Pavel Emelianov --- diff --git a/include/net/rtnetlink.h b/include/net/rtnetlink.h index d744198..f627e1f 100644 --- a/include/net/rtnetlink.h +++ b/include/net/rtnetlink.h @@ -77,6 +77,6 @@ extern void __rtnl_link_unregister(struc extern int rtnl_link_register(struct rtnl_link_ops *ops); extern void rtnl_link_unregister(struct rtnl_link_ops *ops); -#define MODULE_ALIAS_RTNL_LINK(name) MODULE_ALIAS("rtnl-link-" #name) +#define MODULE_ALIAS_RTNL_LINK(name) MODULE_ALIAS("rtnl-link-" name) #endif