netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vlad Yasevich <vladislav.yasevich@hp.com>
To: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
Cc: davem@davemloft.net, pekkas@netcore.fi, netdev@vger.kernel.org
Subject: Re: [PATCH 1/3] [IPV6]: Restore semantics of Routing Header processing.
Date: Mon, 18 Jun 2007 14:16:29 -0400	[thread overview]
Message-ID: <4676CBFD.1040901@hp.com> (raw)
In-Reply-To: <20070618.150423.46608800.yoshfuji@linux-ipv6.org>

YOSHIFUJI Hideaki / 吉藤英明 wrote:
>  					 IPSTATS_MIB_INHDRERRORS);
> @@ -465,6 +440,8 @@ looped_back:
>  		break;
>  #ifdef CONFIG_IPV6_MIP6
>  	case IPV6_SRCRT_TYPE_2:
> +		if (accept_source_route < 0)
> +			goto unknown_rh;
>  		/* Silently discard invalid RTH type 2 */
>  		if (hdr->hdrlen != 2 || hdr->segments_left != 1) {
>  			IP6_INC_STATS_BH(ip6_dst_idev(skb->dst),

Do we really want to do this.  The IPv6 working group is bending over backwards
in it's attempt to _not_ break MIPv6 while deprecating RH0.  The ability to "break"
MIPv6 by disable RH2 without disabling the rest of MIP seems a "bad thing" to me.

-vlad


  reply	other threads:[~2007-06-18 18:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-18  6:04 [PATCH 1/3] [IPV6]: Restore semantics of Routing Header processing YOSHIFUJI Hideaki / 吉藤英明
2007-06-18 18:16 ` Vlad Yasevich [this message]
     [not found]   ` <20070709.143250.132417671.davem@davemloft.net>
2007-07-10  1:27     ` Vlad Yasevich
2007-07-10  3:42       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4676CBFD.1040901@hp.com \
    --to=vladislav.yasevich@hp.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=pekkas@netcore.fi \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).