* sky bugs in 2.6.22-rc5
@ 2007-06-18 19:49 Patrick McHardy
2007-06-18 19:51 ` Stephen Hemminger
2007-06-18 20:04 ` Stephen Hemminger
0 siblings, 2 replies; 9+ messages in thread
From: Patrick McHardy @ 2007-06-18 19:49 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Linux Netdev List
sky2 breaks reproducably in 2.6.22-rc5 when setting the interface
down and up again. Packets are not received on the other side,
after a short time tcpdump (on the sky2 side) shows
use-after-free patterns:
IP6 (hlim 255, next-header: ICMPv6 (58), length: 16)
fe80::215:f2ff:fe24:91f8 > ff02::2: [icmp6
sum ok] ICMP6, router solicitation, length 16
source link-address option (1), length 8 (1): 00:15:f2:24:91:f8
arp who-has 192.168.0.1 tell 192.168.0.100
5a:5a:5a:5a:5a:5a > 5a:5a:5a:5a:5a:5a, ethertype Unknown (0x5a5a),
length 219:
0x0000: 5a5a 5a5a 5a5a 5a5a 5a5a 5a5a 5a5a 5a5a ZZZZZZZZZZZZZZZZ
0x0010: 5a5a 5a5a 5a5a 5a5a 5a5a 5a5a 5a5a 5a5a ZZZZZZZZZZZZZZZZ
0x0020: 5a5a 5a5a 5a5a 5a5a 5a5a 5a5a 5a5a 5a5a ZZZZZZZZZZZZZZZZ
0x0030: 5a5a 5a5a 5a5a 5a5a 5a5a 5a5a 5a5a 5a5a ZZZZZZZZZZZZZZZZ
0x0040: 5a5a 5a5a 5a5a 5a5a 5a5a 5a5a 5a5a 5a5a ZZZZZZZZZZZZZZZZ
0x0050: 5a5a ZZ
Additionally I get this oops when using netconsole and setting
the device down and up again:
sky2 eth0: disabling interface
sky2 eth0: enabling interface
Unable to handle kernel NULL pointer dereference at 0000000000000be4 RIP:
[<ffffffff81162c6c>] sky2_xmit_frame+0x2c5/0x478
PGD 1338e4067 PUD 133945067 PMD 0
Oops: 0002 [1] PREEMPT SMP
CPU 1
Modules linked in: nfsd exportfs ppdev lp nfs lockd nfs_acl sunrpc
deflate zlib_deflate zlib_inflate twofish twofish_common camellia
serpent blowfish des cbc ecb blkcipher aes xcbc sha256 crypto_null
af_key rfcomm l2cap fuse nfnetlink_queue nfnetlink_log
nf_conntrack_netlink nf_nat nf_conntrack_ipv6 nf_conntrack_ipv4
nf_conntrack nfnetlink ip6_tables ip_tables x_tables hangcheck_timer
cpufreq_ondemand powernow_k8 freq_table video backlight thermal
processor fan ide_generic ide_disk ide_cd cdrom generic usbhid hid
hci_usb bluetooth snd_mpu401 snd_via82xx snd_mpu401_uart snd_seq_dummy
snd_seq_oss snd_via82xx_modem snd_ac97_codec ac97_bus snd_pcm_oss
snd_mixer_oss snd_seq_midi snd_seq_midi_event snd_seq snd_pcm evdev
snd_timer snd_rawmidi snd_seq_device via82cxxx psmouse serio_raw
parport_pc parport pcspkr snd soundcore snd_page_alloc i2c_viapro
ehci_hcd ide_core uhci_hcd
Pid: 5015, comm: ifconfig Not tainted 2.6.22-rc5 #2
RIP: 0010:[<ffffffff81162c6c>] [<ffffffff81162c6c>]
sky2_xmit_frame+0x2c5/0x478
RSP: 0018:ffff81013ecd1a08 EFLAGS: 00010082
RAX: 00000000ffffffc1 RBX: ffff81013f6ca8c0 RCX: 0000000000000be0
RDX: 000000000000017c RSI: 0000000000000000 RDI: ffff81013f79e578
RBP: ffff81013ecd1a48 R08: 0000000000000000 R09: 000000013d25805a
R10: 0000000057afde91 R11: 0000000000000004 R12: ffff81013d4d3078
R13: 0000000000000048 R14: 0000000000000000 R15: 0000000000000048
FS: 00002b708f7bb6f0(0000) GS:ffff81013fc7a4c8(0000) knlGS:00000000f7e566c0
CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
CR2: 0000000000000be4 CR3: 000000013393b000 CR4: 00000000000006e0
Process ifconfig (pid: 5015, threadinfo ffff81013ecd0000, task
ffff810133c9a0c0)
Stack: ffff81013f6ca000 ffff81013f6ca000 ffff81013fc994d0 0000000000000082
ffff81013f6ca000 0000000000000000 ffff81013ec30b90 ffff81013d4d3078
ffff81013ecd1aa8 ffffffff811baae2 000000000000002c 000000140000004a
Call Trace:
[<ffffffff811baae2>] netpoll_send_skb+0xd9/0x15a
[<ffffffff811bb999>] netpoll_send_udp+0x26c/0x27b
[<ffffffff81164249>] write_msg+0x4c/0x7b
[<ffffffff8102a92c>] __call_console_drivers+0x62/0x73
[<ffffffff8102a9ac>] _call_console_drivers+0x6f/0x73
[<ffffffff8102ab30>] release_console_sem+0x14c/0x1f7
[<ffffffff8102b097>] vprintk+0x28e/0x306
[<ffffffff8102b176>] printk+0x67/0x69
[<ffffffff811b269c>] dev_mc_upload+0x19/0x43
[<ffffffff8115fd08>] sky2_up+0x90/0x6d0
[<ffffffff811b06bf>] dev_open+0x37/0x78
[<ffffffff811ae59a>] dev_change_flags+0x5d/0x120
[<ffffffff811f39e7>] devinet_ioctl+0x24a/0x5be
[<ffffffff811f446a>] inet_ioctl+0x82/0xa0
[<ffffffff811a3fdf>] sock_ioctl+0x1c8/0x1ea
[<ffffffff81084cd0>] do_ioctl+0x2c/0xba
[<ffffffff81084faf>] vfs_ioctl+0x251/0x26e
[<ffffffff8108500e>] sys_ioctl+0x42/0x68
[<ffffffff81009d9e>] system_call+0x7e/0x83
Code: 66 44 89 79 04 44 89 09 88 41 07 44 88 71 06 48 89 c8 48 2b
The reason for the second problem seems to be that sky2 enables
the queue too early and netconsole sends packets before
initialization is complete when sky2_up() prints a message.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: sky bugs in 2.6.22-rc5
2007-06-18 19:49 sky bugs in 2.6.22-rc5 Patrick McHardy
@ 2007-06-18 19:51 ` Stephen Hemminger
2007-06-18 20:00 ` Patrick McHardy
2007-06-18 20:04 ` Stephen Hemminger
1 sibling, 1 reply; 9+ messages in thread
From: Stephen Hemminger @ 2007-06-18 19:51 UTC (permalink / raw)
To: Patrick McHardy; +Cc: Linux Netdev List
On Mon, 18 Jun 2007 21:49:49 +0200
Patrick McHardy <kaber@trash.net> wrote:
> sky2 breaks reproducably in 2.6.22-rc5 when setting the interface
> down and up again. Packets are not received on the other side,
> after a short time tcpdump (on the sky2 side) shows
> use-after-free patterns:
>
Haven't seen this, but seems odd.
> IP6 (hlim 255, next-header: ICMPv6 (58), length: 16)
> fe80::215:f2ff:fe24:91f8 > ff02::2: [icmp6
> sum ok] ICMP6, router solicitation, length 16
> source link-address option (1), length 8 (1): 00:15:f2:24:91:f8
> arp who-has 192.168.0.1 tell 192.168.0.100
> 5a:5a:5a:5a:5a:5a > 5a:5a:5a:5a:5a:5a, ethertype Unknown (0x5a5a),
> length 219:
> 0x0000: 5a5a 5a5a 5a5a 5a5a 5a5a 5a5a 5a5a 5a5a ZZZZZZZZZZZZZZZZ
> 0x0010: 5a5a 5a5a 5a5a 5a5a 5a5a 5a5a 5a5a 5a5a ZZZZZZZZZZZZZZZZ
> 0x0020: 5a5a 5a5a 5a5a 5a5a 5a5a 5a5a 5a5a 5a5a ZZZZZZZZZZZZZZZZ
> 0x0030: 5a5a 5a5a 5a5a 5a5a 5a5a 5a5a 5a5a 5a5a ZZZZZZZZZZZZZZZZ
> 0x0040: 5a5a 5a5a 5a5a 5a5a 5a5a 5a5a 5a5a 5a5a ZZZZZZZZZZZZZZZZ
> 0x0050: 5a5a ZZ
>
>
>
> Additionally I get this oops when using netconsole and setting
> the device down and up again:
>
> sky2 eth0: disabling interface
>
> sky2 eth0: enabling interface
> Unable to handle kernel NULL pointer dereference at 0000000000000be4 RIP:
> [<ffffffff81162c6c>] sky2_xmit_frame+0x2c5/0x478
> PGD 1338e4067 PUD 133945067 PMD 0
> Oops: 0002 [1] PREEMPT SMP
> CPU 1
> Modules linked in: nfsd exportfs ppdev lp nfs lockd nfs_acl sunrpc
> deflate zlib_deflate zlib_inflate twofish twofish_common camellia
> serpent blowfish des cbc ecb blkcipher aes xcbc sha256 crypto_null
> af_key rfcomm l2cap fuse nfnetlink_queue nfnetlink_log
> nf_conntrack_netlink nf_nat nf_conntrack_ipv6 nf_conntrack_ipv4
> nf_conntrack nfnetlink ip6_tables ip_tables x_tables hangcheck_timer
> cpufreq_ondemand powernow_k8 freq_table video backlight thermal
> processor fan ide_generic ide_disk ide_cd cdrom generic usbhid hid
> hci_usb bluetooth snd_mpu401 snd_via82xx snd_mpu401_uart snd_seq_dummy
> snd_seq_oss snd_via82xx_modem snd_ac97_codec ac97_bus snd_pcm_oss
> snd_mixer_oss snd_seq_midi snd_seq_midi_event snd_seq snd_pcm evdev
> snd_timer snd_rawmidi snd_seq_device via82cxxx psmouse serio_raw
> parport_pc parport pcspkr snd soundcore snd_page_alloc i2c_viapro
> ehci_hcd ide_core uhci_hcd
> Pid: 5015, comm: ifconfig Not tainted 2.6.22-rc5 #2
> RIP: 0010:[<ffffffff81162c6c>] [<ffffffff81162c6c>]
> sky2_xmit_frame+0x2c5/0x478
> RSP: 0018:ffff81013ecd1a08 EFLAGS: 00010082
> RAX: 00000000ffffffc1 RBX: ffff81013f6ca8c0 RCX: 0000000000000be0
> RDX: 000000000000017c RSI: 0000000000000000 RDI: ffff81013f79e578
> RBP: ffff81013ecd1a48 R08: 0000000000000000 R09: 000000013d25805a
> R10: 0000000057afde91 R11: 0000000000000004 R12: ffff81013d4d3078
> R13: 0000000000000048 R14: 0000000000000000 R15: 0000000000000048
> FS: 00002b708f7bb6f0(0000) GS:ffff81013fc7a4c8(0000) knlGS:00000000f7e566c0
> CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
> CR2: 0000000000000be4 CR3: 000000013393b000 CR4: 00000000000006e0
> Process ifconfig (pid: 5015, threadinfo ffff81013ecd0000, task
> ffff810133c9a0c0)
> Stack: ffff81013f6ca000 ffff81013f6ca000 ffff81013fc994d0 0000000000000082
> ffff81013f6ca000 0000000000000000 ffff81013ec30b90 ffff81013d4d3078
> ffff81013ecd1aa8 ffffffff811baae2 000000000000002c 000000140000004a
> Call Trace:
> [<ffffffff811baae2>] netpoll_send_skb+0xd9/0x15a
> [<ffffffff811bb999>] netpoll_send_udp+0x26c/0x27b
> [<ffffffff81164249>] write_msg+0x4c/0x7b
> [<ffffffff8102a92c>] __call_console_drivers+0x62/0x73
> [<ffffffff8102a9ac>] _call_console_drivers+0x6f/0x73
> [<ffffffff8102ab30>] release_console_sem+0x14c/0x1f7
> [<ffffffff8102b097>] vprintk+0x28e/0x306
> [<ffffffff8102b176>] printk+0x67/0x69
> [<ffffffff811b269c>] dev_mc_upload+0x19/0x43
> [<ffffffff8115fd08>] sky2_up+0x90/0x6d0
> [<ffffffff811b06bf>] dev_open+0x37/0x78
> [<ffffffff811ae59a>] dev_change_flags+0x5d/0x120
> [<ffffffff811f39e7>] devinet_ioctl+0x24a/0x5be
> [<ffffffff811f446a>] inet_ioctl+0x82/0xa0
> [<ffffffff811a3fdf>] sock_ioctl+0x1c8/0x1ea
> [<ffffffff81084cd0>] do_ioctl+0x2c/0xba
> [<ffffffff81084faf>] vfs_ioctl+0x251/0x26e
> [<ffffffff8108500e>] sys_ioctl+0x42/0x68
> [<ffffffff81009d9e>] system_call+0x7e/0x83
>
>
> Code: 66 44 89 79 04 44 89 09 88 41 07 44 88 71 06 48 89 c8 48 2b
>
>
> The reason for the second problem seems to be that sky2 enables
> the queue too early and netconsole sends packets before
> initialization is complete when sky2_up() prints a message.
Are you using large MTU?
--
Stephen Hemminger <shemminger@linux-foundation.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: sky bugs in 2.6.22-rc5
2007-06-18 19:51 ` Stephen Hemminger
@ 2007-06-18 20:00 ` Patrick McHardy
0 siblings, 0 replies; 9+ messages in thread
From: Patrick McHardy @ 2007-06-18 20:00 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Linux Netdev List
Stephen Hemminger wrote:
> On Mon, 18 Jun 2007 21:49:49 +0200
> Patrick McHardy <kaber@trash.net> wrote:
>
>
>>sky2 breaks reproducably in 2.6.22-rc5 when setting the interface
>>down and up again. Packets are not received on the other side,
>>after a short time tcpdump (on the sky2 side) shows
>>use-after-free patterns:
>>
>
>
> Haven't seen this, but seems odd.
Its 100% reproducable here by doing "ifconfig eth0 down; ifconfig
eth0 up".
>>The reason for the second problem seems to be that sky2 enables
>>the queue too early and netconsole sends packets before
>>initialization is complete when sky2_up() prints a message.
>
>
> Are you using large MTU?
No. I just tried to verify my "wakes queue to early" theory by
pulling the cable before setting the device up again and it still
crashed. If you want me to test anything just say so.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: sky bugs in 2.6.22-rc5
2007-06-18 19:49 sky bugs in 2.6.22-rc5 Patrick McHardy
2007-06-18 19:51 ` Stephen Hemminger
@ 2007-06-18 20:04 ` Stephen Hemminger
2007-06-18 20:13 ` Patrick McHardy
1 sibling, 1 reply; 9+ messages in thread
From: Stephen Hemminger @ 2007-06-18 20:04 UTC (permalink / raw)
To: Patrick McHardy; +Cc: Linux Netdev List
Does this fix it? It was possible for the PHY interrupt to race
while bringing link up.
--- a/drivers/net/sky2.c 2007-06-18 12:56:29.000000000 -0700
+++ b/drivers/net/sky2.c 2007-06-18 13:02:11.000000000 -0700
@@ -652,7 +652,6 @@ static void sky2_wol_init(struct sky2_po
static void sky2_mac_init(struct sky2_hw *hw, unsigned port)
{
- struct sky2_port *sky2 = netdev_priv(hw->dev[port]);
u16 reg;
int i;
const u8 *addr = hw->dev[port]->dev_addr;
@@ -679,9 +678,7 @@ static void sky2_mac_init(struct sky2_hw
/* Enable Transmit FIFO Underrun */
sky2_write8(hw, SK_REG(port, GMAC_IRQ_MSK), GMAC_DEF_MSK);
- spin_lock_bh(&sky2->phy_lock);
sky2_phy_init(hw, port);
- spin_unlock_bh(&sky2->phy_lock);
/* MIB clear */
reg = gma_read16(hw, port, GM_PHY_ADDR);
@@ -1259,6 +1256,7 @@ static int sky2_up(struct net_device *de
if (!sky2->rx_ring)
goto err_out;
+ spin_lock_bh(&sky2->phy_lock);
sky2_phy_power(hw, port, 1);
sky2_mac_init(hw, port);
@@ -1295,15 +1293,18 @@ static int sky2_up(struct net_device *de
err = sky2_rx_start(sky2);
if (err)
- goto err_out;
+ goto err_out_unlock;
/* Enable interrupts from phy/mac for port */
imask = sky2_read32(hw, B0_IMSK);
imask |= portirq_msk[port];
sky2_write32(hw, B0_IMSK, imask);
+ spin_unlock_bh(&sky2->phy_lock);
return 0;
+err_out_unlock:
+ spin_unlock_bh(&sky2->phy_lock);
err_out:
if (sky2->rx_le) {
pci_free_consistent(hw->pdev, RX_LE_BYTES,
@@ -1571,6 +1572,8 @@ static int sky2_down(struct net_device *
if (netif_msg_ifdown(sky2))
printk(KERN_INFO PFX "%s: disabling interface\n", dev->name);
+ spin_lock_bh(&sky2->phy_lock);
+
/* Stop more packets from being queued */
netif_stop_queue(dev);
netif_carrier_off(dev);
@@ -1647,6 +1650,7 @@ static int sky2_down(struct net_device *
sky2->rx_ring = NULL;
sky2->tx_ring = NULL;
+ spin_unlock_bh(&sky2->phy_lock);
return 0;
}
@@ -1830,10 +1834,10 @@ static void sky2_phy_intr(struct sky2_hw
struct sky2_port *sky2 = netdev_priv(dev);
u16 istatus, phystat;
+ spin_lock(&sky2->phy_lock);
if (!netif_running(dev))
- return;
+ goto out;
- spin_lock(&sky2->phy_lock);
istatus = gm_phy_read(hw, port, PHY_MARV_INT_STAT);
phystat = gm_phy_read(hw, port, PHY_MARV_PHY_STAT);
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: sky bugs in 2.6.22-rc5
2007-06-18 20:04 ` Stephen Hemminger
@ 2007-06-18 20:13 ` Patrick McHardy
2007-06-18 20:20 ` Stephen Hemminger
0 siblings, 1 reply; 9+ messages in thread
From: Patrick McHardy @ 2007-06-18 20:13 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Linux Netdev List
Stephen Hemminger wrote:
> Does this fix it? It was possible for the PHY interrupt to race
> while bringing link up.
No, both problems are still present.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: sky bugs in 2.6.22-rc5
2007-06-18 20:13 ` Patrick McHardy
@ 2007-06-18 20:20 ` Stephen Hemminger
2007-06-18 20:43 ` Patrick McHardy
0 siblings, 1 reply; 9+ messages in thread
From: Stephen Hemminger @ 2007-06-18 20:20 UTC (permalink / raw)
To: Patrick McHardy; +Cc: Linux Netdev List
On Mon, 18 Jun 2007 22:13:50 +0200
Patrick McHardy <kaber@trash.net> wrote:
> Stephen Hemminger wrote:
> > Does this fix it? It was possible for the PHY interrupt to race
> > while bringing link up.
>
>
> No, both problems are still present.
What hardware. Could you load with messages max: modprobe sky2 debug=15
--
Stephen Hemminger <shemminger@linux-foundation.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: sky bugs in 2.6.22-rc5
2007-06-18 20:20 ` Stephen Hemminger
@ 2007-06-18 20:43 ` Patrick McHardy
2007-06-18 20:47 ` Stephen Hemminger
0 siblings, 1 reply; 9+ messages in thread
From: Patrick McHardy @ 2007-06-18 20:43 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Linux Netdev List
[-- Attachment #1: Type: text/plain, Size: 677 bytes --]
Stephen Hemminger wrote:
> On Mon, 18 Jun 2007 22:13:50 +0200
> Patrick McHardy <kaber@trash.net> wrote:
>
>
>>Stephen Hemminger wrote:
>>
>>>Does this fix it? It was possible for the PHY interrupt to race
>>>while bringing link up.
>>
>>
>>No, both problems are still present.
>
>
> What hardware. Could you load with messages max: modprobe sky2 debug=15
sky2 0000:05:00.0: v1.14 addr 0xdb000000 irq 36 Yukon-EC (0xb6) rev 2
Unloading the driver (with your patch) crashed my box twice. I've
attached a log of loading the driver with debug=15, transmitting
a few packets, then setting it down and up again and trying to
transmit a few more packets (which didn't work).
[-- Attachment #2: sky2 --]
[-- Type: text/plain, Size: 13154 bytes --]
ACPI: PCI Interrupt 0000:05:00.0[A] -> GSI 36 (level, low) -> IRQ 36
PCI: Setting latency timer of device 0000:05:00.0 to 64
sky2 0000:05:00.0: v1.14 addr 0xdb000000 irq 36 Yukon-EC (0xb6) rev 2
APIC error on CPU0: 08(08)
APIC error on CPU1: 08(08)
sky2 0000:05:00.0: No interrupt generated using MSI, switching to INTx mode.
sky2 eth0: addr 00:15:f2:24:91:f8
sky2 eth0: enabling interface
sky2 eth0: ram buffer 48K
ADDRCONF(NETDEV_UP): eth0: link is not ready
sky2 eth0: phy interrupt status 0x1c00 0x7d0c
sky2 eth0: Link is up at 100 Mbps, full duplex, flow control both
ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
eth0: tx queued, slot 0, len 90
eth0: tx done 1
sky2 eth0: rx slot 0 status 0xdb0300 len 219
sky2 eth0: rx slot 1 status 0xdc2300 len 220
sky2 eth0: rx slot 2 status 0xdc2300 len 220
sky2 eth0: rx slot 3 status 0xdc2300 len 220
sky2 eth0: rx slot 4 status 0xdc2300 len 220
sky2 eth0: rx slot 5 status 0xdc2300 len 220
sky2 eth0: rx slot 6 status 0xdc2300 len 220
sky2 eth0: rx slot 7 status 0xdc2300 len 220
sky2 eth0: rx slot 8 status 0xdc2300 len 220
sky2 eth0: rx slot 9 status 0xdc2300 len 220
sky2 eth0: rx slot 10 status 0xdc2300 len 220
eth0: tx queued, slot 2, len 42
sky2 eth0: rx slot 11 status 0x3c0100 len 60
eth0: tx queued, slot 3, len 81
eth0: tx queued, slot 5, len 71
eth0: tx done 2
sky2 eth0: rx slot 12 status 0x980100 len 152
eth0: tx done 4
eth0: tx done 5
sky2 eth0: rx slot 13 status 0xad0100 len 173
eth0: tx queued, slot 6, len 98
sky2 eth0: rx slot 14 status 0x620100 len 98
eth0: tx done 6
eth0: tx queued, slot 7, len 81
eth0: tx queued, slot 8, len 84
sky2 eth0: rx slot 15 status 0x1410100 len 321
eth0: tx done 7
eth0: tx queued, slot 9, len 81
eth0: tx done 8
sky2 eth0: rx slot 16 status 0xd30100 len 211
eth0: tx done 9
sky2 eth0: rx slot 17 status 0x1410100 len 321
eth0: tx queued, slot 10, len 81
sky2 eth0: rx slot 18 status 0x980100 len 152
eth0: tx done 10
eth0: tx queued, slot 11, len 81
sky2 eth0: rx slot 19 status 0x1410100 len 321
eth0: tx done 11
eth0: tx queued, slot 12, len 81
sky2 eth0: rx slot 20 status 0x1410100 len 321
eth0: tx done 12
eth0: tx queued, slot 13, len 81
sky2 eth0: rx slot 21 status 0x980100 len 152
eth0: tx done 13
eth0: tx queued, slot 14, len 81
sky2 eth0: rx slot 22 status 0x1410100 len 321
eth0: tx done 14
eth0: tx queued, slot 15, len 81
sky2 eth0: rx slot 23 status 0x1410100 len 321
eth0: tx done 15
eth0: tx queued, slot 16, len 81
sky2 eth0: rx slot 24 status 0x980100 len 152
eth0: tx done 16
eth0: tx queued, slot 17, len 81
sky2 eth0: rx slot 25 status 0x1410100 len 321
eth0: tx done 17
eth0: tx queued, slot 18, len 81
sky2 eth0: rx slot 26 status 0x1410100 len 321
eth0: tx done 18
eth0: tx queued, slot 19, len 90
eth0: tx done 19
eth0: tx queued, slot 20, len 90
eth0: tx done 20
sky2 eth0: rx slot 27 status 0x5a0100 len 90
eth0: tx queued, slot 21, len 90
eth0: tx done 21
eth0: tx queued, slot 22, len 90
eth0: tx done 22
eth0: tx queued, slot 23, len 78
eth0: tx done 23
sky2 eth0: rx slot 28 status 0x5a0100 len 90
eth0: tx queued, slot 24, len 90
eth0: tx done 24
sky2 eth0: rx slot 29 status 0x5a0100 len 90
eth0: tx queued, slot 25, len 90
eth0: tx done 25
sky2 eth0: rx slot 30 status 0x5a0100 len 90
eth0: tx queued, slot 26, len 90
eth0: tx done 26
sky2 eth0: rx slot 31 status 0x5a0100 len 90
eth0: tx queued, slot 27, len 90
eth0: tx done 27
eth0: tx queued, slot 28, len 90
eth0: tx done 28
sky2 eth0: rx slot 32 status 0x5a0100 len 90
sky2 eth0: rx slot 33 status 0x5a0100 len 90
eth0: tx queued, slot 29, len 90
eth0: tx done 29
sky2 eth0: rx slot 34 status 0x5a0100 len 90
eth0: tx queued, slot 30, len 90
eth0: tx done 30
eth0: tx queued, slot 31, len 90
eth0: tx done 31
sky2 eth0: rx slot 35 status 0x5a0100 len 90
eth0: tx queued, slot 32, len 90
eth0: tx done 32
sky2 eth0: rx slot 36 status 0x5a0100 len 90
eth0: tx queued, slot 33, len 90
eth0: tx done 33
sky2 eth0: rx slot 37 status 0x5a0100 len 90
sky2 eth0: rx slot 38 status 0xce0300 len 206
sky2 eth0: rx slot 39 status 0xcf2300 len 207
sky2 eth0: rx slot 40 status 0xcf2300 len 207
sky2 eth0: rx slot 41 status 0xcf2300 len 207
sky2 eth0: rx slot 42 status 0xcf2300 len 207
sky2 eth0: rx slot 43 status 0xcf2300 len 207
sky2 eth0: rx slot 44 status 0xcf2300 len 207
sky2 eth0: rx slot 45 status 0xcf2300 len 207
sky2 eth0: rx slot 46 status 0xcf2300 len 207
sky2 eth0: rx slot 47 status 0xcf2300 len 207
sky2 eth0: rx slot 48 status 0xcf2300 len 207
sky2 eth0: rx slot 49 status 0x5a0100 len 90
eth0: tx queued, slot 34, len 90
eth0: tx done 34
sky2 eth0: rx slot 50 status 0x5a0100 len 90
eth0: tx queued, slot 35, len 90
eth0: tx done 35
sky2 eth0: rx slot 51 status 0x5a0100 len 90
eth0: tx queued, slot 36, len 90
eth0: tx done 36
eth0: tx queued, slot 37, len 90
eth0: tx done 37
sky2 eth0: rx slot 52 status 0x5a0100 len 90
sky2 eth0: rx slot 53 status 0x5a0100 len 90
eth0: tx queued, slot 38, len 90
eth0: tx done 38
sky2 eth0: rx slot 54 status 0x5a0100 len 90
sky2 eth0: rx slot 55 status 0x5a0100 len 90
eth0: tx queued, slot 39, len 90
eth0: tx done 39
sky2 eth0: rx slot 56 status 0x5a0100 len 90
eth0: tx queued, slot 40, len 90
eth0: tx done 40
sky2 eth0: rx slot 57 status 0x5a0100 len 90
eth0: tx queued, slot 41, len 90
eth0: tx done 41
sky2 eth0: rx slot 58 status 0x5a0100 len 90
eth0: tx queued, slot 42, len 90
eth0: tx done 42
sky2 eth0: rx slot 59 status 0x5a0100 len 90
eth0: tx queued, slot 43, len 90
eth0: tx done 43
sky2 eth0: rx slot 60 status 0x5a0100 len 90
eth0: tx queued, slot 44, len 90
eth0: tx done 44
sky2 eth0: rx slot 61 status 0x5a0100 len 90
eth0: tx queued, slot 45, len 90
eth0: tx done 45
eth0: tx queued, slot 46, len 70
eth0: tx done 46
sky2 eth0: rx slot 62 status 0x6e0500 len 110
sky2 eth0: rx slot 63 status 0x5a0100 len 90
eth0: tx queued, slot 47, len 90
eth0: tx done 47
eth0: tx queued, slot 48, len 78
eth0: tx done 48
eth0: tx queued, slot 49, len 90
eth0: tx done 49
sky2 eth0: rx slot 64 status 0x5a0100 len 90
eth0: tx queued, slot 50, len 90
eth0: tx done 50
eth0: tx queued, slot 51, len 90
eth0: tx done 51
sky2 eth0: rx slot 65 status 0x5a0100 len 90
eth0: tx queued, slot 52, len 90
eth0: tx done 52
sky2 eth0: rx slot 66 status 0x5a0100 len 90
eth0: tx queued, slot 53, len 90
eth0: tx done 53
eth0: tx queued, slot 54, len 90
eth0: tx done 54
sky2 eth0: rx slot 67 status 0x5a0100 len 90
eth0: tx queued, slot 55, len 90
eth0: tx done 55
sky2 eth0: rx slot 68 status 0x5a0100 len 90
eth0: tx queued, slot 56, len 90
eth0: tx done 56
sky2 eth0: rx slot 69 status 0x5a0100 len 90
eth0: tx queued, slot 57, len 90
eth0: tx done 57
sky2 eth0: rx slot 70 status 0x5a0100 len 90
eth0: tx queued, slot 58, len 90
eth0: tx done 58
sky2 eth0: rx slot 71 status 0x5a0100 len 90
sky2 eth0: rx slot 72 status 0x5a0100 len 90
eth0: tx queued, slot 59, len 90
eth0: tx done 59
sky2 eth0: rx slot 73 status 0x5a0100 len 90
eth0: tx queued, slot 60, len 90
eth0: tx done 60
sky2 eth0: rx slot 74 status 0x5a0100 len 90
eth0: tx queued, slot 61, len 90
eth0: tx done 61
sky2 eth0: rx slot 75 status 0x5a0100 len 90
eth0: tx queued, slot 62, len 90
eth0: tx done 62
sky2 eth0: rx slot 76 status 0x5a0100 len 90
eth0: tx queued, slot 63, len 90
eth0: tx done 63
sky2 eth0: rx slot 77 status 0x5a0100 len 90
eth0: tx queued, slot 64, len 90
eth0: tx done 64
sky2 eth0: rx slot 78 status 0x5a0100 len 90
eth0: tx queued, slot 65, len 90
eth0: tx queued, slot 66, len 90
eth0: tx done 65
eth0: tx done 66
sky2 eth0: rx slot 79 status 0x5a0100 len 90
eth0: tx queued, slot 67, len 90
eth0: tx done 67
sky2 eth0: rx slot 80 status 0x5a0100 len 90
eth0: tx queued, slot 68, len 90
eth0: tx done 68
sky2 eth0: rx slot 81 status 0x5a0100 len 90
sky2 eth0: rx slot 82 status 0x5a0100 len 90
eth0: tx queued, slot 69, len 90
eth0: tx done 69
sky2 eth0: rx slot 83 status 0x5a0100 len 90
sky2 eth0: rx slot 84 status 0x5a0100 len 90
eth0: tx queued, slot 70, len 90
eth0: tx done 70
sky2 eth0: rx slot 85 status 0x5a0100 len 90
eth0: tx queued, slot 71, len 90
eth0: tx done 71
sky2 eth0: rx slot 86 status 0x5a0100 len 90
eth0: tx queued, slot 72, len 90
eth0: tx done 72
sky2 eth0: rx slot 87 status 0x5a0100 len 90
eth0: tx queued, slot 73, len 90
eth0: tx done 73
sky2 eth0: rx slot 88 status 0x5a0100 len 90
eth0: tx queued, slot 74, len 90
eth0: tx done 74
sky2 eth0: rx slot 89 status 0x5a0100 len 90
eth0: tx queued, slot 75, len 90
eth0: tx done 75
sky2 eth0: rx slot 90 status 0x5a0100 len 90
eth0: tx queued, slot 76, len 90
eth0: tx done 76
sky2 eth0: rx slot 91 status 0x5a0100 len 90
eth0: tx queued, slot 77, len 90
eth0: tx done 77
sky2 eth0: rx slot 92 status 0x5a0100 len 90
eth0: tx queued, slot 78, len 90
eth0: tx done 78
sky2 eth0: rx slot 93 status 0x5a0100 len 90
eth0: tx queued, slot 79, len 90
eth0: tx done 79
sky2 eth0: rx slot 94 status 0x5a0100 len 90
eth0: tx queued, slot 80, len 90
eth0: tx done 80
sky2 eth0: rx slot 95 status 0x5a0100 len 90
eth0: tx queued, slot 81, len 90
eth0: tx done 81
sky2 eth0: rx slot 96 status 0x5a0100 len 90
eth0: tx queued, slot 82, len 90
eth0: tx done 82
sky2 eth0: rx slot 97 status 0x5a0100 len 90
eth0: tx queued, slot 83, len 90
eth0: tx done 83
eth0: tx queued, slot 84, len 90
eth0: tx queued, slot 85, len 90
eth0: tx done 84
eth0: tx done 85
sky2 eth0: rx slot 98 status 0x5a0100 len 90
sky2 eth0: rx slot 99 status 0x5a0100 len 90
eth0: tx queued, slot 86, len 90
eth0: tx done 86
sky2 eth0: rx slot 100 status 0x5a0100 len 90
eth0: tx queued, slot 87, len 90
eth0: tx done 87
eth0: tx queued, slot 88, len 90
eth0: tx done 88
sky2 eth0: rx slot 101 status 0x5a0100 len 90
eth0: tx queued, slot 89, len 90
eth0: tx done 89
sky2 eth0: rx slot 102 status 0x5a0100 len 90
eth0: tx queued, slot 90, len 90
eth0: tx done 90
sky2 eth0: rx slot 103 status 0x5a0100 len 90
eth0: tx queued, slot 91, len 90
eth0: tx done 91
sky2 eth0: rx slot 104 status 0x5a0100 len 90
eth0: tx queued, slot 92, len 90
eth0: tx done 92
sky2 eth0: rx slot 105 status 0x5a0100 len 90
eth0: tx queued, slot 93, len 90
eth0: tx done 93
sky2 eth0: rx slot 106 status 0x5a0100 len 90
eth0: tx queued, slot 94, len 90
eth0: tx done 94
sky2 eth0: rx slot 107 status 0x5a0100 len 90
eth0: tx queued, slot 95, len 90
eth0: tx done 95
sky2 eth0: rx slot 108 status 0x5a0100 len 90
eth0: tx queued, slot 96, len 90
sky2 eth0: rx slot 109 status 0x5a0100 len 90
eth0: tx done 96
eth0: tx queued, slot 97, len 90
eth0: tx done 97
sky2 eth0: rx slot 110 status 0x5a0100 len 90
sky2 eth0: rx slot 111 status 0x5a0100 len 90
eth0: tx queued, slot 98, len 90
eth0: tx done 98
sky2 eth0: rx slot 112 status 0x5a0100 len 90
eth0: tx queued, slot 99, len 90
eth0: tx done 99
sky2 eth0: rx slot 113 status 0x5a0100 len 90
sky2 eth0: rx slot 114 status 0x5a0100 len 90
eth0: tx queued, slot 100, len 90
eth0: tx done 100
sky2 eth0: rx slot 115 status 0x5a0100 len 90
eth0: tx queued, slot 101, len 90
eth0: tx done 101
sky2 eth0: rx slot 116 status 0x5a0100 len 90
eth0: tx queued, slot 102, len 90
eth0: tx done 102
eth0: tx queued, slot 103, len 90
eth0: tx done 103
sky2 eth0: rx slot 117 status 0x5a0100 len 90
sky2 eth0: rx slot 118 status 0x5a0100 len 90
eth0: tx queued, slot 104, len 90
eth0: tx done 104
sky2 eth0: rx slot 119 status 0x5a0100 len 90
eth0: tx queued, slot 105, len 90
eth0: tx done 105
sky2 eth0: rx slot 120 status 0x5a0100 len 90
eth0: tx queued, slot 106, len 90
eth0: tx done 106
eth0: tx queued, slot 107, len 90
eth0: tx done 107
sky2 eth0: rx slot 121 status 0x5a0100 len 90
sky2 eth0: rx slot 122 status 0x5a0100 len 90
eth0: tx queued, slot 108, len 90
eth0: tx done 108
sky2 eth0: rx slot 123 status 0x5a0100 len 90
eth0: tx queued, slot 109, len 90
eth0: tx done 109
sky2 eth0: disabling interface
sky2 eth0: enabling interface
sky2 eth0: ram buffer 48K
ADDRCONF(NETDEV_UP): eth0: link is not ready
sky2 eth0: phy interrupt status 0x1c00 0x7d0c
sky2 eth0: Link is up at 100 Mbps, full duplex, flow control both
ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
eth0: tx queued, slot 0, len 90
eth0: tx done 0
eth0: tx queued, slot 1, len 42
eth0: tx done 1
eth0: tx queued, slot 2, len 78
eth0: tx done 2
eth0: tx queued, slot 3, len 42
eth0: tx done 3
eth0: tx queued, slot 4, len 70
eth0: tx done 4
eth0: tx queued, slot 5, len 90
eth0: tx done 5
eth0: tx queued, slot 6, len 42
eth0: tx done 6
eth0: tx queued, slot 7, len 42
eth0: tx done 7
eth0: tx queued, slot 8, len 42
eth0: tx done 8
eth0: tx queued, slot 9, len 42
eth0: tx done 9
eth0: tx queued, slot 10, len 70
eth0: tx done 10
eth0: tx queued, slot 11, len 42
eth0: tx done 11
eth0: tx queued, slot 12, len 42
eth0: tx done 12
eth0: tx queued, slot 13, len 42
eth0: tx done 13
eth0: tx queued, slot 14, len 70
eth0: tx done 14
eth0: tx queued, slot 15, len 42
eth0: tx done 15
eth0: no IPv6 routers present
eth0: tx queued, slot 16, len 42
eth0: tx done 16
eth0: tx queued, slot 17, len 42
eth0: tx done 17
eth0: tx queued, slot 18, len 42
eth0: tx done 18
eth0: tx queued, slot 19, len 42
eth0: tx done 19
eth0: tx queued, slot 20, len 42
eth0: tx done 20
eth0: tx queued, slot 21, len 42
eth0: tx done 21
sky2 eth0: disabling interface
ACPI: PCI interrupt for device 0000:05:00.0 disabled
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: sky bugs in 2.6.22-rc5
2007-06-18 20:43 ` Patrick McHardy
@ 2007-06-18 20:47 ` Stephen Hemminger
2007-06-18 20:56 ` Patrick McHardy
0 siblings, 1 reply; 9+ messages in thread
From: Stephen Hemminger @ 2007-06-18 20:47 UTC (permalink / raw)
To: Patrick McHardy; +Cc: Linux Netdev List
On Mon, 18 Jun 2007 22:43:50 +0200
Patrick McHardy <kaber@trash.net> wrote:
> Stephen Hemminger wrote:
> > On Mon, 18 Jun 2007 22:13:50 +0200
> > Patrick McHardy <kaber@trash.net> wrote:
> >
> >
> >>Stephen Hemminger wrote:
> >>
> >>>Does this fix it? It was possible for the PHY interrupt to race
> >>>while bringing link up.
> >>
> >>
> >>No, both problems are still present.
> >
> >
> > What hardware. Could you load with messages max: modprobe sky2 debug=15
>
> sky2 0000:05:00.0: v1.14 addr 0xdb000000 irq 36 Yukon-EC (0xb6) rev 2
>
> Unloading the driver (with your patch) crashed my box twice.
Was that under load or just idle?
> I've
> attached a log of loading the driver with debug=15, transmitting
> a few packets, then setting it down and up again and trying to
> transmit a few more packets (which didn't work).
>
What kind of switch.
--
Stephen Hemminger <shemminger@linux-foundation.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: sky bugs in 2.6.22-rc5
2007-06-18 20:47 ` Stephen Hemminger
@ 2007-06-18 20:56 ` Patrick McHardy
0 siblings, 0 replies; 9+ messages in thread
From: Patrick McHardy @ 2007-06-18 20:56 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Linux Netdev List
Stephen Hemminger wrote:
> On Mon, 18 Jun 2007 22:43:50 +0200
> Patrick McHardy <kaber@trash.net> wrote:
>
>>Unloading the driver (with your patch) crashed my box twice.
>
> Was that under load or just idle?
Pretty much idle, maybe a few NTP broadcasts flying around.
>>I've
>>attached a log of loading the driver with debug=15, transmitting
>>a few packets, then setting it down and up again and trying to
>>transmit a few more packets (which didn't work).
>>
>
>
> What kind of switch.
Some ten year old noname 10/100 switch. But it also happens
with the cable pulled.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2007-06-18 20:56 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-18 19:49 sky bugs in 2.6.22-rc5 Patrick McHardy
2007-06-18 19:51 ` Stephen Hemminger
2007-06-18 20:00 ` Patrick McHardy
2007-06-18 20:04 ` Stephen Hemminger
2007-06-18 20:13 ` Patrick McHardy
2007-06-18 20:20 ` Stephen Hemminger
2007-06-18 20:43 ` Patrick McHardy
2007-06-18 20:47 ` Stephen Hemminger
2007-06-18 20:56 ` Patrick McHardy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).