From: Patrick McHardy <kaber@trash.net>
To: Florian Westphal <fw-kernel@strlen.de>
Cc: netdev@vger.kernel.org, jon.maloy@ericsson.com,
allan.stephens@windriver.com, per.liden@ericsson.com,
tipc-discussion@lists.sourceforge.net
Subject: Re: [PATCH] TIPC: Fix infinite loop in netlink handler
Date: Tue, 19 Jun 2007 23:32:47 +0200 [thread overview]
Message-ID: <46784B7F.8050903@trash.net> (raw)
In-Reply-To: <20070619201834.GH4383@Chamillionaire.breakpoint.cc>
Florian Westphal wrote:
> From: Florian Westphal <fw@strlen.de>
>
> The tipc netlink config handler uses the nlmsg_pid from the
> request header as destination for its reply. If the application
> initialized nlmsg_pid to 0, the reply is looped back to the kernel,
> causing hangup. Fix: use nlmsg_pid of the skb that triggered the
> request.
>
> - genlmsg_unicast(rep_buf, req_nlh->nlmsg_pid);
> + genlmsg_unicast(rep_buf, NETLINK_CB(skb).pid);
This is the second time we're seeing this bug within a few weeks,
maybe we should rename NETLINK_CB(skb).pid to dst_pid to avoid
similar confusion in the future? We could even rename nlmsg_pid
to nlmsg_src within the kernel, which should make it completely
clear what is being refered to.
next prev parent reply other threads:[~2007-06-19 21:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-19 20:18 [PATCH] TIPC: Fix infinite loop in netlink handler Florian Westphal
2007-06-19 21:32 ` Patrick McHardy [this message]
2007-06-20 14:13 ` Stephens, Allan
2007-06-20 16:12 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46784B7F.8050903@trash.net \
--to=kaber@trash.net \
--cc=allan.stephens@windriver.com \
--cc=fw-kernel@strlen.de \
--cc=jon.maloy@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=per.liden@ericsson.com \
--cc=tipc-discussion@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).