netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Jay Vosburgh <fubar@us.ibm.com>
Cc: Stephen Hemminger <shemminger@linux-foundation.org>,
	"David S. Miller" <davem@davemloft.net>,
	Dan Aloni <da-x@monatomic.org>,
	Chad Tindel <ctindel@users.sourceforge.net>,
	Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
	netdev@vger.kernel.org,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	bonding-devel@lists.sourceforge.net
Subject: Re: [PATCH] bonding: Fix use after free in unregister path
Date: Wed, 20 Jun 2007 19:12:54 -0400	[thread overview]
Message-ID: <4679B476.9060503@garzik.org> (raw)
In-Reply-To: <24302.1182276732@death>

Jay Vosburgh wrote:
> 	The following patch (based on a patch from Stephen Hemminger
> <shemminger@linux-foundation.org>) removes use after free conditions in
> the unregister path for the bonding master.  Without this patch, an
> operation of the form "echo -bond0 > /sys/class/net/bonding_masters"
> would trigger a NULL pointer dereference in sysfs.  I was not able to
> induce the failure with the non-sysfs code path, but for consistency I
> updated that code as well.
> 
> 	I also did some testing of the bonding /proc file being open
> while the bond is being deleted, and didn't see any problems there.
> 
> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>

applied to #upstream-fixes



  reply	other threads:[~2007-06-20 23:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-11  5:40 [BUG][PATCH] Fix race condition about network device name allocation Kenji Kaneshige
2007-05-11 15:50 ` Stephen Hemminger
2007-05-11 16:25 ` Stephen Hemminger
2007-05-14  1:33   ` Kenji Kaneshige
2007-05-14 15:41     ` Stephen Hemminger
2007-05-14  8:17   ` Kenji Kaneshige
2007-05-14 15:58     ` [PATCH] " Stephen Hemminger
2007-06-13  9:45       ` Dan Aloni
2007-06-13 16:36         ` Stephen Hemminger
2007-06-14  6:07           ` Dan Aloni
2007-06-13 22:53         ` Stephen Hemminger
2007-06-14  4:36           ` Jay Vosburgh
2007-06-19 15:23             ` Why is this patch not in 2.6.22-rc5? Stephen Hemminger
2007-06-19 17:52               ` Jeff Garzik
2007-06-19 18:12                 ` [PATCH] bonding: Fix use after free in unregister path Jay Vosburgh
2007-06-20 23:12                   ` Jeff Garzik [this message]
2007-06-21  0:09                     ` Chris Wright
2007-06-19 22:04                 ` Why is this patch not in 2.6.22-rc5? David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4679B476.9060503@garzik.org \
    --to=jeff@garzik.org \
    --cc=akpm@linux-foundation.org \
    --cc=bonding-devel@lists.sourceforge.net \
    --cc=ctindel@users.sourceforge.net \
    --cc=da-x@monatomic.org \
    --cc=davem@davemloft.net \
    --cc=fubar@us.ibm.com \
    --cc=kaneshige.kenji@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).