From: Patrick McHardy <kaber@trash.net>
To: Ben Greear <greearb@candelatech.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
netdev@vger.kernel.org, shemminger@linux-foundation.org,
davem@davemloft.net, jeff@garzik.org
Subject: Re: [RFC NET 00/02]: Secondary unicast address support
Date: Fri, 22 Jun 2007 13:36:32 +0200 [thread overview]
Message-ID: <467BB440.3010700@trash.net> (raw)
In-Reply-To: <467B404F.2080504@candelatech.com>
Ben Greear wrote:
> Patrick McHardy wrote:
>
>> Eric W. Biederman wrote:
>>
>>> For the macvlan hash you just use an upper byte. Is that just a
>>> simple starting place, or do we not need a more complex hash.
>>>
>>
>>
>> That gave me an idea, since the default addresses are random
>> anyway I'm now using an incrementing counter for the upper byte.
>
>
> Is there not a (relatively) easy way to hash the entire 6 bytes?
>
> I'd prefer to be able to set the MACs to anything I want, without
> worrying about trivially hitting a worst-case hash scenario.
That would only happen if all your addresses have the same high
byte. I can't see a reason why you would want to do this, even
with manually configured addresses its still reasonable to
expect a uniform distribution.
prev parent reply other threads:[~2007-06-22 11:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-20 18:00 [RFC NET 00/02]: Secondary unicast address support Patrick McHardy
2007-06-20 18:00 ` [RFC NET 01/02]: " Patrick McHardy
2007-06-20 18:00 ` [RFC E1000 02/02]: " Patrick McHardy
2007-06-21 19:08 ` [RFC NET 00/02]: " Eric W. Biederman
2007-06-21 19:13 ` David Miller
2007-06-21 21:11 ` Caitlin Bestler
2007-06-21 19:13 ` Patrick McHardy
2007-06-21 20:31 ` Eric W. Biederman
2007-06-22 0:08 ` Patrick McHardy
2007-06-22 3:30 ` Ben Greear
2007-06-22 4:30 ` Eric W. Biederman
2007-06-22 12:08 ` Ben Greear
2007-06-22 1:56 ` Patrick McHardy
2007-06-22 3:21 ` Ben Greear
2007-06-22 11:36 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=467BB440.3010700@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=greearb@candelatech.com \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).