Re: [patch 0/7] CAN: Add new PF_CAN protocol family, try #3

[Oliver Hartkopp <oliver@hartkopp.net>]

Patrick McHardy wrote:
> Oliver Hartkopp wrote:
>
>>
>> Is it the right approach to let netif_receive_skb() set the iif-value or
>> should we better set this value on our own before invoking netif_rx()?
>>   
>
> netif_receive_skb is meant to be used as a default, the driver can
> override this if it makes sense. If you touch it anyway you might
> as well set it to the final value.

The CAN bus is really not that high sophisticated network technology, so
it does not need more than the default internal network transport
mechanics the Linux Kernel already provides in an excellent manner.

I also thought about setting skb->iif myself to ensure the correct value
to be set - maybe Jamal has also an opinion on this. The CAN bus only
transports CAN-frames with a 11/29 bit CAN-Identifier (for CSMA/CA
arbitration) with up to 8 Bytes of payload. There is no space for VLANs
and other addressing schemes that are known from Ethernet or other
network media. So in opposite to all the fancy VLANs, routing, filter,
NAT and whatever the CAN is really dumb ;-)

Regards,
Oliver