From: David Ahern <dsahern@gmail.com>
To: "Ian K. Coolidge" <icoolidge@google.com>, netdev@vger.kernel.org
Cc: ek@google.com
Subject: Re: [PATCH v2 1/2] iproute2: ip addr: Organize flag properties structurally
Date: Sun, 31 May 2020 17:09:07 -0600 [thread overview]
Message-ID: <467c2970-e986-67af-2d19-371b19f8bfbf@gmail.com> (raw)
In-Reply-To: <20200527180346.58573-1-icoolidge@google.com>
On 5/27/20 12:03 PM, Ian K. Coolidge wrote:
> This creates a nice systematic way to check that the various flags are
> mutable from userspace and that the address family is valid.
>
> Mutability properties are preserved to avoid introducing any behavioral
> change in this CL. However, previously, immutable flags were ignored and
> fell through to this confusing error:
>
> Error: either "local" is duplicate, or "dadfailed" is a garbage.
>
> But now, they just warn more explicitly:
>
> Warning: dadfailed option is not mutable from userspace
> ---
> ip/ipaddress.c | 112 ++++++++++++++++++++++++-------------------------
> 1 file changed, 55 insertions(+), 57 deletions(-)
>
applied both to iproute2-next. Thanks,
prev parent reply other threads:[~2020-05-31 23:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-24 1:51 [PATCH] iproute2: ip addr: Accept 'optimistic' flag Ian K. Coolidge
2020-05-24 5:06 ` Erik Kline
2020-05-24 19:09 ` Stephen Hemminger
2020-05-27 18:03 ` [PATCH v2 1/2] iproute2: ip addr: Organize flag properties structurally Ian K. Coolidge
2020-05-27 18:03 ` [PATCH v2 2/2] iproute2: ip addr: Add support for setting 'optimistic' Ian K. Coolidge
2020-05-31 23:09 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=467c2970-e986-67af-2d19-371b19f8bfbf@gmail.com \
--to=dsahern@gmail.com \
--cc=ek@google.com \
--cc=icoolidge@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).