From: Vlad Yasevich <vladislav.yasevich@hp.com>
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: Zach Brown <zach.brown@oracle.com>,
lksctp-developers@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [PATCH] sctp: lock_sock_nested in sctp_sock_migrate
Date: Mon, 25 Jun 2007 16:38:20 -0400 [thread overview]
Message-ID: <468027BC.1070706@hp.com> (raw)
In-Reply-To: <46802460.3080303@linux.intel.com>
Arjan van de Ven wrote:
> Vlad Yasevich wrote:
>> Hm... This is another case of of two different sockets taking the same
>> lock...
>>
>> Arjan, did this every get fixed, or is the nested locking the right
>> solution
>> to this?
>>
>
> for this specific case it's ok and the nested solution is right.
> In the general case it's obviously not safe to take the locks of two
> sockets in "unspecified" order....
>
Well, in this case the order is very carefully specified, but I was more
interested in what the right solution is.
The newsk, from the patch, has just been created, but needs to be locked
to prevent soft_irq from queuing packets to it while we are mucking around.
This is the same case as the accept case that had issues some time ago.
-vlad
prev parent reply other threads:[~2007-06-25 20:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-22 22:14 [PATCH] sctp: lock_sock_nested in sctp_sock_migrate Zach Brown
2007-06-25 20:24 ` Vlad Yasevich
2007-06-25 20:24 ` Arjan van de Ven
2007-06-25 20:38 ` Vlad Yasevich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=468027BC.1070706@hp.com \
--to=vladislav.yasevich@hp.com \
--cc=arjan@linux.intel.com \
--cc=lksctp-developers@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).